diff mbox

[ovs-dev,v2] ovs-bugtool: Add conntrack output

Message ID 1452729104-61503-1-git-send-email-u9012063@gmail.com
State Accepted
Headers show

Commit Message

William Tu Jan. 13, 2016, 11:51 p.m. UTC
Add a script to show all the connection entries in the tracker.

Signed-off-by: William Tu <u9012063@gmail.com>
---
 utilities/bugtool/automake.mk                         |  4 +++-
 utilities/bugtool/ovs-bugtool-conntrack-dump          | 19 +++++++++++++++++++
 .../bugtool/plugins/network-status/openvswitch.xml    |  1 +
 xenserver/README                                      |  5 +++++
 4 files changed, 28 insertions(+), 1 deletion(-)
 create mode 100644 utilities/bugtool/ovs-bugtool-conntrack-dump

Comments

Gurucharan Shetty Jan. 14, 2016, 5:06 p.m. UTC | #1
On 13 January 2016 at 15:51, William Tu <u9012063@gmail.com> wrote:

> Add a script to show all the connection entries in the tracker.
>
> Signed-off-by: William Tu <u9012063@gmail.com>
>

Thank you, applied!



> ---
>  utilities/bugtool/automake.mk                         |  4 +++-
>  utilities/bugtool/ovs-bugtool-conntrack-dump          | 19
> +++++++++++++++++++
>  .../bugtool/plugins/network-status/openvswitch.xml    |  1 +
>  xenserver/README                                      |  5 +++++
>  4 files changed, 28 insertions(+), 1 deletion(-)
>  create mode 100644 utilities/bugtool/ovs-bugtool-conntrack-dump
>
> diff --git a/utilities/bugtool/automake.mk b/utilities/bugtool/automake.mk
> index 36d80ce..b11cf1a 100644
> --- a/utilities/bugtool/automake.mk
> +++ b/utilities/bugtool/automake.mk
> @@ -28,7 +28,9 @@ bugtool_scripts = \
>         utilities/bugtool/ovs-bugtool-ovs-ofctl-show \
>         utilities/bugtool/ovs-bugtool-ovs-ofctl-dump-flows \
>         utilities/bugtool/ovs-bugtool-ovs-appctl-dpif \
> -       utilities/bugtool/ovs-bugtool-bond-show
> +       utilities/bugtool/ovs-bugtool-bond-show \
> +       utilities/bugtool/ovs-bugtool-conntrack-dump
> +
>  scripts_SCRIPTS += $(bugtool_scripts)
>
>  bugtoolpluginsdir = $(pkgdatadir)/bugtool-plugins
> diff --git a/utilities/bugtool/ovs-bugtool-conntrack-dump
> b/utilities/bugtool/ovs-bugtool-conntrack-dump
> new file mode 100644
> index 0000000..2a72c5a
> --- /dev/null
> +++ b/utilities/bugtool/ovs-bugtool-conntrack-dump
> @@ -0,0 +1,19 @@
> +#! /bin/sh
> +
> +# This library is free software; you can redistribute it and/or
> +# modify it under the terms of version 2.1 of the GNU Lesser General
> +# Public License as published by the Free Software Foundation.
> +#
> +# This library is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +# Lesser General Public License for more details.
> +#
> +# You should have received a copy of the GNU Lesser General Public
> +# License along with this library; if not, write to the Free Software
> +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> +# USA
> +#
> +# Copyright (C) 2016 Nicira, Inc.
> +
> +ovs-appctl dpctl/dump-conntrack
> diff --git a/utilities/bugtool/plugins/network-status/openvswitch.xml
> b/utilities/bugtool/plugins/network-status/openvswitch.xml
> index 836cd6e..bb6792a 100644
> --- a/utilities/bugtool/plugins/network-status/openvswitch.xml
> +++ b/utilities/bugtool/plugins/network-status/openvswitch.xml
> @@ -24,6 +24,7 @@
>    <command label="ovs-appctl-lacp-show"
> filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-lacp-show</command>
>    <command label="ovs-appctl-cfm-show"
> filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-cfm-show</command>
>    <command label="ovs-appctl-bfd-show"
> filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-bfd-show</command>
> +  <command label="ovs-appctl-conntrack-dump"
> filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-conntrack-dump</command>
>    <command label="ovs-appctl-coverage-show"
> filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-coverage-show</command>
>    <command label="ovs-appctl-bond-show"
> filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-bond-show</command>
>    <command label="ovs-appctl-memory-show"
> filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-memory-show</command>
> diff --git a/xenserver/README b/xenserver/README
> index 36ea567..87378d0 100644
> --- a/xenserver/README
> +++ b/xenserver/README
> @@ -95,6 +95,7 @@ debugging.  The sources for the extensions are in
>              * ovs-bugtool-coverage-show
>              * ovs-bugtool-memory-show
>              * ovs-bugtool-vsctl-show
> +            * ovs-bugtool-conntrack-dump
>
>      system-configuration/openvswitch.xml
>
> @@ -168,6 +169,10 @@ scripts are located in ../utilities/bugtool:
>
>          Script to show a brief overview of the database contents.
>
> +    ovs-bugtool-conntrack-dump
> +
> +        Script to show all the connection entries in the tracker.
> +
>      ovs-bugtool-daemons-ver
>
>          Script to dump version information for all Open vSwitch daemons.
> --
> 2.5.0
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
Joe Stringer Jan. 14, 2016, 5:45 p.m. UTC | #2
On 14 January 2016 at 09:06, Guru Shetty <guru@ovn.org> wrote:
> On 13 January 2016 at 15:51, William Tu <u9012063@gmail.com> wrote:
>
>> Add a script to show all the connection entries in the tracker.
>>
>> Signed-off-by: William Tu <u9012063@gmail.com>
>>
>
> Thank you, applied!

Did you apply this to branch-2.5 as well? I think that this could be
useful when debugging issues on that version.
Gurucharan Shetty Jan. 14, 2016, 10:04 p.m. UTC | #3
On 14 January 2016 at 09:45, Joe Stringer <joe@ovn.org> wrote:

> On 14 January 2016 at 09:06, Guru Shetty <guru@ovn.org> wrote:
> > On 13 January 2016 at 15:51, William Tu <u9012063@gmail.com> wrote:
> >
> >> Add a script to show all the connection entries in the tracker.
> >>
> >> Signed-off-by: William Tu <u9012063@gmail.com>
> >>
> >
> > Thank you, applied!
>
> Did you apply this to branch-2.5 as well? I think that this could be
> useful when debugging issues on that version.
>

I cherry-picked it just now.
diff mbox

Patch

diff --git a/utilities/bugtool/automake.mk b/utilities/bugtool/automake.mk
index 36d80ce..b11cf1a 100644
--- a/utilities/bugtool/automake.mk
+++ b/utilities/bugtool/automake.mk
@@ -28,7 +28,9 @@  bugtool_scripts = \
 	utilities/bugtool/ovs-bugtool-ovs-ofctl-show \
 	utilities/bugtool/ovs-bugtool-ovs-ofctl-dump-flows \
 	utilities/bugtool/ovs-bugtool-ovs-appctl-dpif \
-	utilities/bugtool/ovs-bugtool-bond-show
+	utilities/bugtool/ovs-bugtool-bond-show \
+	utilities/bugtool/ovs-bugtool-conntrack-dump
+
 scripts_SCRIPTS += $(bugtool_scripts)
 
 bugtoolpluginsdir = $(pkgdatadir)/bugtool-plugins
diff --git a/utilities/bugtool/ovs-bugtool-conntrack-dump b/utilities/bugtool/ovs-bugtool-conntrack-dump
new file mode 100644
index 0000000..2a72c5a
--- /dev/null
+++ b/utilities/bugtool/ovs-bugtool-conntrack-dump
@@ -0,0 +1,19 @@ 
+#! /bin/sh
+
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of version 2.1 of the GNU Lesser General
+# Public License as published by the Free Software Foundation.
+#
+# This library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this library; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
+# USA
+#
+# Copyright (C) 2016 Nicira, Inc.
+
+ovs-appctl dpctl/dump-conntrack
diff --git a/utilities/bugtool/plugins/network-status/openvswitch.xml b/utilities/bugtool/plugins/network-status/openvswitch.xml
index 836cd6e..bb6792a 100644
--- a/utilities/bugtool/plugins/network-status/openvswitch.xml
+++ b/utilities/bugtool/plugins/network-status/openvswitch.xml
@@ -24,6 +24,7 @@ 
   <command label="ovs-appctl-lacp-show" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-lacp-show</command>
   <command label="ovs-appctl-cfm-show" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-cfm-show</command>
   <command label="ovs-appctl-bfd-show" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-bfd-show</command>
+  <command label="ovs-appctl-conntrack-dump" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-conntrack-dump</command>
   <command label="ovs-appctl-coverage-show" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-coverage-show</command>
   <command label="ovs-appctl-bond-show" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-bond-show</command>
   <command label="ovs-appctl-memory-show" filters="ovs">/usr/share/openvswitch/scripts/ovs-bugtool-memory-show</command>
diff --git a/xenserver/README b/xenserver/README
index 36ea567..87378d0 100644
--- a/xenserver/README
+++ b/xenserver/README
@@ -95,6 +95,7 @@  debugging.  The sources for the extensions are in
             * ovs-bugtool-coverage-show
             * ovs-bugtool-memory-show
             * ovs-bugtool-vsctl-show
+            * ovs-bugtool-conntrack-dump
 
     system-configuration/openvswitch.xml
 
@@ -168,6 +169,10 @@  scripts are located in ../utilities/bugtool:
 
         Script to show a brief overview of the database contents.
 
+    ovs-bugtool-conntrack-dump
+
+        Script to show all the connection entries in the tracker.
+
     ovs-bugtool-daemons-ver
 
         Script to dump version information for all Open vSwitch daemons.