diff mbox

[ovs-dev,3/4] ovsdb-client: fix memory leak reported by valgrind

Message ID 1452106178-55876-3-git-send-email-u9012063@gmail.com
State Not Applicable
Headers show

Commit Message

William Tu Jan. 6, 2016, 6:49 p.m. UTC 
Test case 1508-1514: OVSDB -- ovsdb-server monitors, call stacks:
    ovsdb_schema_create (ovsdb.c:34)
    ovsdb_schema_from_json (ovsdb.c:196)
    fetch_schema (ovsdb-client.c:375)
    do_monitor__ (ovsdb-client.c:920)
    main (ovsdb-client.c:152)
Fix by adding ovsdb_schema_destroy()

Signed-off-by: William Tu <u9012063@gmail.com>
Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
Co-authored-by: Daniele Di Proietto <diproiettod@vmware.com
---
 ovsdb/ovsdb-client.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ben Pfaff Jan. 11, 2016, 4:49 p.m. UTC | #1 
On Wed, Jan 06, 2016 at 10:49:37AM -0800, William Tu wrote:
> Test case 1508-1514: OVSDB -- ovsdb-server monitors, call stacks:
>     ovsdb_schema_create (ovsdb.c:34)
>     ovsdb_schema_from_json (ovsdb.c:196)
>     fetch_schema (ovsdb-client.c:375)
>     do_monitor__ (ovsdb-client.c:920)
>     main (ovsdb-client.c:152)
> Fix by adding ovsdb_schema_destroy()
> 
> Signed-off-by: William Tu <u9012063@gmail.com>
> Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com>
> Co-authored-by: Daniele Di Proietto <diproiettod@vmware.com

Applied, thanks!
diff mbox

Patch

diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c
index 8c48338..9a6f3e9 100644
--- a/ovsdb/ovsdb-client.c
+++ b/ovsdb/ovsdb-client.c
@@ -1024,6 +1024,7 @@  do_monitor__(struct jsonrpc *rpc, const char *database,
         unixctl_server_wait(unixctl);
         poll_block();
     }
+    ovsdb_schema_destroy(schema);
 }
 
 static void