diff mbox

[ovs-dev,5/5] tests: add Valgrind suppression file ovs.supp

Message ID 1449799096-40786-5-git-send-email-u9012063@gmail.com
State Changes Requested
Headers show

Commit Message

William Tu Dec. 11, 2015, 1:58 a.m. UTC 
Signed-off-by: William Tu <u9012063@gmail.com>
---
 tests/automake.mk |  3 +-
 tests/ovs.supp    | 86 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 88 insertions(+), 1 deletion(-)
 create mode 100644 tests/ovs.supp

Comments

Ben Pfaff Dec. 23, 2015, 7:13 a.m. UTC | #1 
On Thu, Dec 10, 2015 at 05:58:16PM -0800, William Tu wrote:
> Signed-off-by: William Tu <u9012063@gmail.com>

I think maybe we need comments that explain why each suppression is
desirable, because they aren't obvious to me at a glance.
diff mbox

Patch

diff --git a/tests/automake.mk b/tests/automake.mk
index bd06a51..1b218da 100644
--- a/tests/automake.mk
+++ b/tests/automake.mk
@@ -183,9 +183,10 @@  CLEANFILES += $(valgrind_wrappers)
 EXTRA_DIST += tests/valgrind-wrapper.in
 
 VALGRIND = valgrind --log-file=valgrind.%p --leak-check=full \
+	--suppressions=$(abs_top_srcdir)/tests/ovs.supp \
 	--suppressions=$(abs_top_srcdir)/tests/glibc.supp \
 	--suppressions=$(abs_top_srcdir)/tests/openssl.supp --num-callers=20
-EXTRA_DIST += tests/glibc.supp tests/openssl.supp
+EXTRA_DIST += tests/glibc.supp tests/openssl.supp tests/ovs.supp
 check-valgrind: all tests/atconfig tests/atlocal $(TESTSUITE) \
                 $(valgrind_wrappers) $(check_DATA)
 	$(SHELL) '$(TESTSUITE)' -C tests CHECK_VALGRIND=true VALGRIND='$(VALGRIND)' AUTOTEST_PATH='tests/valgrind:$(AUTOTEST_PATH)' -d $(TESTSUITEFLAGS)
diff --git a/tests/ovs.supp b/tests/ovs.supp
new file mode 100644
index 0000000..6be3863
--- /dev/null
+++ b/tests/ovs.supp
@@ -0,0 +1,86 @@ 
+# suppress errors from valgrind
+{
+   test_case_0381
+   Memcheck:Leak
+   match-leak-kinds: definite
+#   fun:malloc
+#   fun:xmalloc
+#   fun:ofpbuf_new
+#   fun:ofpbuf_new_with_headroom
+#   fun:ofpbuf_clone_data_with_headroom
+#   fun:ofpbuf_clone_with_headroom
+#   fun:recirc_state_clone
+   ...
+   fun:recirc_alloc_id__
+   fun:recirc_alloc_id_ctx
+   fun:compose_recirculate_action__
+   fun:xlate_actions
+}
+
+{
+   test_case_0643
+   Memcheck:Leak
+   match-leak-kinds: definite
+#   fun:malloc
+#   fun:xmalloc
+#   fun:resize
+#   fun:tun_metadata_add_entry
+   ...
+   fun:tun_metadata_table_mod
+   fun:handle_geneve_table_mod
+   fun:handle_openflow__
+   fun:handle_openflow
+}
+
+{
+   test_case_0886
+   Memcheck:Leak
+   match-leak-kinds: definite
+#   fun:malloc
+#   fun:xmalloc
+   ...
+   fun:dp_packet_new
+   fun:eth_from_packet_or_flow
+   fun:netdev_dummy_receive
+   fun:process_command
+   fun:run_connection
+   fun:unixctl_server_run
+}
+
+{
+   test_case_1419
+   Memcheck:Leak
+   match-leak-kinds: definite
+#   fun:realloc
+#   fun:xrealloc
+#   fun:ovsdb_column_set_add
+   ...
+   fun:add_column
+   fun:parse_monitor_columns
+   fun:add_monitored_table
+   fun:do_monitor
+}
+
+{
+   test_case_1419-2
+   Memcheck:Leak
+   match-leak-kinds: definite
+#   fun:malloc
+#   fun:xmalloc
+   ...
+   fun:unixctl_server_create
+   fun:do_monitor
+}
+
+{
+   test_case_1690
+   Memcheck:Leak
+   match-leak-kinds: definite
+#   fun:malloc
+#   fun:xmalloc
+#   fun:lldp_create_dummy
+   ...
+   fun:test_aa_send
+   fun:test_aa_main
+}
+