diff mbox

[ovs-dev] docs: Document that --detach disables logging to the console.

Message ID 1448992529-7224-1-git-send-email-blp@ovn.org
State Accepted
Headers show

Commit Message

Ben Pfaff Dec. 1, 2015, 5:55 p.m. UTC
Reported-by: "P.R.Dinesh" <pr.dinesh@gmail.com>
Reported-at: http://openvswitch.org/pipermail/discuss/2015-December/019567.html
Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 lib/daemon.man | 11 +++++++----
 lib/vlog.man   |  4 +++-
 2 files changed, 10 insertions(+), 5 deletions(-)

Comments

Gurucharan Shetty Dec. 1, 2015, 6:05 p.m. UTC | #1
On 1 December 2015 at 09:55, Ben Pfaff <blp@ovn.org> wrote:

> Reported-by: "P.R.Dinesh" <pr.dinesh@gmail.com>
> Reported-at:
> http://openvswitch.org/pipermail/discuss/2015-December/019567.html
> Signed-off-by: Ben Pfaff <blp@ovn.org>
>
Acked-by: Gurucharan Shetty <guru@ovn.org>

> ---
>  lib/daemon.man | 11 +++++++----
>  lib/vlog.man   |  4 +++-
>  2 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/lib/daemon.man b/lib/daemon.man
> index ff0b157..78469cd 100644
> --- a/lib/daemon.man
> +++ b/lib/daemon.man
> @@ -18,10 +18,13 @@ overwrite the pidfile.
>  .IP
>  When \fB\-\-pidfile\fR is not specified, this option has no effect.
>  .
> -.TP
> -\fB\-\-detach\fR
> -Causes \fB\*(PN\fR to detach itself from the foreground session and
> -run as a background process. \*(DD
> +.IP \fB\-\-detach\fR
> +Runs \fB\*(PN\fR as a background process.  The process forks, and in
> +the child it starts a new session, closes the standard file
> +descriptors (which has the side effect of disabling logging to the
> +console), and changes its current directory to the root (unless
> +\fB\-\-no\-chdir\fR is specified).  After the child completes its
> +initialization, the parent exits.  \*(DD
>  .
>  .TP
>  \fB\-\-monitor\fR
> diff --git a/lib/vlog.man b/lib/vlog.man
> index 6994eec..674528d 100644
> --- a/lib/vlog.man
> +++ b/lib/vlog.man
> @@ -20,7 +20,9 @@ module.
>  .IP \(bu
>  \fBsyslog\fR, \fBconsole\fR, or \fBfile\fR, to limit the log level
>  change to only to the system log, to the console, or to a file,
> -respectively.
> +respectively.  (If \fB\-\-detach\fR is specified, \fB\*(PN\fR closes
> +its standard file descriptors, so logging to the console will have no
> +effect.)
>  .IP
>  On Windows platform, \fBsyslog\fR is accepted as a word and is only
>  useful along with the \fB\-\-syslog\-target\fR option (the word has no
> --
> 2.1.3
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
Ben Pfaff Dec. 1, 2015, 6:07 p.m. UTC | #2
On Tue, Dec 01, 2015 at 10:05:58AM -0800, Guru Shetty wrote:
> On 1 December 2015 at 09:55, Ben Pfaff <blp@ovn.org> wrote:
> 
> > Reported-by: "P.R.Dinesh" <pr.dinesh@gmail.com>
> > Reported-at:
> > http://openvswitch.org/pipermail/discuss/2015-December/019567.html
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
> >
> Acked-by: Gurucharan Shetty <guru@ovn.org>

Thanks Guru, I applied this to master.
diff mbox

Patch

diff --git a/lib/daemon.man b/lib/daemon.man
index ff0b157..78469cd 100644
--- a/lib/daemon.man
+++ b/lib/daemon.man
@@ -18,10 +18,13 @@  overwrite the pidfile.
 .IP
 When \fB\-\-pidfile\fR is not specified, this option has no effect.
 .
-.TP
-\fB\-\-detach\fR
-Causes \fB\*(PN\fR to detach itself from the foreground session and
-run as a background process. \*(DD
+.IP \fB\-\-detach\fR
+Runs \fB\*(PN\fR as a background process.  The process forks, and in
+the child it starts a new session, closes the standard file
+descriptors (which has the side effect of disabling logging to the
+console), and changes its current directory to the root (unless
+\fB\-\-no\-chdir\fR is specified).  After the child completes its
+initialization, the parent exits.  \*(DD
 .
 .TP
 \fB\-\-monitor\fR
diff --git a/lib/vlog.man b/lib/vlog.man
index 6994eec..674528d 100644
--- a/lib/vlog.man
+++ b/lib/vlog.man
@@ -20,7 +20,9 @@  module.
 .IP \(bu
 \fBsyslog\fR, \fBconsole\fR, or \fBfile\fR, to limit the log level
 change to only to the system log, to the console, or to a file,
-respectively.
+respectively.  (If \fB\-\-detach\fR is specified, \fB\*(PN\fR closes
+its standard file descriptors, so logging to the console will have no
+effect.)
 .IP
 On Windows platform, \fBsyslog\fR is accepted as a word and is only
 useful along with the \fB\-\-syslog\-target\fR option (the word has no