diff mbox

[ovs-dev,v3,3/5] tnl-neigh-cache: remove tnl_arp_lookup

Message ID 1448909586-32165-3-git-send-email-cascardo@redhat.com
State Deferred
Headers show

Commit Message

Thadeu Lima de Souza Cascardo Nov. 30, 2015, 6:53 p.m. UTC 
tnl_arp_lookup is not used anymore. All users have been converted to IPv4-mapped
addresses. New users need to use IPv4-mapped addresses and use tnl_neigh_lookup.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
---
 lib/tnl-neigh-cache.c | 19 -------------------
 lib/tnl-neigh-cache.h |  2 --
 2 files changed, 21 deletions(-)

Comments

Ben Pfaff Dec. 1, 2015, 8:26 p.m. UTC | #1 
On Mon, Nov 30, 2015 at 04:53:04PM -0200, Thadeu Lima de Souza Cascardo wrote:
> tnl_arp_lookup is not used anymore. All users have been converted to IPv4-mapped
> addresses. New users need to use IPv4-mapped addresses and use tnl_neigh_lookup.
> 
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>

Acked-by: Ben Pfaff <blp@ovn.org>
diff mbox

Patch

diff --git a/lib/tnl-neigh-cache.c b/lib/tnl-neigh-cache.c
index cf4082c..0bd4496 100644
--- a/lib/tnl-neigh-cache.c
+++ b/lib/tnl-neigh-cache.c
@@ -81,25 +81,6 @@  tnl_neigh_lookup__(const char br_name[IFNAMSIZ], const struct in6_addr *dst)
 }
 
 int
-tnl_arp_lookup(const char br_name[IFNAMSIZ], ovs_be32 dst,
-               struct eth_addr *mac)
-{
-    struct tnl_neigh_entry *neigh;
-    int res = ENOENT;
-    struct in6_addr dst6;
-
-    in6_addr_set_mapped_ipv4(&dst6, dst);
-
-    neigh = tnl_neigh_lookup__(br_name, &dst6);
-    if (neigh) {
-        *mac = neigh->mac;
-        res = 0;
-    }
-
-    return res;
-}
-
-int
 tnl_neigh_lookup(const char br_name[IFNAMSIZ], const struct in6_addr *dst,
                  struct eth_addr *mac)
 {
diff --git a/lib/tnl-neigh-cache.h b/lib/tnl-neigh-cache.h
index a9acd9e..fee8e6a 100644
--- a/lib/tnl-neigh-cache.h
+++ b/lib/tnl-neigh-cache.h
@@ -38,6 +38,4 @@  int tnl_neigh_lookup(const char dev_name[], const struct in6_addr *dst,
 void tnl_neigh_cache_init(void);
 void tnl_neigh_cache_run(void);
 
-int tnl_arp_lookup(const char dev_name[], ovs_be32 dst, struct eth_addr *mac);
-
 #endif