| Message ID | 1447355219-2538-1-git-send-email-russell@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Nov 12, 2015 at 2:06 PM, Russell Bryant <russell@ovn.org> wrote: > All of these links when viewing OVN-Tutorial on github, but most of > these links didn't work when viewing OVN-Tutorial.md.html in dist-docs. > Use full github links so that they always work (as long as you have > internet access). > > Signed-off-by: Russell Bryant <russell@ovn.org> > This LGTM. Acked-By: Kyle Mestery <mestery@mestery.com> --- > tutorial/OVN-Tutorial.md | 46 > +++++++++++++++++++++++----------------------- > 1 file changed, 23 insertions(+), 23 deletions(-) > > diff --git a/tutorial/OVN-Tutorial.md b/tutorial/OVN-Tutorial.md > index 5dd5da2..2e6a08d 100644 > --- a/tutorial/OVN-Tutorial.md > +++ b/tutorial/OVN-Tutorial.md > @@ -710,7 +710,7 @@ perspective and also provides an example of what the > resulting OpenFlow flows > look like. > > [ovn-architecture(7)]: > http://openvswitch.org/support/dist-docs/ovn-architecture.7.html > -[Tutorial.md]:./Tutorial.md > +[Tutorial.md]: > https://github.com/openvswitch/ovs/blob/master/tutorial/Tutorial.md > [ovn-nb(5)]:http://openvswitch.org/support/dist-docs/ovn-nb.5.html > [ovn-sb(5)]:http://openvswitch.org/support/dist-docs/ovn-sb.5.html > [vtep(5)]:http://openvswitch.org/support/dist-docs/vtep.5.html > @@ -720,26 +720,26 @@ look like. > [vtep-ctl(8)]:http://openvswitch.org/support/dist-docs/vtep-ctl.8.html > [ovn-nbctl(8)]:http://openvswitch.org/support/dist-docs/ovn-nbctl.8.html > [ovn-sbctl(8)]:http://openvswitch.org/support/dist-docs/ovn-sbctl.8.html > -[env1setup]:./ovn/env1/setup.sh > -[env1packet1]:./ovn/env1/packet1.sh > -[env1packet2]:./ovn/env1/packet2.sh > -[env1thirdport]:./ovn/env1/add-third-port.sh > -[env2setup]:./ovn/env2/setup.sh > -[env2packet1]:./ovn/env2/packet1.sh > -[env2packet2]:./ovn/env2/packet2.sh > -[env3setup]:./ovn/env3/setup.sh > -[env3packet1]:./ovn/env3/packet1.sh > -[env3packet2]:./ovn/env3/packet2.sh > -[env4setup1]:./ovn/env4/setup1.sh > -[env4setup2]:./ovn/env4/setup2.sh > -[env4packet1]:./ovn/env4/packet1.sh > -[env4packet2]:./ovn/env4/packet2.sh > -[env4packet3]:./ovn/env4/packet3.sh > -[env4packet4]:./ovn/env4/packet4.sh > -[env4packet5]:./ovn/env4/packet5.sh > -[env5setup]:./ovn/env5/setup.sh > -[env5packet1]:./ovn/env5/packet1.sh > -[env5packet2]:./ovn/env5/packet2.sh > -[env6setup]:./ovn/env6/setup.sh > -[env6acls]:./ovn/env6/add-acls.sh > +[env1setup]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env1/setup.sh > +[env1packet1]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env1/packet1.sh > +[env1packet2]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env1/packet2.sh > +[env1thirdport]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env1/add-third-port.sh > +[env2setup]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env2/setup.sh > +[env2packet1]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env2/packet1.sh > +[env2packet2]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env2/packet2.sh > +[env3setup]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env3/setup.sh > +[env3packet1]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env3/packet1.sh > +[env3packet2]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env3/packet2.sh > +[env4setup1]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env4/setup1.sh > +[env4setup2]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env4/setup2.sh > +[env4packet1]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env4/packet1.sh > +[env4packet2]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env4/packet2.sh > +[env4packet3]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env4/packet3.sh > +[env4packet4]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env4/packet4.sh > +[env4packet5]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env4/packet5.sh > +[env5setup]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env5/setup.sh > +[env5packet1]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env5/packet1.sh > +[env5packet2]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env5/packet2.sh > +[env6setup]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env6/setup.sh > +[env6acls]: > https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env6/add-acls.sh > [openstack-ovn-acl-blog]: > http://blog.russellbryant.net/2015/10/22/openstack-security-groups-using-ovn-acls/ > -- > 2.5.0 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev >
On Thu, Nov 12, 2015 at 2:44 PM, Kyle Mestery <mestery@mestery.com> wrote: > On Thu, Nov 12, 2015 at 2:06 PM, Russell Bryant <russell@ovn.org> wrote: > >> All of these links when viewing OVN-Tutorial on github, but most of >> these links didn't work when viewing OVN-Tutorial.md.html in dist-docs. >> Use full github links so that they always work (as long as you have >> internet access). >> >> Signed-off-by: Russell Bryant <russell@ovn.org> >> > > This LGTM. > > Acked-By: Kyle Mestery <mestery@mestery.com> > Thanks, Kyle. I pushed this to master.
On Thu, Nov 12, 2015 at 02:06:59PM -0500, Russell Bryant wrote: > All of these links when viewing OVN-Tutorial on github, but most of > these links didn't work when viewing OVN-Tutorial.md.html in dist-docs. > Use full github links so that they always work (as long as you have > internet access). > > Signed-off-by: Russell Bryant <russell@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
On Thu, Nov 12, 2015 at 4:27 PM, Ben Pfaff <blp@ovn.org> wrote: > On Thu, Nov 12, 2015 at 02:06:59PM -0500, Russell Bryant wrote: > > All of these links when viewing OVN-Tutorial on github, but most of > > these links didn't work when viewing OVN-Tutorial.md.html in dist-docs. > > Use full github links so that they always work (as long as you have > > internet access). > > > > Signed-off-by: Russell Bryant <russell@ovn.org> > > Acked-by: Ben Pfaff <blp@ovn.org> > Thanks for the ACK. Since it was simple, I pushed it fairly quickly earlier after an ACK from Kyle.
diff --git a/tutorial/OVN-Tutorial.md b/tutorial/OVN-Tutorial.md index 5dd5da2..2e6a08d 100644 --- a/tutorial/OVN-Tutorial.md +++ b/tutorial/OVN-Tutorial.md @@ -710,7 +710,7 @@ perspective and also provides an example of what the resulting OpenFlow flows look like. [ovn-architecture(7)]:http://openvswitch.org/support/dist-docs/ovn-architecture.7.html -[Tutorial.md]:./Tutorial.md +[Tutorial.md]:https://github.com/openvswitch/ovs/blob/master/tutorial/Tutorial.md [ovn-nb(5)]:http://openvswitch.org/support/dist-docs/ovn-nb.5.html [ovn-sb(5)]:http://openvswitch.org/support/dist-docs/ovn-sb.5.html [vtep(5)]:http://openvswitch.org/support/dist-docs/vtep.5.html @@ -720,26 +720,26 @@ look like. [vtep-ctl(8)]:http://openvswitch.org/support/dist-docs/vtep-ctl.8.html [ovn-nbctl(8)]:http://openvswitch.org/support/dist-docs/ovn-nbctl.8.html [ovn-sbctl(8)]:http://openvswitch.org/support/dist-docs/ovn-sbctl.8.html -[env1setup]:./ovn/env1/setup.sh -[env1packet1]:./ovn/env1/packet1.sh -[env1packet2]:./ovn/env1/packet2.sh -[env1thirdport]:./ovn/env1/add-third-port.sh -[env2setup]:./ovn/env2/setup.sh -[env2packet1]:./ovn/env2/packet1.sh -[env2packet2]:./ovn/env2/packet2.sh -[env3setup]:./ovn/env3/setup.sh -[env3packet1]:./ovn/env3/packet1.sh -[env3packet2]:./ovn/env3/packet2.sh -[env4setup1]:./ovn/env4/setup1.sh -[env4setup2]:./ovn/env4/setup2.sh -[env4packet1]:./ovn/env4/packet1.sh -[env4packet2]:./ovn/env4/packet2.sh -[env4packet3]:./ovn/env4/packet3.sh -[env4packet4]:./ovn/env4/packet4.sh -[env4packet5]:./ovn/env4/packet5.sh -[env5setup]:./ovn/env5/setup.sh -[env5packet1]:./ovn/env5/packet1.sh -[env5packet2]:./ovn/env5/packet2.sh -[env6setup]:./ovn/env6/setup.sh -[env6acls]:./ovn/env6/add-acls.sh +[env1setup]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env1/setup.sh +[env1packet1]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env1/packet1.sh +[env1packet2]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env1/packet2.sh +[env1thirdport]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env1/add-third-port.sh +[env2setup]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env2/setup.sh +[env2packet1]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env2/packet1.sh +[env2packet2]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env2/packet2.sh +[env3setup]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env3/setup.sh +[env3packet1]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env3/packet1.sh +[env3packet2]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env3/packet2.sh +[env4setup1]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env4/setup1.sh +[env4setup2]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env4/setup2.sh +[env4packet1]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env4/packet1.sh +[env4packet2]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env4/packet2.sh +[env4packet3]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env4/packet3.sh +[env4packet4]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env4/packet4.sh +[env4packet5]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env4/packet5.sh +[env5setup]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env5/setup.sh +[env5packet1]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env5/packet1.sh +[env5packet2]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env5/packet2.sh +[env6setup]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env6/setup.sh +[env6acls]:https://github.com/openvswitch/ovs/blob/master/tutorial/ovn/env6/add-acls.sh [openstack-ovn-acl-blog]:http://blog.russellbryant.net/2015/10/22/openstack-security-groups-using-ovn-acls/
All of these links when viewing OVN-Tutorial on github, but most of these links didn't work when viewing OVN-Tutorial.md.html in dist-docs. Use full github links so that they always work (as long as you have internet access). Signed-off-by: Russell Bryant <russell@ovn.org> --- tutorial/OVN-Tutorial.md | 46 +++++++++++++++++++++++----------------------- 1 file changed, 23 insertions(+), 23 deletions(-)