diff mbox

[ovs-dev,ICMP,v2,2/7] ovn-sb: Fix "ip.ttl--" lower limit description.

Message ID 1446594530-22162-3-git-send-email-jpettit@nicira.com
State Accepted
Headers show

Commit Message

Justin Pettit Nov. 3, 2015, 11:48 p.m. UTC
To decrement the IP TTL, the existing TTL can't be less than two.  The
field is not bit-maskable, though, so "ip.ttl < 2" will not work.

Signed-off-by: Justin Pettit <jpettit@nicira.com>
---
 ovn/ovn-sb.xml |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Russell Bryant Nov. 5, 2015, 3:43 p.m. UTC | #1
On Tue, Nov 3, 2015 at 6:48 PM, Justin Pettit <jpettit@nicira.com> wrote:

> To decrement the IP TTL, the existing TTL can't be less than two.  The
> field is not bit-maskable, though, so "ip.ttl < 2" will not work.
>
> Signed-off-by: Justin Pettit <jpettit@nicira.com>
> ---
>  ovn/ovn-sb.xml |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml
> index 9c2d411..e674f3a 100644
> --- a/ovn/ovn-sb.xml
> +++ b/ovn/ovn-sb.xml
> @@ -870,7 +870,8 @@
>              Decrements the IPv4 or IPv6 TTL.  If this would make the TTL
> zero
>              or negative, then processing of the packet halts; no further
>              actions are processed.  (To properly handle such cases, a
> -            higher-priority flow should match on <code>ip.ttl &lt;
> 2</code>.)
> +            higher-priority flow should match on
> +            <code>ip.ttl == {0, 1};</code>.)
>            </p>
>
>            <p><b>Prerequisite:</b> <code>ip</code></p>
>

Acked-by: Russell Bryant <rbryant@redhat.com>
diff mbox

Patch

diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml
index 9c2d411..e674f3a 100644
--- a/ovn/ovn-sb.xml
+++ b/ovn/ovn-sb.xml
@@ -870,7 +870,8 @@ 
             Decrements the IPv4 or IPv6 TTL.  If this would make the TTL zero
             or negative, then processing of the packet halts; no further
             actions are processed.  (To properly handle such cases, a
-            higher-priority flow should match on <code>ip.ttl &lt; 2</code>.)
+            higher-priority flow should match on
+            <code>ip.ttl == {0, 1};</code>.)
           </p>
 
           <p><b>Prerequisite:</b> <code>ip</code></p>