| Message ID | 1445534948-10538-9-git-send-email-cascardo@redhat.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On Thu, Oct 22, 2015 at 03:29:01PM -0200, Thadeu Lima de Souza Cascardo wrote: > Add netlink attributes for IPv6 tunnel addresses. This enables IPv6 support > for tunnels. > > [cascardo: Backport the key attribute values only.] > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> This causes a new warning: ../lib/odp-util.c:2116:17: error: enumeration values 'OVS_TUNNEL_KEY_ATTR_IPV6_SRC' and 'OVS_TUNNEL_KEY_ATTR_IPV6_DST' not explicitly handled in switch [-Werror,-Wswitch-enum] switch (type) { ^ (I'm the wrong person to review a datapath change anyway.)
On Tue, Nov 10, 2015 at 02:31:13PM -0800, Ben Pfaff wrote: > On Thu, Oct 22, 2015 at 03:29:01PM -0200, Thadeu Lima de Souza Cascardo wrote: > > Add netlink attributes for IPv6 tunnel addresses. This enables IPv6 support > > for tunnels. > > > > [cascardo: Backport the key attribute values only.] > > > > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> > > This causes a new warning: > > ../lib/odp-util.c:2116:17: error: enumeration values > 'OVS_TUNNEL_KEY_ATTR_IPV6_SRC' and 'OVS_TUNNEL_KEY_ATTR_IPV6_DST' not > explicitly handled in switch [-Werror,-Wswitch-enum] > switch (type) { > ^ > > (I'm the wrong person to review a datapath change anyway.) I will look at the warning, didn't show up for me when I used sparse and clang. I need to check why that have slipped. Nonetheless, it would be nice to hear from Pravin and Joe if the backport like this is OK. Thanks for your review. Cascardo.
diff --git a/datapath/linux/compat/include/linux/openvswitch.h b/datapath/linux/compat/include/linux/openvswitch.h index dae2e5b..c934c07 100644 --- a/datapath/linux/compat/include/linux/openvswitch.h +++ b/datapath/linux/compat/include/linux/openvswitch.h @@ -375,6 +375,8 @@ enum ovs_tunnel_key_attr { OVS_TUNNEL_KEY_ATTR_TP_SRC, /* be16 src Transport Port. */ OVS_TUNNEL_KEY_ATTR_TP_DST, /* be16 dst Transport Port. */ OVS_TUNNEL_KEY_ATTR_VXLAN_OPTS, /* Nested OVS_VXLAN_EXT_* */ + OVS_TUNNEL_KEY_ATTR_IPV6_SRC, /* struct in6_addr src IPv6 address. */ + OVS_TUNNEL_KEY_ATTR_IPV6_DST, /* struct in6_addr dst IPv6 address. */ __OVS_TUNNEL_KEY_ATTR_MAX };
Add netlink attributes for IPv6 tunnel addresses. This enables IPv6 support for tunnels. [cascardo: Backport the key attribute values only.] Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> --- datapath/linux/compat/include/linux/openvswitch.h | 2 ++ 1 file changed, 2 insertions(+)