diff mbox

[ovs-dev] ovn-northd: Fix memory leak in logical router flow generation.

Message ID 1445475976-29130-1-git-send-email-jpettit@nicira.com
State Accepted
Headers show

Commit Message

Justin Pettit Oct. 22, 2015, 1:06 a.m. UTC 
Signed-off-by: Justin Pettit <jpettit@nicira.com>
---
 ovn/northd/ovn-northd.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Russell Bryant Oct. 22, 2015, 6:32 a.m. UTC | #1 
On 10/21/2015 09:06 PM, Justin Pettit wrote:
> Signed-off-by: Justin Pettit <jpettit@nicira.com>
> ---
>  ovn/northd/ovn-northd.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
> index e199937..282f8ae 100644
> --- a/ovn/northd/ovn-northd.c
> +++ b/ovn/northd/ovn-northd.c
> @@ -1328,6 +1328,7 @@ build_lrouter_flows(struct hmap *datapaths, struct hmap *ports,
>              ETH_ADDR_ARGS(op->mac), op->json_key);
>          ovn_lflow_add(lflows, op->od, S_ROUTER_IN_ADMISSION, 50,
>                        match, "next;");
> +        free(match);
>      }
>  
>      /* Logical router ingress table 1: IP Input. */
> 

Acked-by: Russell Bryant <rbryant@redhat.com>
Justin Pettit Oct. 22, 2015, 6:34 a.m. UTC | #2 
> On Oct 21, 2015, at 11:32 PM, Russell Bryant <rbryant@redhat.com> wrote:
> 
> On 10/21/2015 09:06 PM, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit <jpettit@nicira.com>
>> ---
>> ovn/northd/ovn-northd.c |    1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>> 
>> diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
>> index e199937..282f8ae 100644
>> --- a/ovn/northd/ovn-northd.c
>> +++ b/ovn/northd/ovn-northd.c
>> @@ -1328,6 +1328,7 @@ build_lrouter_flows(struct hmap *datapaths, struct hmap *ports,
>>             ETH_ADDR_ARGS(op->mac), op->json_key);
>>         ovn_lflow_add(lflows, op->od, S_ROUTER_IN_ADMISSION, 50,
>>                       match, "next;");
>> +        free(match);
>>     }
>> 
>>     /* Logical router ingress table 1: IP Input. */
>> 
> 
> Acked-by: Russell Bryant <rbryant@redhat.com>

Thanks!  Pushed to master.

--Justin
diff mbox

Patch

diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
index e199937..282f8ae 100644
--- a/ovn/northd/ovn-northd.c
+++ b/ovn/northd/ovn-northd.c
@@ -1328,6 +1328,7 @@  build_lrouter_flows(struct hmap *datapaths, struct hmap *ports,
             ETH_ADDR_ARGS(op->mac), op->json_key);
         ovn_lflow_add(lflows, op->od, S_ROUTER_IN_ADMISSION, 50,
                       match, "next;");
+        free(match);
     }
 
     /* Logical router ingress table 1: IP Input. */