diff mbox

[ovs-dev] ovs-vswitchd.conf.db.5: Update docs for max-idle.

Message ID 1444854420-59975-1-git-send-email-joestringer@nicira.com
State Accepted, archived
Headers show

Commit Message

Joe Stringer Oct. 14, 2015, 8:27 p.m. UTC
When this configuration parameter was initially introduced into the
database, the documentation was not updated to describe where it
resides.

Fixes: 72310b041cfa ("upcall: Configure datapath max-idle through ovs-vsctl.")
Reported-by: Hadar Hen Zion <hadarh@dev.mellanox.co.il>
Signed-off-by: Joe Stringer <joestringer@nicira.com>
---
 vswitchd/vswitch.xml | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Ben Pfaff Oct. 14, 2015, 9:48 p.m. UTC | #1
On Wed, Oct 14, 2015 at 01:27:00PM -0700, Joe Stringer wrote:
> When this configuration parameter was initially introduced into the
> database, the documentation was not updated to describe where it
> resides.
> 
> Fixes: 72310b041cfa ("upcall: Configure datapath max-idle through ovs-vsctl.")
> Reported-by: Hadar Hen Zion <hadarh@dev.mellanox.co.il>
> Signed-off-by: Joe Stringer <joestringer@nicira.com>

Acked-by: Ben Pfaff <blp@nicira.com>
Justin Pettit Oct. 14, 2015, 10:02 p.m. UTC | #2
> On Oct 14, 2015, at 1:27 PM, Joe Stringer <joestringer@nicira.com> wrote:
> 
> When this configuration parameter was initially introduced into the
> database, the documentation was not updated to describe where it
> resides.

I think we didn't document it on purpose.  If we're going to document it, I'd recommend that we still discourage tweaking the value.

--Justin
diff mbox

Patch

diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index c94f42d1399b..6a699e0da180 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -152,6 +152,19 @@ 
         </p>
       </column>
 
+      <column name="other_config" key="max-idle"
+              type='{"type": "integer", "minInteger": 500}'>
+        <p>
+          The maximum time (in ms) that idle flows will remain cached in the
+          datapath. Internally OVS will check the validity and activity for
+          datapath flows regularly and may expire flows quicker than this
+          number, based on real time network conditions.
+        </p>
+        <p>
+          The default is 10000.
+        </p>
+      </column>
+
       <column name="other_config" key="n-dpdk-rxqs"
               type='{"type": "integer", "minInteger": 1}'>
         <p>