| Message ID | 1442271254-27897-11-git-send-email-azhou@nicira.com |
|---|---|
| State | Changes Requested |
| Headers | show |
On Mon, Sep 14, 2015 at 3:54 PM, Andy Zhou <azhou@nicira.com> wrote: > Runs OVSDB server and OVS Vswichd with --monitor option. This features How about: s/OVSDB server/ovsbd-server s/OVS Vswitchd/ovs-vswitchd s/features/feature > is useful for testing daemon monitoring, and in conjunction with This does not read fluently. Did you simply mean "monitoring together with"? > --user option. > > Signed-off-by: Andy Zhou <azhou@nicira.com> > --- > utilities/ovs-dev.py | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py > index 45fa38b..4e9c58e 100755 > --- a/utilities/ovs-dev.py > +++ b/utilities/ovs-dev.py > @@ -243,6 +243,9 @@ def run(): > if (options.user != "root:root"): > opts = ["--user", options.user] + opts > > + if (options.monitor): > + opts = ["--monitor"] + opts > + > _sh(*(["ovsdb-server", > "--remote=punix:%s/run/db.sock" % RUNDIR, > "--remote=db:Open_vSwitch,Open_vSwitch,manager_options", > @@ -430,6 +433,8 @@ def main(): > help="run all daemons as a non root user") > group.add_option("-u", dest="as_me", action="store_true", > help="set --user to the current user") > + group.add_option("-m", "--monitor", dest="monitor", action="store_true", > + help="run daemons with --monitor option") > > parser.add_option_group(group) > > -- > 1.9.1 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev
On Fri, Sep 18, 2015 at 11:41 AM, Ansis Atteka <aatteka@nicira.com> wrote: > On Mon, Sep 14, 2015 at 3:54 PM, Andy Zhou <azhou@nicira.com> wrote: >> Runs OVSDB server and OVS Vswichd with --monitor option. This features > How about: > s/OVSDB server/ovsbd-server > s/OVS Vswitchd/ovs-vswitchd > s/features/feature >> is useful for testing daemon monitoring, and in conjunction with > This does not read fluently. Did you simply mean "monitoring together with"? >> --user option. I will make the change in the next rev as suggested. Thank you.
diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py index 45fa38b..4e9c58e 100755 --- a/utilities/ovs-dev.py +++ b/utilities/ovs-dev.py @@ -243,6 +243,9 @@ def run(): if (options.user != "root:root"): opts = ["--user", options.user] + opts + if (options.monitor): + opts = ["--monitor"] + opts + _sh(*(["ovsdb-server", "--remote=punix:%s/run/db.sock" % RUNDIR, "--remote=db:Open_vSwitch,Open_vSwitch,manager_options", @@ -430,6 +433,8 @@ def main(): help="run all daemons as a non root user") group.add_option("-u", dest="as_me", action="store_true", help="set --user to the current user") + group.add_option("-m", "--monitor", dest="monitor", action="store_true", + help="run daemons with --monitor option") parser.add_option_group(group)
Runs OVSDB server and OVS Vswichd with --monitor option. This features is useful for testing daemon monitoring, and in conjunction with --user option. Signed-off-by: Andy Zhou <azhou@nicira.com> --- utilities/ovs-dev.py | 5 +++++ 1 file changed, 5 insertions(+)