From patchwork Thu Sep 10 20:18:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Pfaff X-Patchwork-Id: 516434 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (unknown [IPv6:2600:3c00::f03c:91ff:fe6e:bdf7]) by ozlabs.org (Postfix) with ESMTP id B18A11400B7 for ; Fri, 11 Sep 2015 06:18:58 +1000 (AEST) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 845F510B51; Thu, 10 Sep 2015 13:18:52 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v1.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id 80D8D106C4 for ; Thu, 10 Sep 2015 13:18:51 -0700 (PDT) Received: from bar3.cudamail.com (bar1 [192.168.15.1]) by mx3v1.cudamail.com (Postfix) with ESMTP id AC36B618DC3 for ; Thu, 10 Sep 2015 14:18:44 -0600 (MDT) X-ASG-Debug-ID: 1441916323-03dd7b773703900001-byXFYA Received: from mx3-pf2.cudamail.com ([192.168.14.1]) by bar3.cudamail.com with ESMTP id qlUntFcOvEr0sCSn (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 10 Sep 2015 14:18:44 -0600 (MDT) X-Barracuda-Envelope-From: blp@nicira.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.1 Received: from unknown (HELO mail-pa0-f50.google.com) (209.85.220.50) by mx3-pf2.cudamail.com with ESMTPS (RC4-SHA encrypted); 10 Sep 2015 20:18:42 -0000 Received-SPF: unknown (mx3-pf2.cudamail.com: Multiple SPF records returned) X-Barracuda-Apparent-Source-IP: 209.85.220.50 X-Barracuda-RBL-IP: 209.85.220.50 Received: by pacfv12 with SMTP id fv12so53150510pac.2 for ; Thu, 10 Sep 2015 13:18:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Kw2YzatWqAGg2cXz9tEv2qWlNzRhuUts5sNgwBW+UbU=; b=UwDQKTvP4Osepwp+J5qOscbuHf0Py4cGyUz6sjb+jB+AMk0RIBtDwWPjwb3G0Sandq o8qeFiH+uarf8xGxVw0TZ29TRc0fnECfUvNI+rxZSkDK6gJtMymviHsymO/9PQHTb3jk DJW/tznBYTmFdwC23eNA9i/pzE/bJJ/nK7AnIxNpJTLDxsKFFM+rcN2GcRQGYqTXNgFA /Gls9NP+s/TqROJK2z90l4+gKka0dERIlUtupobuHaB7FdG/TP2cY9rdDXuUljHSzQBy 0qE1Qt86a8al0Nb8KO7xt8Tq0o0tLy58TNo6Z7wEX7eusCpvDBHgkbPKRu8jIE65gtYR birA== X-Gm-Message-State: ALoCoQklfEbfoCp9P1igu05CHxMsm8U/BSXPYRbI2oSkccKWM/uR+9Ijvsdk0l/EZCQ4ETngtj1I X-Received: by 10.66.216.1 with SMTP id om1mr71053887pac.51.1441916322861; Thu, 10 Sep 2015 13:18:42 -0700 (PDT) Received: from sigabrt.benpfaff.org (173-228-112-165.dsl.dynamic.fusionbroadband.com. [173.228.112.165]) by smtp.gmail.com with ESMTPSA id fm5sm13608445pbb.60.2015.09.10.13.18.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 10 Sep 2015 13:18:41 -0700 (PDT) X-CudaMail-Envelope-Sender: blp@nicira.com From: Ben Pfaff To: dev@openvswitch.org X-CudaMail-Whitelist-To: dev@openvswitch.org X-CudaMail-MID: CM-V2-909053689 X-CudaMail-DTE: 091015 X-CudaMail-Originating-IP: 209.85.220.50 Date: Thu, 10 Sep 2015 13:18:54 -0700 X-ASG-Orig-Subj: [##CM-V2-909053689##][PATCH 1/2] ofproto: Reduce log level from WARN to INFO. Message-Id: <1441916335-22413-1-git-send-email-blp@nicira.com> X-Mailer: git-send-email 2.1.3 X-Barracuda-Connect: UNKNOWN[192.168.14.1] X-Barracuda-Start-Time: 1441916324 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?= X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 Cc: Ben Pfaff Subject: [ovs-dev] [PATCH 1/2] ofproto: Reduce log level from WARN to INFO. X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dev-bounces@openvswitch.org Sender: "dev" It seems to me that a controller bug doesn't rise to the level of a WARN that causes a testsuite failure (by default). Signed-off-by: Ben Pfaff Acked-by: Jarno Rajahalme --- ofproto/ofproto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index c1301b5..c7dd8a2 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@ -6369,7 +6369,7 @@ copy_buckets_for_insert_bucket(const struct ofgroup *ofgroup, ofputil_bucket_clone_list(&new_ofgroup->buckets, &ofgroup->buckets, NULL); if (ofputil_bucket_check_duplicate_id(&ofgroup->buckets)) { - VLOG_WARN_RL(&rl, "Duplicate bucket id"); + VLOG_INFO_RL(&rl, "Duplicate bucket id"); return OFPERR_OFPGMFC_BUCKET_EXISTS; } @@ -6605,7 +6605,7 @@ handle_group_mod(struct ofconn *ofconn, const struct ofp_header *oh) default: if (gm.command > OFPGC11_DELETE) { - VLOG_WARN_RL(&rl, "%s: Invalid group_mod command type %d", + VLOG_INFO_RL(&rl, "%s: Invalid group_mod command type %d", ofproto->name, gm.command); } return OFPERR_OFPGMFC_BAD_COMMAND;