mbox series

[ovs-dev,v6,0/1] Per pmd load based sleeping

Message ID 20231214111515.453167-1-ktraynor@redhat.com
Headers show
Series Per pmd load based sleeping | expand

Message

Kevin Traynor Dec. 14, 2023, 11:15 a.m. UTC
These patches allow specific sleep settings for PMD threads. It is
backwards compatabile with previously only allowing a global value.

v6:
- Reworked for Ilya v5 review
- Added NEWS
- Reworked list parsing to handle invalid key:value value correctly
- Added UTs for invalid values
- Other minor coding std changes

v5:
- Reworked from previous series

GHA: https://github.com/kevintraynor/ovs/actions/runs/7207817272
cirrus: https://cirrus-ci.com/build/6075630895235072

Kevin Traynor (1):
  dpif-netdev: Add per pmd sleep config.

 Documentation/topics/dpdk/pmd.rst |  34 ++-
 NEWS                              |   4 +
 lib/dpif-netdev-private-thread.h  |   3 +
 lib/dpif-netdev.c                 | 270 ++++++++++++++++++++---
 tests/pmd.at                      | 350 ++++++++++++++++++++++++++++--
 vswitchd/vswitch.xml              |  31 ++-
 6 files changed, 642 insertions(+), 50 deletions(-)

Comments

Ilya Maximets Dec. 16, 2023, 1:08 a.m. UTC | #1
On 12/14/23 12:15, Kevin Traynor wrote:
> These patches allow specific sleep settings for PMD threads. It is
> backwards compatabile with previously only allowing a global value.
> 
> v6:
> - Reworked for Ilya v5 review
> - Added NEWS
> - Reworked list parsing to handle invalid key:value value correctly
> - Added UTs for invalid values
> - Other minor coding std changes
> 
> v5:
> - Reworked from previous series
> 
> GHA: https://github.com/kevintraynor/ovs/actions/runs/7207817272
> cirrus: https://cirrus-ci.com/build/6075630895235072
> 
> Kevin Traynor (1):
>   dpif-netdev: Add per pmd sleep config.
> 
>  Documentation/topics/dpdk/pmd.rst |  34 ++-
>  NEWS                              |   4 +
>  lib/dpif-netdev-private-thread.h  |   3 +
>  lib/dpif-netdev.c                 | 270 ++++++++++++++++++++---
>  tests/pmd.at                      | 350 ++++++++++++++++++++++++++++--
>  vswitchd/vswitch.xml              |  31 ++-
>  6 files changed, 642 insertions(+), 50 deletions(-)
> 


Thanks, Kevin!  This version looks good to me and I also can't
reproduce the performance hit from v5, it probably been something
in my setup.

Applied.

Best regards, Ilya Maximets.