| Message ID | 20200513133135.48474-1-xiangxia.m.yue@gmail.com |
|---|---|
| Headers | show |
| Series | expand the meter table and fix bug | expand |
On Wed, May 13, 2020 at 09:31:31PM +0800, xiangxia.m.yue@gmail.com wrote: > From: Tonghao Zhang <xiangxia.m.yue@gmail.com> > > The patch set expand or shrink the meter table when necessary. > and other patches fix bug or improve codes. > > Tonghao Zhang (4): > dpif-netdev: Expand the meters supported number > dpif-netdev: Add burst size to buckets > dpif-netdev: Use the u64 instead of u32 for buckets > Revert "dpif-netdev: includes microsecond delta in meter bucket > calculation" > > include/openvswitch/ofp-meter.h | 2 +- > lib/dpif-netdev.c | 336 ++++++++++++++++++++++++-------- > lib/ofp-meter.c | 4 +- > 3 files changed, 257 insertions(+), 85 deletions(-) > Thanks! The series looks good to me. See if others have more comments. William
On 5/13/20 3:31 PM, xiangxia.m.yue@gmail.com wrote: > From: Tonghao Zhang <xiangxia.m.yue@gmail.com> > > The patch set expand or shrink the meter table when necessary. > and other patches fix bug or improve codes. > > Tonghao Zhang (4): > dpif-netdev: Expand the meters supported number > dpif-netdev: Add burst size to buckets > dpif-netdev: Use the u64 instead of u32 for buckets > Revert "dpif-netdev: includes microsecond delta in meter bucket > calculation" > > include/openvswitch/ofp-meter.h | 2 +- > lib/dpif-netdev.c | 336 ++++++++++++++++++++++++-------- > lib/ofp-meter.c | 4 +- > 3 files changed, 257 insertions(+), 85 deletions(-) > Thanks for working on this! General note about sending patches: Please, don't send patches in reply to the previous version. This messes up mailboxes. Send new versions separately. And it's better to have a dot at the end of a patch subject. Best regards, Ilya Maximets.
On Sat, May 16, 2020 at 1:14 AM Ilya Maximets <i.maximets@ovn.org> wrote: > > On 5/13/20 3:31 PM, xiangxia.m.yue@gmail.com wrote: > > From: Tonghao Zhang <xiangxia.m.yue@gmail.com> > > > > The patch set expand or shrink the meter table when necessary. > > and other patches fix bug or improve codes. > > > > Tonghao Zhang (4): > > dpif-netdev: Expand the meters supported number > > dpif-netdev: Add burst size to buckets > > dpif-netdev: Use the u64 instead of u32 for buckets > > Revert "dpif-netdev: includes microsecond delta in meter bucket > > calculation" > > > > include/openvswitch/ofp-meter.h | 2 +- > > lib/dpif-netdev.c | 336 ++++++++++++++++++++++++-------- > > lib/ofp-meter.c | 4 +- > > 3 files changed, 257 insertions(+), 85 deletions(-) > > > > Thanks for working on this! > > General note about sending patches: > Please, don't send patches in reply to the previous version. This messes up > mailboxes. Send new versions separately. > And it's better to have a dot at the end of a patch subject. Ok, I got it, thanks. > Best regards, Ilya Maximets.
From: Tonghao Zhang <xiangxia.m.yue@gmail.com> The patch set expand or shrink the meter table when necessary. and other patches fix bug or improve codes. Tonghao Zhang (4): dpif-netdev: Expand the meters supported number dpif-netdev: Add burst size to buckets dpif-netdev: Use the u64 instead of u32 for buckets Revert "dpif-netdev: includes microsecond delta in meter bucket calculation" include/openvswitch/ofp-meter.h | 2 +- lib/dpif-netdev.c | 336 ++++++++++++++++++++++++-------- lib/ofp-meter.c | 4 +- 3 files changed, 257 insertions(+), 85 deletions(-)