mbox series

[ovs-dev,ovn,v2,0/7] gateway documentation improvements

Message ID 20200318184548.3000357-1-blp@ovn.org
Headers show
Series gateway documentation improvements | expand

Message

Ben Pfaff March 18, 2020, 6:45 p.m. UTC 
v1->v2: Fix problems pointed out by Numan and Han.

Ben Pfaff (7):
  xml2nroff: Properly support <h4>.
  ovn-architecture: Flip network diagrams.
  ovn-nb: Better document distributed gateway ports.
  ovn-architecture: Correct documentation of localnet ports.
  ovn-architecture: Don't imply the wrong thing about NAT.
  ovn-architecture: Distributed gateway ports can interconnect OVNs.
  docs: Acknowledge in more places that localnet isn't the only option.

 build-aux/xml2nroff    |  10 +-
 ovn-architecture.7.xml | 201 ++++++++++++++++++++++++++++++-----------
 ovn-nb.xml             | 166 ++++++++++++++++------------------
 3 files changed, 237 insertions(+), 140 deletions(-)

Comments

Numan Siddique March 21, 2020, 2:06 p.m. UTC | #1 
On Thu, Mar 19, 2020 at 12:16 AM Ben Pfaff <blp@ovn.org> wrote:
>
> v1->v2: Fix problems pointed out by Numan and Han.
>
> Ben Pfaff (7):
>   xml2nroff: Properly support <h4>.
>   ovn-architecture: Flip network diagrams.
>   ovn-nb: Better document distributed gateway ports.
>   ovn-architecture: Correct documentation of localnet ports.
>   ovn-architecture: Don't imply the wrong thing about NAT.
>   ovn-architecture: Distributed gateway ports can interconnect OVNs.
>   docs: Acknowledge in more places that localnet isn't the only option.
>
>  build-aux/xml2nroff    |  10 +-
>  ovn-architecture.7.xml | 201 ++++++++++++++++++++++++++++++-----------
>  ovn-nb.xml             | 166 ++++++++++++++++------------------
>  3 files changed, 237 insertions(+), 140 deletions(-)
>

Thanks for these patches. After these patches, there should be no
confusion about
the distributed gateway ports and VLAN support in OVN as the documentation
makes it very clear.

Acked-by: Numan Siddique <numans@ovn.org>

Thanks

Numan

> --
> 2.24.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
Ben Pfaff March 23, 2020, 2:52 p.m. UTC | #2 
On Sat, Mar 21, 2020 at 07:36:24PM +0530, Numan Siddique wrote:
> On Thu, Mar 19, 2020 at 12:16 AM Ben Pfaff <blp@ovn.org> wrote:
> >
> > v1->v2: Fix problems pointed out by Numan and Han.
> >
> > Ben Pfaff (7):
> >   xml2nroff: Properly support <h4>.
> >   ovn-architecture: Flip network diagrams.
> >   ovn-nb: Better document distributed gateway ports.
> >   ovn-architecture: Correct documentation of localnet ports.
> >   ovn-architecture: Don't imply the wrong thing about NAT.
> >   ovn-architecture: Distributed gateway ports can interconnect OVNs.
> >   docs: Acknowledge in more places that localnet isn't the only option.
> >
> >  build-aux/xml2nroff    |  10 +-
> >  ovn-architecture.7.xml | 201 ++++++++++++++++++++++++++++++-----------
> >  ovn-nb.xml             | 166 ++++++++++++++++------------------
> >  3 files changed, 237 insertions(+), 140 deletions(-)
> >
> 
> Thanks for these patches. After these patches, there should be no
> confusion about
> the distributed gateway ports and VLAN support in OVN as the documentation
> makes it very clear.
> 
> Acked-by: Numan Siddique <numans@ovn.org>

Thanks.  Applied to master.

I think that I'm going to go back and add some text to make it clear
that chassis-redirect and redirect-type are meant for networks that are
already physical VLAN-only networks, because that wasn't clear to me
before the meeting on Thursday.