mbox series

[ovs-dev,2.10,v2,0/2] Fix ovn-nbctl daemon table printing issues.

Message ID 20190226142600.3542-1-mmichels@redhat.com
Headers show
Series Fix ovn-nbctl daemon table printing issues. | expand

Message

Mark Michelson Feb. 26, 2019, 2:25 p.m. UTC 
This is a backport for a fix present in 2.11. ovn-kubernetes encounters
issues with the daemon mode of ovn-nbctl with 2.10.

ovn-nbctl when run in daemon mode has two issues:
1) An extra newline is prepended to table output
2) Table formatting issues are ignored.

This patch series fixes both issues.

Mark Michelson (2):
  table: Create method for resetting table formatting.
  ovn-nbctl: Don't parse table-formatting options in nbctl_client

 lib/table.c               | 23 +++++++++++++++++------
 lib/table.h               |  1 +
 ovn/utilities/ovn-nbctl.c |  2 +-
 tests/ovn-nbctl.at        | 22 ++++++++++++++++++++++
 4 files changed, 41 insertions(+), 7 deletions(-)

Comments

Ben Pfaff April 16, 2019, 11 p.m. UTC | #1 
On Tue, Feb 26, 2019 at 09:25:58AM -0500, Mark Michelson wrote:
> This is a backport for a fix present in 2.11. ovn-kubernetes encounters
> issues with the daemon mode of ovn-nbctl with 2.10.
> 
> ovn-nbctl when run in daemon mode has two issues:
> 1) An extra newline is prepended to table output
> 2) Table formatting issues are ignored.
> 
> This patch series fixes both issues.

Thanks!  I applied this series to branch-2.10.