mbox series

[ovs-dev,v3,0/3] Transparent use of daemon for ovn-nbctl

Message ID 20180806214553.28185-1-blp@ovn.org
Headers show
Series Transparent use of daemon for ovn-nbctl | expand

Message

Ben Pfaff Aug. 6, 2018, 9:45 p.m. UTC
v1->v2:
  - Applied patches 1 and 2; added ack for patch 3 (thanks Alin!)
  - Polished up the daemon mode so that it works actually quite well
    and added tests that show that it behaves equivalently.
v2->v3:
  - Fix bug in patch 2 pointed out by Mark Michelson (thanks!) and add
    his acks.

Ben Pfaff (3):
  unixctl: Make path to unixctl_server socket available to the client.
  ovn-nbctl: Separate command-line options parsing and interpretation.
  ovn-nbctl: Make daemon mode more transparent.

 NEWS                          |   6 +-
 lib/command-line.c            | 108 +++++++++++++++
 lib/command-line.h            |  10 ++
 lib/daemon.h                  |  19 +++
 lib/stream-ssl.h              |   5 +-
 lib/unixctl.c                 |  52 ++++----
 lib/unixctl.h                 |   2 +
 ovn/utilities/ovn-nbctl.8.xml |  61 +++++++--
 ovn/utilities/ovn-nbctl.c     | 301 +++++++++++++++++++++++++++++++++++-------
 tests/daemon.at               |   4 +-
 tests/ovn-nbctl.at            | 246 ++++++++++++----------------------
 11 files changed, 567 insertions(+), 247 deletions(-)

Comments

Mark Michelson Aug. 7, 2018, 6:39 p.m. UTC | #1
Acked-by: Mark Michelson <mmichels@redhat.com>

On 08/06/2018 05:45 PM, Ben Pfaff wrote:
> v1->v2:
>    - Applied patches 1 and 2; added ack for patch 3 (thanks Alin!)
>    - Polished up the daemon mode so that it works actually quite well
>      and added tests that show that it behaves equivalently.
> v2->v3:
>    - Fix bug in patch 2 pointed out by Mark Michelson (thanks!) and add
>      his acks.
> 
> Ben Pfaff (3):
>    unixctl: Make path to unixctl_server socket available to the client.
>    ovn-nbctl: Separate command-line options parsing and interpretation.
>    ovn-nbctl: Make daemon mode more transparent.
> 
>   NEWS                          |   6 +-
>   lib/command-line.c            | 108 +++++++++++++++
>   lib/command-line.h            |  10 ++
>   lib/daemon.h                  |  19 +++
>   lib/stream-ssl.h              |   5 +-
>   lib/unixctl.c                 |  52 ++++----
>   lib/unixctl.h                 |   2 +
>   ovn/utilities/ovn-nbctl.8.xml |  61 +++++++--
>   ovn/utilities/ovn-nbctl.c     | 301 +++++++++++++++++++++++++++++++++++-------
>   tests/daemon.at               |   4 +-
>   tests/ovn-nbctl.at            | 246 ++++++++++++----------------------
>   11 files changed, 567 insertions(+), 247 deletions(-)
>
Ben Pfaff Aug. 7, 2018, 7:32 p.m. UTC | #2
Thanks, series applied to master and branch-2.10.

On Tue, Aug 07, 2018 at 02:39:21PM -0400, Mark Michelson wrote:
> Acked-by: Mark Michelson <mmichels@redhat.com>
> 
> On 08/06/2018 05:45 PM, Ben Pfaff wrote:
> >v1->v2:
> >   - Applied patches 1 and 2; added ack for patch 3 (thanks Alin!)
> >   - Polished up the daemon mode so that it works actually quite well
> >     and added tests that show that it behaves equivalently.
> >v2->v3:
> >   - Fix bug in patch 2 pointed out by Mark Michelson (thanks!) and add
> >     his acks.
> >
> >Ben Pfaff (3):
> >   unixctl: Make path to unixctl_server socket available to the client.
> >   ovn-nbctl: Separate command-line options parsing and interpretation.
> >   ovn-nbctl: Make daemon mode more transparent.
> >
> >  NEWS                          |   6 +-
> >  lib/command-line.c            | 108 +++++++++++++++
> >  lib/command-line.h            |  10 ++
> >  lib/daemon.h                  |  19 +++
> >  lib/stream-ssl.h              |   5 +-
> >  lib/unixctl.c                 |  52 ++++----
> >  lib/unixctl.h                 |   2 +
> >  ovn/utilities/ovn-nbctl.8.xml |  61 +++++++--
> >  ovn/utilities/ovn-nbctl.c     | 301 +++++++++++++++++++++++++++++++++++-------
> >  tests/daemon.at               |   4 +-
> >  tests/ovn-nbctl.at            | 246 ++++++++++++----------------------
> >  11 files changed, 567 insertions(+), 247 deletions(-)
> >
>