mbox series

[ovs-dev,0/2] dpdk: refactor the initialization step

Message ID 20180503190801.20925-1-aconole@redhat.com
Headers show
Series dpdk: refactor the initialization step | expand

Message

Aaron Conole May 3, 2018, 7:07 p.m. UTC
Sometimes, DPDK initialization can fail, but ovs-vswitchd will abort in
that case.  When that occurs, ovs-vswitchd will be restarted by the
monitor and immediately abort.  This is rather unfriendly to users, who
would prefer to possibly correct the issue or at least, not have lots of
processes continually spawning.

This series accepts that rte_eal_init() can and does fail for real.  It
reflects the initialization status in the database, as well as adding
the DPDK version (where appropriate).  In the case the user wants this
new behavior, they would set dpdk-init to 'try' rather than the current
setting of 'true'.

Aaron Conole (2):
  dpdk: allow init to fail
  dpdk: reflect status and version in the database

 Documentation/faq/configuration.rst  |  8 ++++---
 Documentation/intro/install/dpdk.rst | 27 ++++++++++++++++++++---
 lib/dpdk-stub.c                      | 10 +++++++++
 lib/dpdk.c                           | 42 +++++++++++++++++++++++++++++-------
 lib/dpdk.h                           |  3 ++-
 vswitchd/bridge.c                    |  5 +++++
 vswitchd/vswitch.ovsschema           | 11 +++++++---
 vswitchd/vswitch.xml                 | 11 ++++++++++
 8 files changed, 99 insertions(+), 18 deletions(-)

Comments

Aaron Conole May 17, 2018, 1:50 p.m. UTC | #1
Aaron Conole <aconole@redhat.com> writes:

> Sometimes, DPDK initialization can fail, but ovs-vswitchd will abort in
> that case.  When that occurs, ovs-vswitchd will be restarted by the
> monitor and immediately abort.  This is rather unfriendly to users, who
> would prefer to possibly correct the issue or at least, not have lots of
> processes continually spawning.
>
> This series accepts that rte_eal_init() can and does fail for real.  It
> reflects the initialization status in the database, as well as adding
> the DPDK version (where appropriate).  In the case the user wants this
> new behavior, they would set dpdk-init to 'try' rather than the current
> setting of 'true'.

Hi Ian,

Just wondering if you'll have time to give this a review during this
dpdk merge window.

Cheers,
-Aaron

> Aaron Conole (2):
>   dpdk: allow init to fail
>   dpdk: reflect status and version in the database
>
>  Documentation/faq/configuration.rst  |  8 ++++---
>  Documentation/intro/install/dpdk.rst | 27 ++++++++++++++++++++---
>  lib/dpdk-stub.c                      | 10 +++++++++
>  lib/dpdk.c                           | 42 +++++++++++++++++++++++++++++-------
>  lib/dpdk.h                           |  3 ++-
>  vswitchd/bridge.c                    |  5 +++++
>  vswitchd/vswitch.ovsschema           | 11 +++++++---
>  vswitchd/vswitch.xml                 | 11 ++++++++++
>  8 files changed, 99 insertions(+), 18 deletions(-)
Stokes, Ian May 17, 2018, 2:17 p.m. UTC | #2
> Aaron Conole <aconole@redhat.com> writes:
> 
> > Sometimes, DPDK initialization can fail, but ovs-vswitchd will abort
> > in that case.  When that occurs, ovs-vswitchd will be restarted by the
> > monitor and immediately abort.  This is rather unfriendly to users,
> > who would prefer to possibly correct the issue or at least, not have
> > lots of processes continually spawning.
> >
> > This series accepts that rte_eal_init() can and does fail for real.
> > It reflects the initialization status in the database, as well as
> > adding the DPDK version (where appropriate).  In the case the user
> > wants this new behavior, they would set dpdk-init to 'try' rather than
> > the current setting of 'true'.
> 
> Hi Ian,
> 
> Just wondering if you'll have time to give this a review during this dpdk
> merge window.
> 

Hi Aaron,

Sure, the HWOL patch will be the priority next week but I should be able take a look at this also for the merge.

Thanks
Ian

> Cheers,
> -Aaron
> 
> > Aaron Conole (2):
> >   dpdk: allow init to fail
> >   dpdk: reflect status and version in the database
> >
> >  Documentation/faq/configuration.rst  |  8 ++++---
> > Documentation/intro/install/dpdk.rst | 27 ++++++++++++++++++++---
> >  lib/dpdk-stub.c                      | 10 +++++++++
> >  lib/dpdk.c                           | 42
> +++++++++++++++++++++++++++++-------
> >  lib/dpdk.h                           |  3 ++-
> >  vswitchd/bridge.c                    |  5 +++++
> >  vswitchd/vswitch.ovsschema           | 11 +++++++---
> >  vswitchd/vswitch.xml                 | 11 ++++++++++
> >  8 files changed, 99 insertions(+), 18 deletions(-)