diff mbox series

[v4,4/7] platform: starfive: rename "stf,axp15060-regulator" -> "x-powers,axp15060"

Message ID e09ff63f70ea43b2e4d3a92815a5490e0c80d0ce.1707122766.git.namcao@linutronix.de
State Superseded
Headers show
Series starfive reboot cleanup & fix | expand

Commit Message

Nam Cao Feb. 5, 2024, 8:48 a.m. UTC
OpenSBI uses the device tree compatible string "stf,axp15060-regulator"
for the regulator node. However, the string used by U-Boot (and Linux)
is actually "x-powers,axp15060". As OpenSBI gets the device tree from
U-Boot, this causes the regulator device to be undetected, and OpenSBI
does not use this device to perform board reset/shutdown.

Rename this device tree compatible string to match U-Boot (and Linux).

Signed-off-by: Nam Cao <namcao@linutronix.de>
---
 platform/generic/starfive/jh7110.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Minda Chen Feb. 6, 2024, 9:35 a.m. UTC | #1
> 
> OpenSBI uses the device tree compatible string "stf,axp15060-regulator"
> for the regulator node. However, the string used by U-Boot (and Linux) is
> actually "x-powers,axp15060". As OpenSBI gets the device tree from U-Boot,
> this causes the regulator device to be undetected, and OpenSBI does not use
> this device to perform board reset/shutdown.
> 
> Rename this device tree compatible string to match U-Boot (and Linux).
> 
> Signed-off-by: Nam Cao <namcao@linutronix.de>
> ---
>  platform/generic/starfive/jh7110.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/platform/generic/starfive/jh7110.c
> b/platform/generic/starfive/jh7110.c
> index 1956fd8..1f7cfe2 100644
> --- a/platform/generic/starfive/jh7110.c
> +++ b/platform/generic/starfive/jh7110.c
> @@ -223,7 +223,7 @@ static int pm_reset_init(void *fdt, int nodeoff,  }
> 
>  static const struct fdt_match pm_reset_match[] = {
> -	{ .compatible = "stf,axp15060-regulator", .data = (void *)true },
> +	{ .compatible = "x-powers,axp15060", .data = (void *)true },
>  	{ },
>  };
> 
> --
> 2.39.2
The pmic compatible is the same with upstream uboot and linux
Acked-by: Minda Chen <minda.chen@starfivetech.com>
diff mbox series

Patch

diff --git a/platform/generic/starfive/jh7110.c b/platform/generic/starfive/jh7110.c
index 1956fd8..1f7cfe2 100644
--- a/platform/generic/starfive/jh7110.c
+++ b/platform/generic/starfive/jh7110.c
@@ -223,7 +223,7 @@  static int pm_reset_init(void *fdt, int nodeoff,
 }
 
 static const struct fdt_match pm_reset_match[] = {
-	{ .compatible = "stf,axp15060-regulator", .data = (void *)true },
+	{ .compatible = "x-powers,axp15060", .data = (void *)true },
 	{ },
 };