From patchwork Tue Apr 23 14:57:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiang W X-Patchwork-Id: 1926624 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=nJ7ajdOC; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=126.com header.i=@126.com header.a=rsa-sha256 header.s=s110527 header.b=FRS93ETB; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VP4xg2dVgz1yZt for ; Wed, 24 Apr 2024 00:58:31 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t7viJAN/bpHwMEz+krvvs8jpl8y2L5aLsYGC0F9fc0Q=; b=nJ7ajdOCmuHbfr j7Z1qodeITv1ZJcY49rcmREbPWnZiq31nZlTN2WJG2re74WMoYQu7H+fYVhb+g0kJWtgaiy6Kixy/ kjDfZuPBL/MCSv6XozgUNSnx1vtfyqGOovOviKc0LoT9PyYBrrEAlOjE/A7v1Ms/ZvQMnV5lZZL7i HvZemUvcswduj/51AYGnJhErUnuqy584sTqDkNEAoP8uF5c1ELHhBfqNd3h+1ZxRtcq+O59iT7TYj 9vHjF2ncG2X2AHp3Ca85L6fDyrbDp8k8heqF5mgHd6AOoqeL5fCAZclTa+jZ5PTf7GuJrM0f19zGu BUKwSKYvzKPLXyu3CfYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzHbE-00000000OCZ-3OHs; Tue, 23 Apr 2024 14:58:24 +0000 Received: from m16.mail.126.com ([117.135.210.7]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzHak-00000000O24-10kI for opensbi@lists.infradead.org; Tue, 23 Apr 2024 14:58:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=V+/FO QmMpHUvLbFFJoqskSh7SXpV1Jf4TGuAJ/NAupI=; b=FRS93ETBmjQa5cip3S4i4 eR8PHhZjY7mN272LX+Yd3q1KJ5tKLXdjo2spO4sL/Wep4cW57p5Rfj7YL+dvBx2c 4GLJ5CMETLpL9qe83jiGvHyMqyI7G6JGMNrO4aaijULUa9X5oyh+o9oMLtF4e6ke sD1zWmYh9UdL+Np48HqoSA= Received: from T490.lan (unknown [112.83.183.156]) by gzga-smtp-mta-g0-2 (Coremail) with SMTP id _____wDXT7lpzCdmN00xAg--.23722S4; Tue, 23 Apr 2024 22:57:46 +0800 (CST) From: Xiang W To: opensbi@lists.infradead.org Cc: Xiang W , hchauhan@ventanamicro.com, anup@brainfault.org Subject: [PATCH v2 2/5] lib: sbi: Remove unnecessary sbi_dbtr_shmem_disabled Date: Tue, 23 Apr 2024 22:57:38 +0800 Message-ID: <20240423145743.392718-3-wxjstz@126.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240423145743.392718-1-wxjstz@126.com> References: <20240423145743.392718-1-wxjstz@126.com> MIME-Version: 1.0 X-CM-TRANSID: _____wDXT7lpzCdmN00xAg--.23722S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7AFWkWFyDGF1fWFW3WF1xZrb_yoW8Ww1kpF 97GFW3Kr4xXryvyrWxJ3y8K3yYqw4xA348tr9I9rZYyas5Zw18Jw43J3WqqFyfArWkZa12 vF10kF4jkF4YvF7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zNXdbkUUUUU= X-Originating-IP: [112.83.183.156] X-CM-SenderInfo: pz0m23b26rjloofrz/xtbBdAzJOmSdL4hRaAABst X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_075800_298357_87D67092 X-CRM114-Status: UNSURE ( 7.59 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The code of hart_shmem_base is similar to sbi_dbtr_shmem_disabled. When hart_shmem_base is used, sbi_dbtr_shmem_disabled can be removed. Signed-off-by: Xiang W --- lib/sbi/sbi_dbtr.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [wxjstz(at)126.com] X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The code of hart_shmem_base is similar to sbi_dbtr_shmem_disabled. When hart_shmem_base is used, sbi_dbtr_shmem_disabled can be removed. Signed-off-by: Xiang W --- lib/sbi/sbi_dbtr.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/sbi/sbi_dbtr.c b/lib/sbi/sbi_dbtr.c index 5b07285..ceff185 100644 --- a/lib/sbi/sbi_dbtr.c +++ b/lib/sbi/sbi_dbtr.c @@ -537,10 +537,9 @@ int sbi_dbtr_read_trig(unsigned long smode, trig_idx_base + trig_count >= hs->total_trigs) return SBI_ERR_INVALID_PARAM; - if (sbi_dbtr_shmem_disabled()) - return SBI_ERR_NO_SHMEM; - shmem_base = hart_shmem_base(); + if (shmem_base == NULL) + return SBI_ERR_NO_SHMEM; for_each_trig_entry(shmem_base, trig_count, typeof(*entry), entry) { sbi_hart_map_saddr((unsigned long)entry, sizeof(*entry)); @@ -567,10 +566,10 @@ int sbi_dbtr_install_trig(unsigned long smode, struct sbi_dbtr_trigger *trig; struct sbi_dbtr_hart_triggers_state *hs = NULL; - if (sbi_dbtr_shmem_disabled()) + shmem_base = hart_shmem_base(); + if (shmem_base == NULL) return SBI_ERR_NO_SHMEM; - shmem_base = hart_shmem_base(); hs = dbtr_thishart_state_ptr(); /* Check requested triggers configuration */ @@ -679,10 +678,10 @@ int sbi_dbtr_update_trig(unsigned long smode, void *shmem_base = NULL; struct sbi_dbtr_hart_triggers_state *hs = NULL; - if (sbi_dbtr_shmem_disabled()) + shmem_base = hart_shmem_base(); + if (shmem_base == NULL) return SBI_ERR_NO_SHMEM; - shmem_base = hart_shmem_base(); hs = dbtr_thishart_state_ptr(); if (!hs) return SBI_ERR_FAILED;