From patchwork Tue Apr 9 10:02:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= X-Patchwork-Id: 1921321 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=aSQybwZx; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=Se7fzuzO; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDM2v6Mz3z1yZg for ; Tue, 9 Apr 2024 20:02:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8xmGJ5anIT8xaJstHuaFNppy6KmNeiBJKUY3BhVdAFE=; b=aSQybwZx7eHi/c x3ylyHk5SCFMT8YGt6R3wT/nwawPHLF2lIvwWY30pokgSyJ9xInLZywzgvs/UGLrKQXcFNLFbke1B zP54WXDlW+BAXbe7dXQijdbb9ear5OCxMsoD8DnXKUYvmG81akLcOqficeie/ptgnbhpJdN0tKb9h /ewOIZJ24/Ez6Jv5tGDdKxTQxo5jSzbzm6O1xUGNg/TJ4u2zh3rWsI9gVLyH5qw9wcOJ9UxiAsrBI nf5gtbKXyx0O+aEyDk0/SIuNqJhnYLFD1FbyINKm9NNVF5a3u5eTSRT4j2EqdJtj4TIirAzIG3Q0e 6eHsrraqPN02fZlN8Srw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JN-00000001KVr-1Gn8; Tue, 09 Apr 2024 10:02:41 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JH-00000001KOA-2V9U for opensbi@lists.infradead.org; Tue, 09 Apr 2024 10:02:37 +0000 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-346407b8c9aso47067f8f.0 for ; Tue, 09 Apr 2024 03:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1712656946; x=1713261746; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0T1Y+DolFjrh9XxBihhMneWckO0Q7RRmr3/vCxarlf8=; b=Se7fzuzO1KrDMUq6i2fcJ2fy1Qs+LqDXgdQSMK1wL8Iig6/cWSVGuM0kBTizUi3mE9 0v03ypRpQ0/1id6UdCeYGtM0/hLFdKSVnq3+VSKnWXKQWO+wxH+cQYa7Zv00E6tVWLXU 2CIPSeF6C6oZjQZWYDgb/nE5WtExr6sqMCdFTquoGzsTCbzyQ32mnmm73D/9afzZw8ba joGa9QjbA9ChoaRrQS+T97GzhdZ5B7AjcEA0hlSrnvkWv/hqLWBpcRlHNf3p3bDeMU6g X4dKctpsum1e3Smu/H+FRPMmVqWS1nGUw3GM7ubDbegQ1htlFDx+VdnpI9eMme7xow1r AG6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712656946; x=1713261746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0T1Y+DolFjrh9XxBihhMneWckO0Q7RRmr3/vCxarlf8=; b=ksF1PohExTRebtauZEnGde7DXQ6mph9FS8H3JoFQ1VjZqt64JOzwlEy3vrESXPry6C Aih93wlU6YEb76UQU1sN8IBNV7DCGiXZgkkOUYmYJqh6SEd1bzmmzASNGtdXRPWgdeDA G4KVLBJduDnVXHpSqkg6hpjNzECzekrOg+jJnsSUq3PjK2M2laWPGekXdt6IaZKFhJS+ I2EOBJBfLawcy38reQy9GjvWbbdG/ubBVBRh31ISV1IOVmxqp8hOvoE/d33/+KaOrEB0 2x7Pqu5ZDCfpW6VAKRmbxzDlZy0hhRaS8S3rSkEUBBYcfvJpnlv07zaO7lXoyzsyRAWb oOOQ== X-Gm-Message-State: AOJu0YxsJBCpUfNpcqgCs3B/EQtm8eivmRfytZDte0UJO6rIFIQBXM7Y EIcj85CvVzTAip1CnL95+U4OuWVn7j+HGMfM2YzUbFrs4dJ/h3iL0gpkT0Gz3XvDWY5rpwj0tAz 6quw= X-Google-Smtp-Source: AGHT+IFQVcvscTC1ctAPTU21bg8nae9P+tUAJr+OPpPScD+uLOs3qvdTmfUOKtntoA6bktg0nqAPBg== X-Received: by 2002:a05:600c:5103:b0:416:b4c9:db2e with SMTP id o3-20020a05600c510300b00416b4c9db2emr382397wms.3.1712656946155; Tue, 09 Apr 2024 03:02:26 -0700 (PDT) Received: from carbon-x1.. ([2a01:e0a:999:a3a0:322c:7eda:35fd:4614]) by smtp.gmail.com with ESMTPSA id a20-20020a05600c349400b00416b28651e1sm862972wmq.36.2024.04.09.03.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 03:02:24 -0700 (PDT) From: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= To: opensbi@lists.infradead.org Subject: [PATCH 4/7] lib: sbi: sse: remove superfluous sbi_list_empty() check Date: Tue, 9 Apr 2024 12:02:05 +0200 Message-ID: <20240409100216.263256-5-cleger@rivosinc.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240409100216.263256-1-cleger@rivosinc.com> References: <20240409100216.263256-1-cleger@rivosinc.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_030235_760753_4CE20EDF X-CRM114-Status: UNSURE ( 8.29 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__The_list_loop_below_that_check_is_actu?= =?unknown-8bit?q?ally_not_looping_if?= =?unknown-8bit?q?_the_list_is_empty_so_there_was_no_need_for_this_check=2E_S?= =?unknown-8bit?q?igned-off-by=3A_Cl=C3=A9ment?= =?unknown-8bit?q?_L=C3=A9ger_=3Ccleger=40rivosinc=2Ecom=3E_Reported-by=3A_Sa?= =?unknown-8bit?q?muel_Holland_=3Csamuel=2Eholland=40sifive=2Ecom=3E?= =?unknown-8bit?q?_---_lib/sbi/sbi=5Fsse=2Ec_=7C_3_---_1_file_changed=2C_3_de?= =?unknown-8bit?q?letions=28-=29_?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=280=2E0_points=2C_5=2E0_req?= =?unknown-8bit?q?uired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C_no?= =?unknown-8bit?q?_trust?= =?unknown-8bit?b?IFsyYTAwOjE0NTA6NDg2NDoyMDowOjA6MDo0MmUgbGlzdGVkIGluXQ==?= =?unknown-8bit?b?IFtsaXN0LmRuc3dsLm9yZ10=?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= , Atish Patra Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The list loop below that check is actually not looping if the list is empty so there was no need for this check. Signed-off-by: Clément Léger Reported-by: Samuel Holland Reviewed-by: Anup Patel --- lib/sbi/sbi_sse.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/sbi/sbi_sse.c b/lib/sbi/sbi_sse.c index cd8a539..61d1f78 100644 --- a/lib/sbi/sbi_sse.c +++ b/lib/sbi/sbi_sse.c @@ -578,9 +578,6 @@ void sbi_sse_process_pending_events(struct sbi_trap_regs *regs) spin_lock(&state->enabled_event_lock); - if (sbi_list_empty(&state->enabled_event_list)) - goto out; - sbi_list_for_each_entry(e, &state->enabled_event_list, node) { ret = sse_event_check_inject(e, regs); if (ret)