Message ID | 20240409100216.263256-4-cleger@rivosinc.com |
---|---|
State | New |
Headers | show
Return-Path: <opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=yFH/DRtu; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=b3VHDhYz; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDM2x021Xz1yYH for <incoming@patchwork.ozlabs.org>; Tue, 9 Apr 2024 20:02:49 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y2X1kCnZvn8L2D5wbcHRWGvT7AGjww7Lv9p2zdg6/VI=; b=yFH/DRtu7ymIkj ht4Sy6WPI06xCbXOpVLTYcAaLYs7MiucCQxwJM/FtWJHUtAhEIlxejFvMSmo3YiuPmbrMf31WQOZI RJ52Gt921dPOyzGDl1xjfdIPbD+b0Ps1L2UP/C2rtrn4NMEAik3zTd9pLMz8j2Fqu+OOblQxOPZB+ 5Tobserlai4O1145/ASzYinWzRrO5PU2ikkPZ0YECoHfpjEBrKsUQGyAOgGQk1EYk0YrdmBurlHMo 42ZOPOt/SoDAHQtHk1ox9U63VMWmcL/jqnmtWvu9Jka9R0JHTfrMga7FctFeLbSxliOwJuTZFACLg wFA6AgqtyoufX8T6TwKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JO-00000001KWw-2h2e; Tue, 09 Apr 2024 10:02:42 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JH-00000001KO5-2UZU for opensbi@lists.infradead.org; Tue, 09 Apr 2024 10:02:38 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-416463e82fbso4177085e9.1 for <opensbi@lists.infradead.org>; Tue, 09 Apr 2024 03:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1712656944; x=1713261744; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5je7/7GMUOOa8VJe5hjqnz/lVgoozefRpXFllbC0V4I=; b=b3VHDhYzjnOBs6+NfBVC3QwMOhy0AgEiTImJZQKuSwPrgf2kErMM8wkCpG+rghCmbk tm/x5tOiKg1a3To5sNgvGhpigq5/dqwuqasDLAFFk5koBhOs3YUE8SUGK8uxMZZk6ODX b0LPAHh4SK38J7rBGlKauZz2AHDEoLL9GF6dFHalGyZpW5pXq0BSJXxNhDKDqniwG5jE 42IY9V6wOZabXMNvY5eBHYzlXb++sPOGVizpD2enE9vNm9udwYyo5ezRiaSdFttR4uwL e64yFuJM6VQLQMC3/or/ONufZZlWL9fTGzY8oYCfQImwDFE84mU0KZMfHnoYBJouC6Xk c1Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712656944; x=1713261744; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5je7/7GMUOOa8VJe5hjqnz/lVgoozefRpXFllbC0V4I=; b=mN4T5g88ed+l9n7GEPqtyF2iodYw62+DS/N0w421oKHoQoXT3Os6DEglJAd5mo2R5d hHX0pvcU/78XQieYp8Bb1h8SEfTbJUCya9GOa0Z2WY1/NmXOXXGeWKHQvuCM8OvRwFUU jl2piJnzUrRXrDSRXsSCbVqVd0gxRg0LOvNQRnBrl9XzpKkqa4HZuuzG+Wcgkf+Q4Mv9 Df+U7wiEK86go1opXZJvdmbZ5Y7IE+S5LdayQkjzfOfI95DWMNTVl70pDpaQYCHk8PIc pMSzRR26ZrYL0h+lWEm6B8JMBQ449s63JigbxZ9sh8zYRPHLzDcZp0DjHpYhMVkWceR+ WbBg== X-Gm-Message-State: AOJu0Yw4fEimvCsiRXUZmvJ0jfllXsnyNSD4XLGaKjlkdbOcJwq4aVCL N2Kl2MLVrItJ190W4+hUmzXrmkgJVourdeiVWibqjlD7hujUMdcPcfRl0NxzN8y1wJLDqOoTvIr eVwM= X-Google-Smtp-Source: AGHT+IGmKISVjZ1O3vFOM7kzrKXNlDMSFRKe0EeOcfydQbEPjEEcL9szec2ra2NF97+lFIbiGm7TIA== X-Received: by 2002:a05:600c:34d3:b0:416:54f5:d315 with SMTP id d19-20020a05600c34d300b0041654f5d315mr5404808wmq.2.1712656944657; Tue, 09 Apr 2024 03:02:24 -0700 (PDT) Received: from carbon-x1.. ([2a01:e0a:999:a3a0:322c:7eda:35fd:4614]) by smtp.gmail.com with ESMTPSA id a20-20020a05600c349400b00416b28651e1sm862972wmq.36.2024.04.09.03.02.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 03:02:23 -0700 (PDT) From: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= <cleger@rivosinc.com> To: opensbi@lists.infradead.org Subject: [PATCH 3/7] lib: sbi: sse: simplify 32bits overflow check Date: Tue, 9 Apr 2024 12:02:04 +0200 Message-ID: <20240409100216.263256-4-cleger@rivosinc.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240409100216.263256-1-cleger@rivosinc.com> References: <20240409100216.263256-1-cleger@rivosinc.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_030235_793935_14B15E77 X-CRM114-Status: GOOD ( 10.97 ) X-Spam-Score: 0.0 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__Rather_than_checking_32bits_overflow_w?= =?unknown-8bit?q?ith_some_absolute_value=2C?= =?unknown-8bit?q?_check_the_value_to_be_different_from_the_cast_itself=2E_Si?= =?unknown-8bit?q?gned-off-by=3A_Cl=C3=A9ment?= =?unknown-8bit?q?_L=C3=A9ger_=3Ccleger=40rivosinc=2Ecom=3E_Reported-by=3A_Sa?= =?unknown-8bit?q?muel_Holland_=3Csamuel=2Eholland=40sifive=2Ecom=3E?= =?unknown-8bit?q?_---_lib/sbi/sbi=5Fsse=2Ec_=7C_2_+-_1_file_changed=2C_1_ins?= =?unknown-8bit?q?ertion=28+=29=2C_1_deletion=28-=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=280=2E0_points=2C_5=2E0_req?= =?unknown-8bit?q?uired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C_no?= =?unknown-8bit?q?_trust?= =?unknown-8bit?b?IFsyYTAwOjE0NTA6NDg2NDoyMDowOjA6MDozMzAgbGlzdGVkIGluXQ==?= =?unknown-8bit?b?IFtsaXN0LmRuc3dsLm9yZ10=?= X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <opensbi.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/opensbi>, <mailto:opensbi-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/opensbi/> List-Post: <mailto:opensbi@lists.infradead.org> List-Help: <mailto:opensbi-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/opensbi>, <mailto:opensbi-request@lists.infradead.org?subject=subscribe> Cc: Anup Patel <apatel@ventanamicro.com>, =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= <cleger@rivosinc.com>, Atish Patra <atishp@rivosinc.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "opensbi" <opensbi-bounces@lists.infradead.org> Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org |
Series |
lib: sbi: sse: fixes after review
|
expand
|
diff --git a/lib/sbi/sbi_sse.c b/lib/sbi/sbi_sse.c index d54c125..cd8a539 100644 --- a/lib/sbi/sbi_sse.c +++ b/lib/sbi/sbi_sse.c @@ -344,7 +344,7 @@ static int sse_event_set_attr_check(struct sbi_sse_event *e, uint32_t attr_id, break; case SBI_SSE_ATTR_PRIO: #if __riscv_xlen > 32 - if (val > 0xFFFFFFFFUL) { + if (val != (uint32_t)val) { ret = SBI_EINVAL; break; }
Rather than checking 32bits overflow with some absolute value, check the value to be different from the cast itself. Signed-off-by: Clément Léger <cleger@rivosinc.com> Reported-by: Samuel Holland <samuel.holland@sifive.com> --- lib/sbi/sbi_sse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)