From patchwork Tue Apr 9 10:02:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= X-Patchwork-Id: 1921319 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=pV/XYZ42; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=RvZbs7YW; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDM2s01v8z1yZg for ; Tue, 9 Apr 2024 20:02:44 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=08v8R8mN/0gSztaRlqOe0UzeRNOCTAlrp4OKUrIY1Z0=; b=pV/XYZ42KKkvzn Up2+dUoO0hWmN0pe9t1IXb+IOGm6IHcDp5MKXSWCmcvphRA64esvINHHXUrjsChf1WUdlBuJjWrLY JGq+7s/T54X69Swx6dS5S1kV1/rlgX9IoM9jCadkLIZ6w0Q96w9rr2lp6jZZySLm3UDzdQiPzigA3 mnE+3gBdVnndFRPRoOwoN50okVgO2JVxDg/+P3hUm0g247WCtrHxfO+0HSvr9bMYpm2q3EtyKtdvE 4UmALD4eA4HWERQJvQsBIWcdULKlqxWEhRQdpRpvA08ja9EZ5s6P6Il5LxR/rP3IZY3YSzVNVnppC G9z5Mdm7QvEi4kTPcyuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JI-00000001KSF-26FO; Tue, 09 Apr 2024 10:02:36 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru8JD-00000001KNt-2OIv for opensbi@lists.infradead.org; Tue, 09 Apr 2024 10:02:33 +0000 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-346407b8c9aso47043f8f.0 for ; Tue, 09 Apr 2024 03:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1712656942; x=1713261742; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gOjpKPxEXC124WEvQwFE9yDQ+bk/28aqm8SY3ugJyPA=; b=RvZbs7YWr6y2IW6ROFn/+tbP1dCCac/+GFV1wrhLEstnOeGNFGEnJsRZTRRuNWbCMa oNHqf0uN7SkAwojBT0U85mK9Ug+yCfYnyHn8NjC8D4bjA5zgGjvKJcNJVzyL1vy7gPEw NsPYMYt6cI3+gS2Yiv1WAdSMl0HvmFge4P/7MxXyJ3e71yvnfYJo8IP32JkO98o2A71P +qHNuukyI8mdGNdIj6mWZjH7alyN7fZegPyROQWvXdsXeC4dsNIJVRDqdPecqay70Q6Y ZHH9wET2ymHiGlqohrNa5GcAkGUeRKRS2xVHrK25UmBZCrHRSdcO8Jc1ZYgvQp/GHDPt 67VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712656942; x=1713261742; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gOjpKPxEXC124WEvQwFE9yDQ+bk/28aqm8SY3ugJyPA=; b=AL6JBlwWt8O4i765G75LvTDckQS5hKv1w6viQymSsZ0sL8MaJkgoTsl2/1iLBWNE2f /rEkyiEBJuH53DKzZ60PoJij+my/5iMTX7u6ge2NTZHzRONu+f6PxpIKzwBC964YFJ86 jAqAi2FBY+fPLFBNnXEGTXXxm7rToRGbLbO0s+IVvajM73gZR/BXAgPDvFZ/kpeiL4Yb BEbbIfdMn4PbJhI6zX9CtNN9cQvdxnjTK3rAci1y9INxC8s42m9Y5qVac6d3Hgq+xN5d EevJDvrDStGrHve5Xc8itd0fe41kW6nXYlP81/Kl7qH//jNeUY4nu+4Eb8eh2UOoL5vB HeuA== X-Gm-Message-State: AOJu0YyfLoPKyxB+OfYpqkHqG5Kuz2PkMN0O0WI2KNAj0VH50RpSyAGN 1UYw9RlxfU3cE0tzqsY7bc0YTLSS31Xxx2L/Tg56FC/GWsWJRxig/6hEY/E0VPNZRaGPIADW2k8 4tYg= X-Google-Smtp-Source: AGHT+IEs6DCTNT81y/k5JH/mTgY8mgW6cAUh6ZvQI2/DTBqHdqgyZgFRnbq1xFPltTv4i2nGyH8f8Q== X-Received: by 2002:a05:600c:4f11:b0:416:a71f:6217 with SMTP id l17-20020a05600c4f1100b00416a71f6217mr891993wmq.0.1712656941626; Tue, 09 Apr 2024 03:02:21 -0700 (PDT) Received: from carbon-x1.. ([2a01:e0a:999:a3a0:322c:7eda:35fd:4614]) by smtp.gmail.com with ESMTPSA id a20-20020a05600c349400b00416b28651e1sm862972wmq.36.2024.04.09.03.02.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 03:02:20 -0700 (PDT) From: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= To: opensbi@lists.infradead.org Subject: [PATCH 1/7] lib: sbi: sse: fix typos, comments and spacing errors Date: Tue, 9 Apr 2024 12:02:02 +0200 Message-ID: <20240409100216.263256-2-cleger@rivosinc.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240409100216.263256-1-cleger@rivosinc.com> References: <20240409100216.263256-1-cleger@rivosinc.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_030231_850241_93CCE9EC X-CRM114-Status: GOOD ( 16.89 ) X-Spam-Score: 0.0 (/) X-Spam-Report: =?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?= =?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?= =?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?= =?unknown-8bit?q?ginal?= =?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?= =?unknown-8bit?q?bel?= =?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?= =?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_preview=3A__Fix_some_errors_spotted_by_Samuel_whil?= =?unknown-8bit?q?e_reviewing_the_SSE?= =?unknown-8bit?q?_implementation=2E_Signed-off-by=3A_Cl=C3=A9ment_L=C3=A9ger?= =?unknown-8bit?q?_=3Ccleger=40rivosinc=2Ecom=3E_Reported-by=3A?= =?unknown-8bit?q?_Samuel_Holland_=3Csamuel=2Eholland=40sifive=2Ecom=3E_---_i?= =?unknown-8bit?q?nclude/sbi/sbi=5Fecall=5Finterface=2Eh?= =?unknown-8bit?b?IHwgMjQgKysrKysrKysrKysrIGxpYi9zYmkvc2JpX3NzZS5jIHwgMjIg?= =?unknown-8bit?b?Wy4uLl0g?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_Content_analysis_details=3A___=280=2E0_points=2C_5=2E0_req?= =?unknown-8bit?q?uired=29?= =?unknown-8bit?q?_?= =?unknown-8bit?q?_pts_rule_name______________description?= =?unknown-8bit?q?_----_----------------------_------------------------------?= =?unknown-8bit?q?--------------------?= =?unknown-8bit?q?_-0=2E0_RCVD=5FIN=5FDNSWL=5FNONE_____RBL=3A_Sender_listed_a?= =?unknown-8bit?q?t_https=3A//www=2Ednswl=2Eorg/=2C_no?= =?unknown-8bit?q?_trust?= =?unknown-8bit?b?IFsyYTAwOjE0NTA6NDg2NDoyMDowOjA6MDo0MmQgbGlzdGVkIGluXQ==?= =?unknown-8bit?b?IFtsaXN0LmRuc3dsLm9yZ10=?= =?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?= =?unknown-8bit?q?ish_an_SPF_Record?= =?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?= =?unknown-8bit?q?record?= =?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?= =?unknown-8bit?q?alid_DKIM_or_DK_signature?= =?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?= =?unknown-8bit?q?gnature=2C_not_necessarily_valid?= X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= , Atish Patra Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Fix some errors spotted by Samuel while reviewing the SSE implementation. Signed-off-by: Clément Léger Reported-by: Samuel Holland Reviewed-by: Anup Patel --- include/sbi/sbi_ecall_interface.h | 24 ++++++++++++------------ lib/sbi/sbi_sse.c | 22 +++++++++++----------- 2 files changed, 23 insertions(+), 23 deletions(-) diff --git a/include/sbi/sbi_ecall_interface.h b/include/sbi/sbi_ecall_interface.h index a511e0b..2600b66 100644 --- a/include/sbi/sbi_ecall_interface.h +++ b/include/sbi/sbi_ecall_interface.h @@ -344,36 +344,36 @@ enum sbi_sse_attr_id { #define SBI_SSE_ATTR_INTERRUPTED_FLAGS_HSTATUS_SPVP BIT(3) enum sbi_sse_state { - SBI_SSE_STATE_UNUSED = 0, - SBI_SSE_STATE_REGISTERED = 1, - SBI_SSE_STATE_ENABLED = 2, - SBI_SSE_STATE_RUNNING = 3, + SBI_SSE_STATE_UNUSED = 0, + SBI_SSE_STATE_REGISTERED = 1, + SBI_SSE_STATE_ENABLED = 2, + SBI_SSE_STATE_RUNNING = 3, }; /* SBI SSE Event IDs. */ #define SBI_SSE_EVENT_LOCAL_RAS 0x00000000 -#define SBI_SSE_EVENT_LOCAL_PLAT_0_START 0x00004000 +#define SBI_SSE_EVENT_LOCAL_PLAT_0_START 0x00004000 #define SBI_SSE_EVENT_LOCAL_PLAT_0_END 0x00007fff #define SBI_SSE_EVENT_GLOBAL_RAS 0x00008000 -#define SBI_SSE_EVENT_GLOBAL_PLAT_0_START 0x00004000 +#define SBI_SSE_EVENT_GLOBAL_PLAT_0_START 0x00004000 #define SBI_SSE_EVENT_GLOBAL_PLAT_0_END 0x00007fff #define SBI_SSE_EVENT_LOCAL_PMU 0x00010000 -#define SBI_SSE_EVENT_LOCAL_PLAT_1_START 0x00014000 +#define SBI_SSE_EVENT_LOCAL_PLAT_1_START 0x00014000 #define SBI_SSE_EVENT_LOCAL_PLAT_1_END 0x00017fff -#define SBI_SSE_EVENT_GLOBAL_PLAT_1_START 0x0001c000 +#define SBI_SSE_EVENT_GLOBAL_PLAT_1_START 0x0001c000 #define SBI_SSE_EVENT_GLOBAL_PLAT_1_END 0x0001ffff -#define SBI_SSE_EVENT_LOCAL_PLAT_2_START 0x00024000 +#define SBI_SSE_EVENT_LOCAL_PLAT_2_START 0x00024000 #define SBI_SSE_EVENT_LOCAL_PLAT_2_END 0x00027fff -#define SBI_SSE_EVENT_GLOBAL_PLAT_2_START 0x0002c000 +#define SBI_SSE_EVENT_GLOBAL_PLAT_2_START 0x0002c000 #define SBI_SSE_EVENT_GLOBAL_PLAT_2_END 0x0002ffff #define SBI_SSE_EVENT_LOCAL_SOFTWARE 0xffff0000 -#define SBI_SSE_EVENT_LOCAL_PLAT_3_START 0xffff4000 +#define SBI_SSE_EVENT_LOCAL_PLAT_3_START 0xffff4000 #define SBI_SSE_EVENT_LOCAL_PLAT_3_END 0xffff7fff #define SBI_SSE_EVENT_GLOBAL_SOFTWARE 0xffff8000 -#define SBI_SSE_EVENT_GLOBAL_PLAT_3_START 0xffffc000 +#define SBI_SSE_EVENT_GLOBAL_PLAT_3_START 0xffffc000 #define SBI_SSE_EVENT_GLOBAL_PLAT_3_END 0xffffffff #define SBI_SSE_EVENT_GLOBAL_BIT (1 << 15) diff --git a/lib/sbi/sbi_sse.c b/lib/sbi/sbi_sse.c index a686692..39b4588 100644 --- a/lib/sbi/sbi_sse.c +++ b/lib/sbi/sbi_sse.c @@ -128,7 +128,7 @@ struct sse_hart_state { * * When an event is in a state >= ENABLED, then it is inserted in the * this enabled_event_list and thus can only be removed from this - * list upon disable ecall or on complete with ONE_SHOT flag. + * list upon disable ecall or on complete with ONESHOT flag. */ struct sbi_dlist enabled_event_list; @@ -202,7 +202,7 @@ static struct sse_hart_state *sse_get_hart_state(struct sbi_sse_event *e) return sse_get_hart_state_ptr(s); } -static struct sse_global_event *sse_get_global_event(struct sbi_sse_event* e) +static struct sse_global_event *sse_get_global_event(struct sbi_sse_event *e) { return container_of(e, struct sse_global_event, event); } @@ -552,11 +552,11 @@ static bool sse_event_check_inject(struct sbi_sse_event *e, struct sbi_trap_regs *regs) { /* - * List of event is ordered by priority, stop at first running - * event since all other events after this one are of lower - * priority. This means an event of higher priority is already - * running. - */ + * List of event is ordered by priority, stop at first running + * event since all other events after this one are of lower + * priority. This means an event of higher priority is already + * running. + */ if (sse_event_state(e) == SBI_SSE_STATE_RUNNING) { return true; } @@ -882,10 +882,10 @@ int sbi_sse_read_attrs(uint32_t event_id, uint32_t base_attr_id, /* * Copy all attributes at once since struct sse_event_attrs is matching - * the SBI_SSE_ATTR_* attributes. While WRITE_ATTR attribute is not used - * in s-mode sse handling path, READ_ATTR is used to retrieve the value - * of registers when interrupted. Rather than doing multiple SBI calls, - * a single one is done allowing to retrieve them all at once. + * the SBI_SSE_ATTR_* attributes. READ_ATTR is used in SSE handling path + * to retrieve the value of registers when interrupted. Rather than + * doing multiple SBI calls a single one is done allowing to retrieve + * them all at once. */ e_attrs = (unsigned long *)&e->attrs; attrs = (unsigned long *)output_phys_lo;