diff mbox series

platform: andes/ae350: Avoid repeated inclusion of header files

Message ID 20221116072716.1763-1-zhangleizheng@eswincomputing.com
State Not Applicable
Headers show
Series platform: andes/ae350: Avoid repeated inclusion of header files | expand

Commit Message

zhangleizheng@eswincomputing.com Nov. 16, 2022, 7:27 a.m. UTC 
From: zhangleizheng <zhangleizheng@eswincomputing.com>

Avoid cache.h reuse when compiling.

Signed-off-by: zhangleizheng <zhangleizheng@eswincomputing.com>
---
 platform/andes/ae350/cache.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Bin Meng Nov. 16, 2022, 8:47 a.m. UTC | #1 
On Wed, Nov 16, 2022 at 3:29 PM <zhangleizheng@eswincomputing.com> wrote:
>
> From: zhangleizheng <zhangleizheng@eswincomputing.com>
>
> Avoid cache.h reuse when compiling.
>
> Signed-off-by: zhangleizheng <zhangleizheng@eswincomputing.com>

nits: use "First Name" "Last Name" as the git.user.name

> ---
>  platform/andes/ae350/cache.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/platform/andes/ae350/cache.h b/platform/andes/ae350/cache.h
> index e1c1826..8e00a1d 100644
> --- a/platform/andes/ae350/cache.h
> +++ b/platform/andes/ae350/cache.h
> @@ -7,6 +7,9 @@
>   *   Nylon Chen <nylon7@andestech.com>
>   */
>
> +#ifndef _AE350_CACHE_H_
> +#define _AE350_CACHE_H_
> +
>  uintptr_t mcall_set_mcache_ctl(unsigned long input);
>  uintptr_t mcall_set_mmisc_ctl(unsigned long input);
>  uintptr_t mcall_icache_op(unsigned int enable);
> @@ -15,3 +18,5 @@ uintptr_t mcall_l1_cache_i_prefetch_op(unsigned long enable);
>  uintptr_t mcall_l1_cache_d_prefetch_op(unsigned long enable);
>  uintptr_t mcall_non_blocking_load_store(unsigned long enable);
>  uintptr_t mcall_write_around(unsigned long enable);
> +
> +#endif /* _AE350_CACHE_H_ */
> --

Otherwise,
Reviewed-by: Bin Meng <bmeng@tinylab.org>
Yu Chien Peter Lin Nov. 28, 2022, 8:20 a.m. UTC | #2 
On Wed, Nov 16, 2022 at 03:27:16PM +0800, zhangleizheng@eswincomputing.com wrote:
> From: zhangleizheng <zhangleizheng@eswincomputing.com>
> 
> Avoid cache.h reuse when compiling.
> 
> Signed-off-by: zhangleizheng <zhangleizheng@eswincomputing.com>

Looks good to me,
Thanks.

Reviewed-by: Yu Chien Peter Lin <peterlin@andestech.com>

> ---
>  platform/andes/ae350/cache.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/platform/andes/ae350/cache.h b/platform/andes/ae350/cache.h
> index e1c1826..8e00a1d 100644
> --- a/platform/andes/ae350/cache.h
> +++ b/platform/andes/ae350/cache.h
> @@ -7,6 +7,9 @@
>   *   Nylon Chen <nylon7@andestech.com>
>   */
>  
> +#ifndef _AE350_CACHE_H_
> +#define _AE350_CACHE_H_
> +
>  uintptr_t mcall_set_mcache_ctl(unsigned long input);
>  uintptr_t mcall_set_mmisc_ctl(unsigned long input);
>  uintptr_t mcall_icache_op(unsigned int enable);
> @@ -15,3 +18,5 @@ uintptr_t mcall_l1_cache_i_prefetch_op(unsigned long enable);
>  uintptr_t mcall_l1_cache_d_prefetch_op(unsigned long enable);
>  uintptr_t mcall_non_blocking_load_store(unsigned long enable);
>  uintptr_t mcall_write_around(unsigned long enable);
> +
> +#endif /* _AE350_CACHE_H_ */
> -- 
> 2.17.1
>
Yu Chien Peter Lin Nov. 28, 2022, 4:37 p.m. UTC | #3 
On Mon, Nov 28, 2022 at 08:20:24AM +0000, Yu-Chien Peter Lin wrote:
> On Wed, Nov 16, 2022 at 03:27:16PM +0800, zhangleizheng@eswincomputing.com wrote:
> > From: zhangleizheng <zhangleizheng@eswincomputing.com>
> > 
> > Avoid cache.h reuse when compiling.
> > 
> > Signed-off-by: zhangleizheng <zhangleizheng@eswincomputing.com>
> 
> Looks good to me,
> Thanks.
> 
> Reviewed-by: Yu Chien Peter Lin <peterlin@andestech.com>

Hi all,

I just removed andes/ae350 folder so let's skip this patch.
Thanks for your fix. 

Best regards,
Peter Lin

> 
> > ---
> >  platform/andes/ae350/cache.h | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/platform/andes/ae350/cache.h b/platform/andes/ae350/cache.h
> > index e1c1826..8e00a1d 100644
> > --- a/platform/andes/ae350/cache.h
> > +++ b/platform/andes/ae350/cache.h
> > @@ -7,6 +7,9 @@
> >   *   Nylon Chen <nylon7@andestech.com>
> >   */
> >  
> > +#ifndef _AE350_CACHE_H_
> > +#define _AE350_CACHE_H_
> > +
> >  uintptr_t mcall_set_mcache_ctl(unsigned long input);
> >  uintptr_t mcall_set_mmisc_ctl(unsigned long input);
> >  uintptr_t mcall_icache_op(unsigned int enable);
> > @@ -15,3 +18,5 @@ uintptr_t mcall_l1_cache_i_prefetch_op(unsigned long enable);
> >  uintptr_t mcall_l1_cache_d_prefetch_op(unsigned long enable);
> >  uintptr_t mcall_non_blocking_load_store(unsigned long enable);
> >  uintptr_t mcall_write_around(unsigned long enable);
> > +
> > +#endif /* _AE350_CACHE_H_ */
> > -- 
> > 2.17.1
> >
diff mbox series

Patch

diff --git a/platform/andes/ae350/cache.h b/platform/andes/ae350/cache.h
index e1c1826..8e00a1d 100644
--- a/platform/andes/ae350/cache.h
+++ b/platform/andes/ae350/cache.h
@@ -7,6 +7,9 @@ 
  *   Nylon Chen <nylon7@andestech.com>
  */
 
+#ifndef _AE350_CACHE_H_
+#define _AE350_CACHE_H_
+
 uintptr_t mcall_set_mcache_ctl(unsigned long input);
 uintptr_t mcall_set_mmisc_ctl(unsigned long input);
 uintptr_t mcall_icache_op(unsigned int enable);
@@ -15,3 +18,5 @@  uintptr_t mcall_l1_cache_i_prefetch_op(unsigned long enable);
 uintptr_t mcall_l1_cache_d_prefetch_op(unsigned long enable);
 uintptr_t mcall_non_blocking_load_store(unsigned long enable);
 uintptr_t mcall_write_around(unsigned long enable);
+
+#endif /* _AE350_CACHE_H_ */