From patchwork Sun Feb 21 08:53:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1442756 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2001:8b0:10b:1231::1; helo=merlin.infradead.org; envelope-from=opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=merlin.20170209 header.b=Fvc4GLX+; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=CLeiXOiB; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=H2KlXnMr; dkim-atps=neutral Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DjzdC5dXVz9sVS for ; Sun, 21 Feb 2021 19:54:05 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GhP8qoEHHEcOFSTCtzB0HCoj0iPhlMIBvDwTYtEMVR4=; b=Fvc4GLX+fwk4jbUI/dyXep0KM Mq32tjZJwfErL37V4ttiqAXmYsFf9JR2Cqi1iKkey3Szl8HnaUTP4a46Ti9u5alYJ3KK6dXCtE8Jb 2U+/If1h84GBXnaHDI3RB8tHLkTMRYogj+Xts2n2PuPYHbvRV2wB+kBrxyG6qFqjJ4A4Dylko3ac5 5EeYxn/WYzJzdB+TBuaq8gE9Oj3ZUbaxzdDUSGw5/IubsPlJFnJvqLB2gRV/m5gRSpbntvvZKRc07 dVdFvFCtmghUn5crEr+lC7fq25yBuMc6Z/69vr071xVAzGNl6HpII5uojC3vnqWnA3vDLDTstAW9j 4tZ+q0x2w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDkV3-0003Wy-5L; Sun, 21 Feb 2021 08:53:57 +0000 Received: from esa5.hgst.iphmx.com ([216.71.153.144]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDkV0-0003Vk-3F for opensbi@lists.infradead.org; Sun, 21 Feb 2021 08:53:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1613897634; x=1645433634; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=cKNlf2G+Jm8Y5IaeCSvCUZQGMD6HoVh22e2WsVInO+0=; b=CLeiXOiB0b8glTQSWneRwnTg6WXuqawGRytJ/Wc1N2BvRd4/T86iuLNN kJ7V2wNj5YA2x/5ho8J3dZphqgAT3f6LO0F8c3UfiUs+HJGIzY7JoOltZ tOUwNVGKUGtRky4hCg5o6qknQOY1KfUqCbr5O20AC5BIMso+RnYxAkEO3 anjsak1qbisk2MXZ1OsgFCmUIQr1962oyLIg4NS+2Ns0zkLsrGCpeOvd9 DhZB0WEbZQUCVcKhMjARQas+5ZNhR6C4NYH92x+zHTCqAqN7m946nK5b3 z6uIfOfqY/hEV/3SX8Hsja1GfLSZmW4avAuTvD/OGqkpiTwwQ2mRccut3 A==; IronPort-SDR: HguIlEwFz4wayIpoeGCIXgj0fCPHMUZXb/ZeUrHZT3YgztdotTB8iXqLWnHxO7nUxPuTkn9yOp Y2HUc2UY+U3Q8ewdMtCnBMt6HrKjlVOZWcfeW4qDM+1ChkXEdUrfXPcV2QVpUKUIpRx6ulX9G9 NgRp0Li7a0MaJZcDru4YHY+WyfSOCfzZw1a/uzt46WDhKFuwfa6bWtXPKD/dEboA06G4MX6H+X PqzscUtgekCMdsMSEIf+BKpI/BhEvoGqPloMGorRDBd74u5psDCkNEvQ29KPZR/PZ1KxCuiuDx 0Ho= X-IronPort-AV: E=Sophos;i="5.81,194,1610380800"; d="scan'208";a="160446557" Received: from mail-bn7nam10lp2100.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.100]) by ob1.hgst.iphmx.com with ESMTP; 21 Feb 2021 16:53:53 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h4pidNIDcghNTBNGl9qHq5f0yUP22SkLL54scznX+rUgFb+zEnVFv1VvQre2TEtJhSAOWZATvu1iokF36BO1PeMnueJQjHptXRoZfb5il8JDaeMJSKXjS6aKQORFnv+MsRyyvE6q5kTOAJGxYf9q4TKyj1GpqVakcqF82CtBke9vuZPNPhIgvYlFuAhriF6iTpiNGactxUx0bK2VXP7+Ry3NrEWEnA/vq4/uPocgJLNaI1FaaMw+kfHpuD4at6PSLVN3HIZqH1Qw36M9jUndUpqb6KL4jkfcQbem+G0Lln2UgTGUU2p4muB6qnfQuEO6vjtG9ld5RlK8JzTrxclRtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J3aW4hAGBmmvbAn94WEZXEvZ6zAiqNSAXaUq88RaEiM=; b=f5svQoAyDNco2c8GUlqtrDLyOGuIP8f9SOEdZpflSiQ12ZeuSNWntW8f7LDeyt8x1uvgErfgU+zdlUu5v1qe72AaVH2OzUKuC0UCntEuYahoNy04srLY9GxkBsovHIdyyry64qrzZ9lJNm+wQnRk25ekJ/AsPahpTv1RzF24bpYGvKcfHwPiojpm0kvWhjp+KN/yjKkE1MfD6yFTNkKLUzdzO5Xj+v8uVAVpesxZhLC+dMwqKWU/KRwnkL9pFu/WienoXq6kaC/JfnyMkydHuyH8Fu1HVdM8pZr9yf1gZTqXc+MWJSP9DdxGttUgNKRhxI/O3OX83/qBKRPG/g0LEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J3aW4hAGBmmvbAn94WEZXEvZ6zAiqNSAXaUq88RaEiM=; b=H2KlXnMrJ+s+D+ypg85/tPaFV/Hg6Ru7vlNkvZmcCI1ja0LuNLDp6Vcy83HA0rlV1C3KVzXXJojC5gUn2H6Ft5w5TRmRmUB+W9gycTSFj2gezzNLjWbTN2Yny20o+IE9IBIkCzqr1igcShQlSbNG159peRqZslrpPltW25+7Hzw= Authentication-Results: wdc.com; dkim=none (message not signed) header.d=none;wdc.com; dmarc=none action=none header.from=wdc.com; Received: from DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) by DM6PR04MB4123.namprd04.prod.outlook.com (2603:10b6:5:98::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.30; Sun, 21 Feb 2021 08:53:52 +0000 Received: from DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868]) by DM6PR04MB6201.namprd04.prod.outlook.com ([fe80::38c0:cc46:192b:1868%7]) with mapi id 15.20.3868.029; Sun, 21 Feb 2021 08:53:52 +0000 From: Anup Patel To: Atish Patra , Alistair Francis Subject: [RFC PATCH 04/10] lib: sbi: Remove redundant sbi_hsm_hart_started() function Date: Sun, 21 Feb 2021 14:23:15 +0530 Message-Id: <20210221085321.180602-5-anup.patel@wdc.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210221085321.180602-1-anup.patel@wdc.com> References: <20210221085321.180602-1-anup.patel@wdc.com> X-Originating-IP: [122.171.171.12] X-ClientProxiedBy: MA1PR01CA0104.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:1::20) To DM6PR04MB6201.namprd04.prod.outlook.com (2603:10b6:5:127::32) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from wdc.com (122.171.171.12) by MA1PR01CA0104.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.27 via Frontend Transport; Sun, 21 Feb 2021 08:53:50 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 49956108-ed74-47c4-067e-08d8d646363a X-MS-TrafficTypeDiagnostic: DM6PR04MB4123: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: WDCIPOUTBOUND: EOP-TRUE X-MS-Oob-TLC-OOBClassifiers: OLM:1388; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b/1smkWR4sYlOIT3fwP32Vmf2eMB43Z+FBUaemweW447IYwrYsNUiCWONTaqX7/m9xnsVze9kaKRa+ZKYfd7QA2/oM/WOxP4yTSEqfhC5caX5AK+YS93+ccjBVGKjMutkPs9i0HqVef94tC9XeiRKKAx+CLSpWGAN29KvewzMS/o38FPFGmXtYPUf/O/RxNY9pvc4zEhs1bpMkifRMgC5fPtpwVGNLqeC8Gi+Jk6BlqHPgPRLHJpk9q7Lr7u8DL0Ozos0tqSf8itbx/Ch3P0yvZhMtuWiKtwJm7nIJZpFGEGWs/1ALDCYW9Y2c5GltCX6lgWCJmE0ttPC+MIzZpHOkgymqjESCef9egchi6y7bvmm1DmNnVNHLS2AcUxPZGpR6XcTZqxi/6OuBVQmVypRfxFAFI7QH7T1WUfZQ671hp0+mpjRDbQqs0lj8I5gvhiZvFtHWv64PuL2OiGm/SA4AqChS04xjLufPkgVvG4O0a5TMffKLox3ExB4bE6Usk3HdjnpeG9sz7wcU01V5krzA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR04MB6201.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(366004)(396003)(136003)(346002)(7696005)(2616005)(5660300002)(4326008)(16526019)(186003)(478600001)(36756003)(8936002)(52116002)(2906002)(26005)(54906003)(110136005)(86362001)(55016002)(66556008)(8886007)(44832011)(66946007)(6666004)(6636002)(956004)(1076003)(66476007)(8676002)(83380400001)(316002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: upSJzUXsVWrrqsbavV7LbOBDcv2ScrtkcNxIciBqBmmR+RQj6C686iOgzINMUpMWkhfhrmZJcN6iF6y+VrWW/3CbrSOh0DK71RM/QZhyj0TYcNb1zrIV35AJ7b5JSOKwKIx5KZfIeVOUSMZUkUHIZNgGvBwL5b9wygyBWGc0RbMA6AnQG8OQH4fegQIFgGajVB9dV/wVxdHUDAQWLgZ7ZTKHa+/jrOTrafQ4puLGUzx7YNt2rMXMJ3aAydaJCWY9aSc0A4e50ho/C5eGkLB4fEdZo5Qhe4H0QCPJR9k630v5Q+9s831DxjIz9fTrC3J57wdxhwByQMkYV/be3gUNU4q7RZB4YHI0B8pflfdYc4AK5tTIcVYMX68GCEG6PVPsaqmjO2T+l3l3yQ3THofRpW0IDxrjDXvT1FmxrFAVc7iYIkdJoWFqg27DB1sgE4WXJDSJfVvQGcDz/qoWdJhMHGzsAQvjaLG+8oFWTqWsURoXsgDra2QUBU5pyqCCx4icbyt+5WEj6hVJmnGJ3hdpkXPWrplKIZBYRiWwutDfejjHPAyxqDyg6U7dipvEQJnAJlgQgmsSotZfm3RQ/SB3ssjgLHgyBV1HTtrAbBN3zNO7+7bl/3ou/2pScdoyBvHy/ySGU/8YNVDtHfQVWNd0uimQQjGroa1kqMPdIBa+wb5kBIF7QIKESJtu6bOcRqEBdfRdepdtgKcM24j8uGwEUz0EtvboERR2eUzm2xhb8+Ek9Bff7Mhb2DlRNx6w3shbDHJqMTSmWMDxSGiwOhLrST1GO/Zqq5kOtkEPNcdgTE+cL5jEpr/K9ITGHeFbg/uZxMi94XsW1OsZhLKG5OTXmnV2GIxcB/79mt0i2RSA/B4F63365ocI2FVGtaE8KrDPLqrdX5D99M/WOFpvvRw/ooPzf0y2DQ/w4Txbc7i5tC20rJR968mQI7YiHJLYIu3Jw9Bu8anur/uiQDJyLJjNftTya4H0V4o4+VgWyRPwfIRtu8Gzr1BV5r2vBulDy8F/evat9LNvCYqJNd/zsYem4pTUo0vlT4ijsGX5+uru0QnPS5oBEFJrdSm2svZvO0MMvDosKFAOhYY/x30T2uF7BoQYhfOrPGE/yhLpphg8IiTCddQw+wC3wnRZlsmtOlxfuCA39oM5VDPT0eS7dVTtBrC9/kzuP4If1NxBsSEZpwmDEO/5LW7jQroYBPr4DYM08BJZkkLgV9CwE6maa55oxIOTdD0OQIH4qfbjkLRdFtmJ+xo2ogOd+ykNCVXa2pMvDQK2Qidf4/AykPlYxxyGkcQho0MI+z1IRNXkCtnh2s/KbQYuRg8Scz5K+C2bJ70w X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49956108-ed74-47c4-067e-08d8d646363a X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6201.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2021 08:53:52.1390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IUef3qX7qL962lYunsBMLjvSz9IIbGiQiTbXGVZTMD18vGkyeIT6rujsbAvrLRkdR/SF/lDyQiV8rvf2MIrqXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB4123 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210221_035354_370942_F5BDBB5E X-CRM114-Status: GOOD ( 14.40 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [216.71.153.144 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 MSGID_FROM_MTA_HEADER Message-Id was added by a relay X-BeenThere: opensbi@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , Anup Patel , opensbi@lists.infradead.org Sender: "opensbi" Errors-To: opensbi-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org The sbi_hsm_hart_started() function is only used by sbi_hsm_hart_stop() for checking state of calling HART and current domain assignment. The atomic_cmpxchg() called by sbi_hsm_hart_stop() will check state of calling hart anyway and domain assignment can be checked by other domain function such as sbi_domain_is_assigned_hart(). This means sbi_hsm_hart_started() is redundant and can be removed. Signed-off-by: Anup Patel --- lib/sbi/sbi_hsm.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c index a81b821..732c400 100644 --- a/lib/sbi/sbi_hsm.c +++ b/lib/sbi/sbi_hsm.c @@ -54,14 +54,6 @@ int sbi_hsm_hart_get_state(const struct sbi_domain *dom, u32 hartid) return __sbi_hsm_hart_get_state(hartid); } -static bool sbi_hsm_hart_started(const struct sbi_domain *dom, u32 hartid) -{ - if (sbi_hsm_hart_get_state(dom, hartid) == SBI_HSM_STATE_STARTED) - return TRUE; - else - return FALSE; -} - /** * Get ulong HART mask for given HART base ID * @param dom the domain to be used for output HART mask @@ -248,10 +240,11 @@ int sbi_hsm_hart_stop(struct sbi_scratch *scratch, bool exitnow) { int oldstate; u32 hartid = current_hartid(); + const struct sbi_domain *dom = sbi_domain_thishart_ptr(); struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch, hart_data_offset); - if (!sbi_hsm_hart_started(sbi_domain_thishart_ptr(), hartid)) + if (dom && !sbi_domain_is_assigned_hart(dom, hartid)) return SBI_EINVAL; oldstate = atomic_cmpxchg(&hdata->state, SBI_HSM_STATE_STARTED,