mbox series

[0/3] CArray improvements

Message ID 20240401213438.590209-1-ivan.orlov0322@gmail.com
Headers show
Series CArray improvements | expand

Message

Ivan Orlov April 1, 2024, 9:34 p.m. UTC 
Currently, there are a few inconveniences the developer may face when
using CArrays, including:

- Unability to regenerate the carray-related .c files reliably without
removing the `build/` directory
- Confusion caused by source (.c) files in the `build/` directory (the
fact that some file was generated by carray.sh is not obvious)

This patch series fixes them.

Ivan Orlov (3):
  Makefile: clean auto-generated *.c files properly
  scripts/carray.sh: Add comment to generated files
  docs: writing tests: update cleaning instructions

 Makefile              | 2 ++
 docs/writing_tests.md | 4 +---
 scripts/carray.sh     | 1 +
 3 files changed, 4 insertions(+), 3 deletions(-)

Comments

Anup Patel May 7, 2024, 6:06 a.m. UTC | #1 
Hi Ivan,

On Tue, Apr 2, 2024 at 3:04 AM Ivan Orlov <ivan.orlov0322@gmail.com> wrote:
>
> Currently, there are a few inconveniences the developer may face when
> using CArrays, including:
>
> - Unability to regenerate the carray-related .c files reliably without
> removing the `build/` directory
> - Confusion caused by source (.c) files in the `build/` directory (the
> fact that some file was generated by carray.sh is not obvious)
>
> This patch series fixes them.
>
> Ivan Orlov (3):
>   Makefile: clean auto-generated *.c files properly
>   scripts/carray.sh: Add comment to generated files
>   docs: writing tests: update cleaning instructions

I assume you (or someone else) will be sending v2 of this series ?

Regards,
Anup

>
>  Makefile              | 2 ++
>  docs/writing_tests.md | 4 +---
>  scripts/carray.sh     | 1 +
>  3 files changed, 4 insertions(+), 3 deletions(-)
>
> --
> 2.34.1
>
Ivan Orlov May 10, 2024, 3:56 p.m. UTC | #2 
On 5/7/24 07:06, Anup Patel wrote:
> Hi Ivan,
> 
> On Tue, Apr 2, 2024 at 3:04 AM Ivan Orlov <ivan.orlov0322@gmail.com> wrote:
>>
>> Currently, there are a few inconveniences the developer may face when
>> using CArrays, including:
>>
>> - Unability to regenerate the carray-related .c files reliably without
>> removing the `build/` directory
>> - Confusion caused by source (.c) files in the `build/` directory (the
>> fact that some file was generated by carray.sh is not obvious)
>>
>> This patch series fixes them.
>>
>> Ivan Orlov (3):
>>    Makefile: clean auto-generated *.c files properly
>>    scripts/carray.sh: Add comment to generated files
>>    docs: writing tests: update cleaning instructions
> 
> I assume you (or someone else) will be sending v2 of this series ?
> 

Hi Anup,

Sorry for the late reply. I believe Ben Dooks 
<ben.dooks@codethink.co.uk> is going to send the V2 with the updated 
carray cleanup :)

Thank you!