From patchwork Tue Mar 11 16:16:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Chemeris X-Patchwork-Id: 329157 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 2A21E2C00AB for ; Wed, 12 Mar 2014 03:18:00 +1100 (EST) Received: from localhost ([127.0.0.1] helo=ganesha.gnumonks.org) by ganesha.gnumonks.org with esmtp (Exim 4.72) (envelope-from ) id 1WNPNB-0004At-70; Tue, 11 Mar 2014 17:17:46 +0100 Received: from mail-pd0-x22a.google.com ([2607:f8b0:400e:c02::22a]) by ganesha.gnumonks.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.72) (envelope-from ) id 1WNPMh-0004Ae-UL for openbsc@lists.osmocom.org; Tue, 11 Mar 2014 17:17:18 +0100 Received: by mail-pd0-f170.google.com with SMTP id v10so8811937pde.1 for ; Tue, 11 Mar 2014 09:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=cQyPqSeVFz3HkFniWhTZRciKSL2XHcI1mTeNu5neMWo=; b=vqX5Z66o+6aaTDT3qTynsqXOqZ0uz0kws+5fKc5BFnPoHNDu1gogBK8BwMV+Yatj+z tenOIHWSNc/FFlhR72YO3XQ6t1LdnTWM22qaWlZK/kyP1vb3uWGBM56ggo9ZJ5cev7IP IdIoh5WvQUWJcLiUcK/Hzcqd1n5t69z0b0SYLj/0yScf9B5EwAMo5Jtx77vWb3Sbsk5N 7JB/Qt2IpuNYn8nbacnAns3ngWR44a1C/jW6PCaaL4o2WlZJNy/0+MCW0v34oKegHaxI A+fGpG/9BkMdVO+aOPJs5vqnHKelc6ONGguyhOguBC0BBXdP7aDEQ8CpNFjcda6Tn8fc IQYA== X-Received: by 10.66.142.107 with SMTP id rv11mr48836113pab.17.1394554630014; Tue, 11 Mar 2014 09:17:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.70.88.239 with HTTP; Tue, 11 Mar 2014 09:16:49 -0700 (PDT) In-Reply-To: <20140311142626.GH17965@xiaoyu.lan> References: <20140309182323.GA17965@xiaoyu.lan> <20140311142626.GH17965@xiaoyu.lan> From: Alexander Chemeris Date: Tue, 11 Mar 2014 20:16:49 +0400 Message-ID: Subject: Re: [PATCH] sms: Rename gsm340_gen_oa() to gsm340_gen_address_field(). To: Holger Hans Peter Freyther X-Spam-Score: -0.1 (/) Cc: OpenBSC Mailing List X-BeenThere: openbsc@lists.osmocom.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development of the OpenBSC GSM base station controller List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openbsc-bounces@lists.osmocom.org Errors-To: openbsc-bounces@lists.osmocom.org On Tue, Mar 11, 2014 at 6:26 PM, Holger Hans Peter Freyther wrote: > On Mon, Mar 10, 2014 at 07:40:51PM +0100, Alexander Chemeris wrote: >> Good idea. An updated patch is attached. > >> +/* DEPRECATED: use gsm340_gen_address_field() instead */ >> +int gsm340_gen_oa(uint8_t *oa, unsigned int oa_len, uint8_t type, >> + uint8_t plan, const char *number) OSMO_DEPRECATED("Use gsm340_gen_address_field() instead"); > > this comment doesn't really add any value. I don't see how it harms either. Though I've removed it in the attached patch. > You are using OSMO_DEPRECTAED > but you do not directly/indirectly the header file defining it. In fact > gsm0411_smc.c fails to compile due this. Oops, forgot to include this in the patch, my apologies. Updated patch is attached. From 5977b6ed34960171aaf89e8d60f4693953a2c053 Mon Sep 17 00:00:00 2001 From: Alexander Chemeris Date: Sun, 9 Mar 2014 11:48:16 +0100 Subject: [PATCH] sms: Fix typo in a macros name: GSM340_SMS_RESSERVED -> GSM340_SMS_RESERVED. --- include/osmocom/gsm/protocol/gsm_04_11.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/osmocom/gsm/protocol/gsm_04_11.h b/include/osmocom/gsm/protocol/gsm_04_11.h index f37152f..38dd553 100644 --- a/include/osmocom/gsm/protocol/gsm_04_11.h +++ b/include/osmocom/gsm/protocol/gsm_04_11.h @@ -122,7 +122,7 @@ enum sms_alphabet { #define GSM340_SMS_COMMAND_MS2SC 0x02 #define GSM340_SMS_SUBMIT_MS2SC 0x01 #define GSM340_SMS_SUBMIT_REP_SC2MS 0x01 -#define GSM340_SMS_RESSERVED 0x03 +#define GSM340_SMS_RESERVED 0x03 /* GSM 03.40 / Chapter 9.2.3.2: TP-More-Messages-to-Send */ #define GSM340_TP_MMS_MORE 0 -- 1.7.9.5