From patchwork Wed Mar 12 17:08:00 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexander Chemeris X-Patchwork-Id: 329578 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 62C0E2C00C2 for ; Thu, 13 Mar 2014 04:08:40 +1100 (EST) Received: from localhost ([127.0.0.1] helo=ganesha.gnumonks.org) by ganesha.gnumonks.org with esmtp (Exim 4.72) (envelope-from ) id 1WNmdr-0005Hz-Pg; Wed, 12 Mar 2014 18:08:32 +0100 Received: from mail-pd0-x22d.google.com ([2607:f8b0:400e:c02::22d]) by ganesha.gnumonks.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.72) (envelope-from ) id 1WNmdi-0005Hp-ED for openbsc@lists.osmocom.org; Wed, 12 Mar 2014 18:08:25 +0100 Received: by mail-pd0-f173.google.com with SMTP id z10so1324076pdj.18 for ; Wed, 12 Mar 2014 10:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=o7x3v1b7OUXBb6KrnFq/t38ROzpIoPFDmaFJdC7koAU=; b=qXbbdCUFhkDw81WRQcr3czefuQ8Nu/JO8/8bDxs5qDOdI47cJ7URgwOkdlzRGRYmut vwlPyufIS4f0Ke5eSer8AkGo22iK/Y3GoE78U2CdI9PJG14wvOLf1y+15uA2T0ism4nm gt4BIFKOf/frjw3/K8u70hT+iF1bVK+A3nMKlylomeN9P0HKukfPg7AonQUV9bGYgJM/ OuyHqcWINPWMlJjCEjxx1YewRfSFWsvtb6Zk/J60nkL1MI0sSaGXUI35Z1xeLpXuvK7O C+GmTCA9qztICPnxs15jZth9NtZr7VetutJyDEloOjbh95PVrT0UUS1+Yme3ngdLhPxw kMLg== X-Received: by 10.68.170.66 with SMTP id ak2mr6402033pbc.5.1394644100639; Wed, 12 Mar 2014 10:08:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.70.88.239 with HTTP; Wed, 12 Mar 2014 10:08:00 -0700 (PDT) In-Reply-To: References: From: Alexander Chemeris Date: Wed, 12 Mar 2014 21:08:00 +0400 Message-ID: Subject: Re: [PATCH 3/6] sms_test: Introduce tests for SMS Vvalidity time relative and absolute formats. To: OpenBSC Mailing List X-Spam-Score: -0.1 (/) X-BeenThere: openbsc@lists.osmocom.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development of the OpenBSC GSM base station controller List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openbsc-bounces@lists.osmocom.org Errors-To: openbsc-bounces@lists.osmocom.org Updated after the gsm340_validity_time() rename. On Sat, Mar 8, 2014 at 3:45 AM, Alexander Chemeris wrote: > > > > On Fri, Mar 7, 2014 at 9:17 PM, Alexander Chemeris > wrote: >> >> This tests demonstrate issues with the current code. >> >> -- >> Regards, >> Alexander Chemeris. >> CEO, Fairwaves, Inc. / ООО УмРадио >> https://fairwaves.co > > > > > -- > Regards, > Alexander Chemeris. > CEO, Fairwaves, Inc. / ООО УмРадио > https://fairwaves.co From 7b33ad5e709db39b1f9b9d7a8d1f3f9d50c7fa7b Mon Sep 17 00:00:00 2001 From: Alexander Chemeris Date: Fri, 7 Mar 2014 20:55:21 +0100 Subject: [PATCH 3/6] sms_test: Introduce tests for SMS Validity time relative and absolute formats. This tests demonstrate issues with the current code. --- tests/sms/sms_test.c | 130 +++++++++++++++++++++++++++++++++++++++++++++++++ tests/sms/sms_test.ok | 82 +++++++++++++++++++++++++++++++ tests/testsuite.at | 2 +- 3 files changed, 213 insertions(+), 1 deletion(-) diff --git a/tests/sms/sms_test.c b/tests/sms/sms_test.c index 30ce1f4..f664ebc 100644 --- a/tests/sms/sms_test.c +++ b/tests/sms/sms_test.c @@ -1,6 +1,7 @@ /* * (C) 2008 by Daniel Willmann * (C) 2010 by Nico Golde + * (C) 2014 by Alexander Chemeris * All Rights Reserved * * This program is free software; you can redistribute it and/or modify @@ -24,6 +25,7 @@ #include #include +#include #include #include @@ -268,6 +270,133 @@ static void test_gen_oa(void) printf("Result: len(%d) data(%s)\n", len, osmo_hexdump(oa, len)); } +#define PRINT_VALIDITY_TIMES(expected, decoded) \ +{ \ + char _validity_timestamp[1024]; \ + time_t _temp_time; \ + _temp_time = (expected); \ + strftime(_validity_timestamp, sizeof(_validity_timestamp), \ + "%F %T", gmtime(&_temp_time)); \ + printf("Expected: %s\n", _validity_timestamp); \ + _temp_time = (decoded); \ + strftime(_validity_timestamp, sizeof(_validity_timestamp), \ + "%F %T", gmtime(&_temp_time)); \ + printf("Decoded: %s\n", _validity_timestamp); \ +} \ + +#define TEST_VALIDITY_DECODING(test_data, encoding) \ +{ \ + int i; \ + time_t valid_until; \ + for (i=0; i expout -AT_CHECK([$abs_top_builddir/tests/sms/sms_test], [0], [expout]) +AT_CHECK([$abs_top_builddir/tests/sms/sms_test], [0], [expout], [ignore]) AT_CLEANUP AT_SETUP([smscb]) -- 1.7.9.5