From patchwork Thu Mar 13 08:18:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Chemeris X-Patchwork-Id: 329801 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id C4EF42C00A7 for ; Thu, 13 Mar 2014 19:20:03 +1100 (EST) Received: from localhost ([127.0.0.1] helo=ganesha.gnumonks.org) by ganesha.gnumonks.org with esmtp (Exim 4.72) (envelope-from ) id 1WO0rf-000571-Kr; Thu, 13 Mar 2014 09:19:44 +0100 Received: from mail-pd0-x231.google.com ([2607:f8b0:400e:c02::231]) by ganesha.gnumonks.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.72) (envelope-from ) id 1WO0rC-00056r-5F for openbsc@lists.osmocom.org; Thu, 13 Mar 2014 09:19:16 +0100 Received: by mail-pd0-f177.google.com with SMTP id y10so744571pdj.36 for ; Thu, 13 Mar 2014 01:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=C/o8tjzS5QG0w+i+ihcNvuc4AXKuE6VNtPhg8x5bm64=; b=xlN7swUKED1517Zonn9kxbzz/oFPGlsz55rMGAcNI6vV9oxNudI3hMp6bX1rjnjbmt zLcmfhqK7wEM6Ght8DQz5Q41qlsFKq8Hq4r7+vVzd9+G1MJeRPncIyNJnRZ5/wpDGsps KsL226kBHCfRWIXFTZBTkcZGu2Q/iqfO6g24KwTk0EG15e3hAsmSVdcVAJf9aUCSQdQV NdvgPmXulyslnFegUTu6QYB3cs8aHBGuI2JW8NEQz3C6BjZhbs68CbmRgKqs0fBT6P/2 D+Hap4LZuBnfEgsJW1ze3PYIGRNAo/gpgxHsY6/69XuePLM/LkfIkN2T076IurE0/Erg Eq0w== X-Received: by 10.66.142.107 with SMTP id rv11mr639021pab.17.1394698750838; Thu, 13 Mar 2014 01:19:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.70.88.239 with HTTP; Thu, 13 Mar 2014 01:18:49 -0700 (PDT) In-Reply-To: <20140312204417.GJ2164@xiaoyu.lan> References: <20140312160942.GC2371@adrastea.totalueberwachung.de> <20140312204417.GJ2164@xiaoyu.lan> From: Alexander Chemeris Date: Thu, 13 Mar 2014 12:18:49 +0400 Message-ID: Subject: Re: [PATCH 2/6] sms_test: Do not crash on logging. To: Holger Hans Peter Freyther X-Spam-Score: -0.1 (/) Cc: OpenBSC Mailing List X-BeenThere: openbsc@lists.osmocom.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development of the OpenBSC GSM base station controller List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openbsc-bounces@lists.osmocom.org Errors-To: openbsc-bounces@lists.osmocom.org On Thu, Mar 13, 2014 at 12:44 AM, Holger Hans Peter Freyther wrote: > On Wed, Mar 12, 2014 at 08:49:52PM +0400, Alexander Chemeris wrote: > >> +#include >> +#include > > include/osmocom/core?? Hum, indeed. I have to update my mind model on what leads to compile errors and what is not. An updated patch is attached. Please merge it if there are no more comments. From a1c751971504bd51bfd7f185b59bde1c3b77ea95 Mon Sep 17 00:00:00 2001 From: Alexander Chemeris Date: Fri, 7 Mar 2014 20:42:03 +0100 Subject: [PATCH 2/6] sms_test: Do not crash on logging. --- tests/sms/sms_test.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/sms/sms_test.c b/tests/sms/sms_test.c index 755b321..30ce1f4 100644 --- a/tests/sms/sms_test.c +++ b/tests/sms/sms_test.c @@ -31,6 +31,11 @@ #include #include +#include +#include + +struct log_info fake_log_info = {}; + struct test_case { const uint8_t *input; const uint16_t input_length; @@ -278,6 +283,9 @@ int main(int argc, char** argv) int nchars; char result[256]; + /* Fake logging. */ + osmo_init_logging(&fake_log_info); + /* test 7-bit encoding */ for (i = 0; i < ARRAY_SIZE(test_encode); ++i) { /* Test legacy function (return value only) */ -- 1.7.9.5