From patchwork Mon Jan 15 20:23:40 2018
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Neels Hofmeyr <nhofmeyr@sysmocom.de>
X-Patchwork-Id: 861069
Return-Path: <openbsc-bounces@lists.osmocom.org>
X-Original-To: incoming@patchwork.ozlabs.org
Delivered-To: patchwork-incoming@bilbo.ozlabs.org
Authentication-Results: ozlabs.org;
	spf=pass (mailfrom) smtp.mailfrom=lists.osmocom.org
	(client-ip=2a01:4f8:191:444b::2:7; helo=lists.osmocom.org;
	envelope-from=openbsc-bounces@lists.osmocom.org;
	receiver=<UNKNOWN>)
Received: from lists.osmocom.org (lists.osmocom.org
	[IPv6:2a01:4f8:191:444b::2:7])
	by ozlabs.org (Postfix) with ESMTP id 3zL4Zc3ZcBz9sQm
	for <incoming@patchwork.ozlabs.org>;
	Tue, 16 Jan 2018 07:24:24 +1100 (AEDT)
Received: from lists.osmocom.org (lists.osmocom.org [144.76.43.76])
	by lists.osmocom.org (Postfix) with ESMTP id 02FF547AE8;
	Mon, 15 Jan 2018 20:24:19 +0000 (UTC)
Authentication-Results: lists.osmocom.org; dmarc=none header.from=sysmocom.de
X-Original-To: openbsc@lists.osmocom.org
Delivered-To: openbsc@lists.osmocom.org
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
	client-ip=2a01:4f8:191:444c::2:4; helo=mail.sysmocom.de;
	envelope-from=nhofmeyr@sysmocom.de;
	receiver=openbsc@lists.osmocom.org
Authentication-Results: lists.osmocom.org; dmarc=none header.from=sysmocom.de
Received: from mail.sysmocom.de (mail.sysmocom.de
	[IPv6:2a01:4f8:191:444c::2:4])
	by lists.osmocom.org (Postfix) with ESMTP id B539A47AD5
	for <openbsc@lists.osmocom.org>; Mon, 15 Jan 2018 20:24:16 +0000 (UTC)
Received: from mail.sysmocom.de (mail.sysmocom.de [144.76.43.93])
	by mail.sysmocom.de (Postfix) with ESMTP id 961C53243AA;
	Mon, 15 Jan 2018 20:23:46 +0000 (UTC)
Received: from my.box (unknown [37.120.109.34])
	by mail.sysmocom.de (Postfix) with ESMTPSA id 0A6A93243A9;
	Mon, 15 Jan 2018 20:23:46 +0000 (UTC)
Date: Mon, 15 Jan 2018 21:23:40 +0100
From: Neels Hofmeyr <nhofmeyr@sysmocom.de>
To: Philipp Maier <pmaier@sysmocom.de>
Subject: osmo-bsc_nat dropped in unrelated patch
Message-ID: <20180115202340.GB14510@my.box>
MIME-Version: 1.0
Content-Disposition: inline
User-Agent: Mutt/1.9.2 (2017-12-15)
X-Virus-Scanned: ClamAV using ClamSMTP
X-BeenThere: openbsc@lists.osmocom.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Development of OpenBSC, OsmoBSC, OsmoNITB,
	OsmoCSCN" <openbsc.lists.osmocom.org>
List-Unsubscribe: <https://lists.osmocom.org/mailman/options/openbsc>,
	<mailto:openbsc-request@lists.osmocom.org?subject=unsubscribe>
List-Archive: <http://lists.osmocom.org/pipermail/openbsc/>
List-Post: <mailto:openbsc@lists.osmocom.org>
List-Help: <mailto:openbsc-request@lists.osmocom.org?subject=help>
List-Subscribe: <https://lists.osmocom.org/mailman/listinfo/openbsc>,
	<mailto:openbsc-request@lists.osmocom.org?subject=subscribe>
Cc: openbsc@lists.osmocom.org
Errors-To: openbsc-bounces@lists.osmocom.org
Sender: "OpenBSC" <openbsc-bounces@lists.osmocom.org>

Hi dexter,

reading a commit of yours apparently merged to osmo-bsc in November, I notice
that you "secretly sneaked in" this:




in a patch that was supposed to "mgcp: use osmo-mgw to switch RTP streams".
http://git.osmocom.org/osmo-bsc/commit/?id=39c609b7c924524172ad311bdf89f92b7ccf175a

So since we merged that patch, osmo-bsc_nat is no longer part of the osmo-bsc
build. That's certainly not intended, is it?

Confirm and please fix that. thx!

~N

diff --git a/src/Makefile.am b/src/Makefile.am
index d04f025..dd1ad3d 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -33,5 +33,4 @@ SUBDIRS += \
 	utils \
 	ipaccess \
 	osmo-bsc \
-	osmo-bsc_nat \
 	$(NULL)