From patchwork Sat Sep 2 14:34:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vadim Yanitskiy X-Patchwork-Id: 809070 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.osmocom.org (client-ip=2a01:4f8:191:444b::2:7; helo=lists.osmocom.org; envelope-from=openbsc-bounces@lists.osmocom.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QGvY0nJw"; dkim-atps=neutral Received: from lists.osmocom.org (lists.osmocom.org [IPv6:2a01:4f8:191:444b::2:7]) by ozlabs.org (Postfix) with ESMTP id 3xkzDt4M0jz9sP1 for ; Sun, 3 Sep 2017 00:35:58 +1000 (AEST) Received: from lists.osmocom.org (lists.osmocom.org [144.76.43.76]) by lists.osmocom.org (Postfix) with ESMTP id 1955F38DD2; Sat, 2 Sep 2017 14:35:57 +0000 (UTC) Authentication-Results: lists.osmocom.org; dmarc=pass header.from=gmail.com Authentication-Results: lists.osmocom.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=QGvY0nJw X-Original-To: openbsc@lists.osmocom.org Delivered-To: openbsc@lists.osmocom.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:4010:c07::22a; helo=mail-lf0-x22a.google.com; envelope-from=axilirator@gmail.com; receiver=openbsc@lists.osmocom.org Authentication-Results: lists.osmocom.org; dmarc=pass header.from=gmail.com Received: from mail-lf0-x22a.google.com (mail-lf0-x22a.google.com [IPv6:2a00:1450:4010:c07::22a]) by lists.osmocom.org (Postfix) with ESMTP id 9276138DA9 for ; Sat, 2 Sep 2017 14:34:11 +0000 (UTC) Received: by mail-lf0-x22a.google.com with SMTP id d17so8602553lfe.1 for ; Sat, 02 Sep 2017 07:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=NoWfGqSNYiOUoK58govtGMCPudXGnl+vpcBwPuWAag4=; b=QGvY0nJw3vBMWE8D+1jdFRDznXwk0uXp7aHsDI6zlUhCYRn8XUc5xWf0V7ZAFz9+7V ilpzXMF+PHCiE02e/+dmQilvP7ua/iilrnW9euHvTMGGLILSZry8PjRwSgPmws670I+X EGNusMU+ms9EjLfSIiOC20LJKug+4KZyb488wHoveYVQQXXolVg0zgDkjHuObfmfOJsf FdxF8438jgWXXF/ah6vkZPDiwJwfX7GNlnvvZ7KnrFmC7BWj5oarphSMMROjDlK257Pf dRHxB4dzS5HRXsfK6h/E6ZDzHN+uKp7UiOySNqF0JKUnTDM0TVV/A3Nye3qWBkEbGLq0 0daQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=NoWfGqSNYiOUoK58govtGMCPudXGnl+vpcBwPuWAag4=; b=foXBWMkneVvTlO7tnXw/3bX53OFLjIJQIYrwuWIXqWMK8kq1ivod7XCH/k8dswcEEp +s6Hqi2vZZsE352TdNdFeIUg4GjwLNh4q4Xpq0a3pnU6PRyZ9E24R4uCmeiECHDW/SiM HDdovlQLbHpVp7Nm8tWytz4ge6D2k40Z4ggchTDdvqEVE4NbwTOZofa7moMjdtXGegoN sfa4lvLsgLFpKYbBDnhZGW+OKHvgrzTXZzjivnNxa0VmYTP3X5MQww/97GubglaXluon fBgLsqQH8JxcUo1Yk4B4zoGWgJiSrOrFcpoooPbHe71RA+t3PwtfnEXG9unC+bVDSePz MtCg== X-Gm-Message-State: AHPjjUi2KYT8d7mlxVdIAll+nOTbbVRFCdt0p+UzNBvQL8+xg5geCKTl b8uLihjUjjGIbANrzkM= X-Google-Smtp-Source: ADKCNb7BxghL6I3Bt8CfHFCVXVMuqvaciLMXTMldjKRpJZvDr+kzC47vE5GKKLYXdEQgSFLKI49kog== X-Received: by 10.25.33.65 with SMTP id h62mr2417128lfh.90.1504362850887; Sat, 02 Sep 2017 07:34:10 -0700 (PDT) Received: from DELL.lan ([92.127.181.248]) by smtp.gmail.com with ESMTPSA id e11sm413177lji.82.2017.09.02.07.34.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 02 Sep 2017 07:34:10 -0700 (PDT) From: Vadim Yanitskiy To: openbsc@lists.osmocom.org Subject: [PATCH 2/2] pq_alsa.c: print error message if device init fails Date: Sat, 2 Sep 2017 21:34:03 +0700 Message-Id: <20170902143403.14185-2-axilirator@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170902143403.14185-1-axilirator@gmail.com> References: <20170902143403.14185-1-axilirator@gmail.com> X-BeenThere: openbsc@lists.osmocom.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of OpenBSC, OsmoBSC, OsmoNITB, OsmoCSCN" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openbsc-bounces@lists.osmocom.org Sender: "OpenBSC" --- src/pq_alsa.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/pq_alsa.c b/src/pq_alsa.c index a3435dd..cad76ca 100644 --- a/src/pq_alsa.c +++ b/src/pq_alsa.c @@ -85,13 +85,16 @@ pq_queue_alsa_op(struct pq *pq, const char *alsa_dev, unsigned int blk_len, int int rc = -1; state = calloc(1, sizeof(struct pq_state_alsa)); - if (!state) - return -ENOMEM; + if (!state) { + rc = -ENOMEM; + goto out_print; + } rc = snd_pcm_open(&state->pcm_handle, alsa_dev, in_out_n ? SND_PCM_STREAM_CAPTURE : SND_PCM_STREAM_PLAYBACK, 0); if (rc < 0) - return rc; + goto out_print; + state->blk_len = blk_len; rc = snd_pcm_hw_params_malloc(&hw_params); @@ -143,6 +146,9 @@ out_free_par: out_close: snd_pcm_close(state->pcm_handle); free(state); +out_print: + fprintf(stderr, "[!] Couldn't init ALSA device '%s': %s\n", + alsa_dev, snd_strerror(rc)); return rc; }