From patchwork Fri Dec 25 16:15:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harald Welte X-Patchwork-Id: 561044 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.osmocom.org (tmp.osmocom.org [144.76.43.76]) by ozlabs.org (Postfix) with ESMTP id 44D75140C79 for ; Sat, 26 Dec 2015 03:17:36 +1100 (AEDT) Received: from lists.osmocom.org (lists.osmocom.org [144.76.43.76]) by lists.osmocom.org (Postfix) with ESMTP id 548EBA9D7; Fri, 25 Dec 2015 16:17:33 +0000 (UTC) X-Original-To: openbsc@lists.osmocom.org Delivered-To: openbsc@lists.osmocom.org Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [213.95.27.120]) by lists.osmocom.org (Postfix) with ESMTP id 2AB95A9C5 for ; Fri, 25 Dec 2015 16:17:31 +0000 (UTC) Received: from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.72) (envelope-from ) id 1aCV3b-00055K-II; Fri, 25 Dec 2015 17:17:31 +0100 Received: from laforge by localhost.localdomain with local (Exim 4.86) (envelope-from ) id 1aCV1z-0008Rp-Cg; Fri, 25 Dec 2015 17:15:51 +0100 Date: Fri, 25 Dec 2015 17:15:51 +0100 From: Harald Welte To: Sipos Csaba Subject: Re: Osmo-PCU: make error Message-ID: <20151225161551.GG31126@nataraja> References: <855747125.15111379.1451054763725.JavaMail.zimbra@kvk.uni-obuda.hu> <635575092.15111507.1451055045594.JavaMail.zimbra@kvk.uni-obuda.hu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <635575092.15111507.1451055045594.JavaMail.zimbra@kvk.uni-obuda.hu> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: openbsc@lists.osmocom.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Development of the OpenBSC GSM base station controller List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: OpenBSC Mailing List Errors-To: openbsc-bounces@lists.osmocom.org Sender: "OpenBSC" Hi Sipos, On Fri, Dec 25, 2015 at 03:50:45PM +0100, Sipos Csaba wrote: > /usr/local/include/osmocom/core/prim.h:23:27: error: uninitialized const 'osmo_prim_op_names' [-fpermissive] > const struct value_string osmo_prim_op_names[5]; This was introduced by one of my recent libosmocore changes, sorry. The patch below (just pushed to libosmocore master) should fix it. From c959afdcd9d8f227f4a72a915ac2e3f79d1d1d3b Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Fri, 25 Dec 2015 17:14:07 +0100 Subject: [PATCH] osmo_prim_op_names should be extern --- include/osmocom/core/prim.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/osmocom/core/prim.h b/include/osmocom/core/prim.h index e920eb8..9e71007 100644 --- a/include/osmocom/core/prim.h +++ b/include/osmocom/core/prim.h @@ -20,7 +20,7 @@ enum osmo_prim_operation { PRIM_OP_CONFIRM, /*!< \brief cofirm */ }; -const struct value_string osmo_prim_op_names[5]; +extern const struct value_string osmo_prim_op_names[5]; #define _SAP_GSM_SHIFT 24