From patchwork Tue Nov 17 13:38:45 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neels Hofmeyr X-Patchwork-Id: 545575 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.osmocom.org (tmp.osmocom.org [144.76.43.76]) by ozlabs.org (Postfix) with ESMTP id 65C6714144D for ; Wed, 18 Nov 2015 00:38:57 +1100 (AEDT) Received: from lists.osmocom.org (lists.osmocom.org [144.76.43.76]) by lists.osmocom.org (Postfix) with ESMTP id 2A13395C0; Tue, 17 Nov 2015 13:38:55 +0000 (UTC) X-Original-To: openbsc@lists.osmocom.org Delivered-To: openbsc@lists.osmocom.org Received: from mail.sysmocom.de (mail.sysmocom.de [IPv6:2a01:4f8:191:444c::2:4]) by lists.osmocom.org (Postfix) with ESMTP id CE37195AC for ; Tue, 17 Nov 2015 13:38:53 +0000 (UTC) Received: from dub5.am93.sysmocom.de (ip5b4185b8.dynamic.kabel-deutschland.de [91.65.133.184]) by mail.sysmocom.de (Postfix) with ESMTPSA id 16ECA1D2D6A for ; Tue, 17 Nov 2015 13:38:53 +0000 (UTC) From: Neels Hofmeyr To: openbsc@lists.osmocom.org Subject: [PATCH 1/3] gtphub: lose obsolete comment. Date: Tue, 17 Nov 2015 14:38:45 +0100 Message-Id: <1447767527-27316-1-git-send-email-nhofmeyr@sysmocom.de> X-Mailer: git-send-email 2.1.4 X-BeenThere: openbsc@lists.osmocom.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Development of the OpenBSC GSM base station controller List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openbsc-bounces@lists.osmocom.org Sender: "OpenBSC" The del_cb is now also used for ares (GGSN resolution) timeouts, and expiry is anyway separated from nr_map, so this comment is void. Sponsored-by: On-Waves ehi --- openbsc/include/openbsc/gtphub.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/openbsc/include/openbsc/gtphub.h b/openbsc/include/openbsc/gtphub.h index 49d685c..68cf90e 100644 --- a/openbsc/include/openbsc/gtphub.h +++ b/openbsc/include/openbsc/gtphub.h @@ -248,8 +248,6 @@ int expiry_tick(struct expiry *exq, time_t now); * Mapping allocation and a del_cb are provided by the caller. If del_cb is * NULL, no deallocation will be done (allowing statically allocated entries). */ -/* TODO at some point I thought the allocation & del_cb complexity was - * needed/helpful, but by now it seems like overkill. Maybe lose that again. */ typedef int nr_t;