diff mbox

[05/15] gtphub: add a todo comment

Message ID 1444947239-17582-6-git-send-email-nhofmeyr@sysmocom.de
State Superseded
Headers show

Commit Message

Neels Hofmeyr Oct. 15, 2015, 10:13 p.m. UTC
diff mbox

Patch

diff --git a/openbsc/src/gprs/gtphub.c b/openbsc/src/gprs/gtphub.c
index 97e52a6..577a2d0 100644
--- a/openbsc/src/gprs/gtphub.c
+++ b/openbsc/src/gprs/gtphub.c
@@ -119,6 +119,8 @@  static int gtp_relay(struct osmo_fd *from,
 	errno = 0;
 	ssize_t received = recvfrom(from->fd, buf, sizeof(buf), 0,
 				    (struct sockaddr*)from_addr, from_addr_len);
+	/* TODO use recvmsg and get a MSG_TRUNC flag to make sure the message
+	 * is not truncated. Then maybe reduce buf's size. */
 
 	if (received <= 0) {
 		if (errno != EAGAIN)