diff mbox

add todo comments

Message ID 1444652941-28379-2-git-send-email-nhofmeyr@sysmocom.de
State Accepted
Headers show

Commit Message

Neels Hofmeyr Oct. 12, 2015, 12:29 p.m. UTC 
---
 gtp/gtp.c | 6 ++++++
 1 file changed, 6 insertions(+)
diff mbox

Patch

diff --git a/gtp/gtp.c b/gtp/gtp.c
index 73ed76a..e6a610d 100644
--- a/gtp/gtp.c
+++ b/gtp/gtp.c
@@ -2181,6 +2181,9 @@  int gtp_update_pdp_conf(struct gsn_t *gsn, int version,
 	if (gtp_conf(gsn, 0, peer, pack, len, &type, &cbp))
 		return EOF;
 
+	/* TODO This function is called from gtp_decaps1c() (for GTP v1) but
+	 * uses gtp0.h.flow (GTP v0 data element)
+	 */
 	/* Find the context in question */
 	if (pdp_getgtp0(&pdp, ntoh16(((union gtp_packet *)pack)->gtp0.h.flow))) {
 		gsn->err_unknownpdp++;
@@ -2194,6 +2197,9 @@  int gtp_update_pdp_conf(struct gsn_t *gsn, int version,
 	/* Register that we have received a valid teic from GGSN */
 	pdp->teic_confirmed = 1;
 
+	/* TODO This function is called from gtp_decaps1c() (for GTP v1) but
+	 * explicitly passes version 0 and GTP0_HEADER_SIZE to gtpie_decaps()
+	 */
 	/* Decode information elements */
 	if (gtpie_decaps
 	    (ie, 0, pack + GTP0_HEADER_SIZE, len - GTP0_HEADER_SIZE)) {