diff mbox

[2/6] osmux: Do not divide the number of bytes by eight.

Message ID 1443950574-75194-2-git-send-email-holger@freyther.de
State Accepted
Headers show

Commit Message

Holger Freyther Oct. 4, 2015, 9:22 a.m. UTC 
From: Holger Hans Peter Freyther <holger@moiji-mobile.com>

sizeof(uint8_t) == 1 and there is no need to create an array
with 16 bytes and then only use the first two of them. This
means the CID range is from 0 to 127 and we should be able
to extend this to 256 by changing the array size to 32. Update
the testcase now that we can have more than 16 calls with Osmux.
---
 openbsc/src/libmgcp/mgcp_osmux.c | 4 ++--
 openbsc/tests/mgcp/mgcp_test.c   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
diff mbox

Patch

diff --git a/openbsc/src/libmgcp/mgcp_osmux.c b/openbsc/src/libmgcp/mgcp_osmux.c
index b0ef69f..30a81cb 100644
--- a/openbsc/src/libmgcp/mgcp_osmux.c
+++ b/openbsc/src/libmgcp/mgcp_osmux.c
@@ -536,7 +536,7 @@  int osmux_used_cid(void)
 {
 	int i, j, used = 0;
 
-	for (i = 0; i < sizeof(osmux_cid_bitmap) / 8; i++) {
+	for (i = 0; i < sizeof(osmux_cid_bitmap); i++) {
 		for (j = 0; j < 8; j++) {
 			if (osmux_cid_bitmap[i] & (1 << j))
 				used += 1;
@@ -550,7 +550,7 @@  int osmux_get_cid(void)
 {
 	int i, j;
 
-	for (i = 0; i < sizeof(osmux_cid_bitmap) / 8; i++) {
+	for (i = 0; i < sizeof(osmux_cid_bitmap); i++) {
 		for (j = 0; j < 8; j++) {
 			if (osmux_cid_bitmap[i] & (1 << j))
 				continue;
diff --git a/openbsc/tests/mgcp/mgcp_test.c b/openbsc/tests/mgcp/mgcp_test.c
index 7b5de31..ec86c55 100644
--- a/openbsc/tests/mgcp/mgcp_test.c
+++ b/openbsc/tests/mgcp/mgcp_test.c
@@ -1186,7 +1186,7 @@  static void test_osmux_cid(void)
 	osmux_put_cid(id);
 	OSMO_ASSERT(osmux_used_cid() == 0);
 
-	for (i = 0; i < 16; ++i) {
+	for (i = 0; i < 128; ++i) {
 		id = osmux_get_cid();
 		OSMO_ASSERT(id == i);
 		OSMO_ASSERT(osmux_used_cid() == i + 1);