diff mbox

[1/2] subscr: Fix potential subscr ref count issue

Message ID 1438687089-76685-1-git-send-email-holger@moiji-mobile.com
State Accepted
Headers show

Commit Message

Holger@lists.osmocom.org, Hans@lists.osmocom.org, Peter@lists.osmocom.org, Freyther@lists.osmocom.org Aug. 4, 2015, 11:18 a.m. UTC 
From: Holger Hans Peter Freyther <holger@moiji-mobile.com>

In case the subscriber is currently busy we would omit the
subscr_put. This seems to be very hard to hit as the subscr
need to be active and at the same time be selected for the
purge operation.
---
 openbsc/src/libmsc/gsm_subscriber.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox

Patch

diff --git a/openbsc/src/libmsc/gsm_subscriber.c b/openbsc/src/libmsc/gsm_subscriber.c
index 4559de5..085acb1 100644
--- a/openbsc/src/libmsc/gsm_subscriber.c
+++ b/openbsc/src/libmsc/gsm_subscriber.c
@@ -353,6 +353,7 @@  static void subscr_expire_callback(void *data, long long unsigned int id)
 		LOGP(DMM, LOGL_DEBUG, "Not expiring subscriber %s (ID %llu)\n",
 			subscr_name(s), id);
 		subscr_update_expire_lu(s, conn->bts);
+		subscr_put(s);
 		return;
 	}