From patchwork Wed Nov 11 15:23:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jaroslav Skarvada X-Patchwork-Id: 542924 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.osmocom.org (unknown [IPv6:2a01:4f8:191:444b::2:7]) by ozlabs.org (Postfix) with ESMTP id 2C0D9140323 for ; Thu, 12 Nov 2015 02:23:20 +1100 (AEDT) Received: from lists.osmocom.org (lists.osmocom.org [144.76.43.76]) by lists.osmocom.org (Postfix) with ESMTP id 564D4914A; Wed, 11 Nov 2015 15:23:18 +0000 (UTC) X-Original-To: openbsc@lists.osmocom.org Delivered-To: openbsc@lists.osmocom.org Received: from mx5-phx2.redhat.com (mx5-phx2.redhat.com [209.132.183.37]) by lists.osmocom.org (Postfix) with ESMTP id 2A87F9137 for ; Wed, 11 Nov 2015 15:23:14 +0000 (UTC) Received: from zmail14.collab.prod.int.phx2.redhat.com (zmail14.collab.prod.int.phx2.redhat.com [10.5.83.16]) by mx5-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tABFNBnn050314 for ; Wed, 11 Nov 2015 10:23:11 -0500 Date: Wed, 11 Nov 2015 10:23:11 -0500 (EST) From: Jaroslav Skarvada To: openbsc@lists.osmocom.org Message-ID: <1076717592.8478548.1447255391492.JavaMail.zimbra@redhat.com> In-Reply-To: <20151110194840.GU8473@nataraja> References: <1195163689.6803559.1447087336065.JavaMail.zimbra@redhat.com> <1096145625.7613757.1447149383640.JavaMail.zimbra@redhat.com> <20151110194840.GU8473@nataraja> Subject: Re: libosmocore minor issues MIME-Version: 1.0 X-Originating-IP: [10.34.24.56] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF42 (Linux)/8.0.6_GA_5922) Thread-Topic: libosmocore minor issues Thread-Index: PYOjn5V37Z8hNHY3qahNjTTlRv5Nxw== X-BeenThere: openbsc@lists.osmocom.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Development of the OpenBSC GSM base station controller List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openbsc-bounces@lists.osmocom.org Sender: "OpenBSC" ----- Original Message ----- > Hi Jaroslav, > > On Tue, Nov 10, 2015 at 04:56:23AM -0500, Jaroslav Skarvada wrote: > > I am working on getting libosmocom package into Fedora, there is > > review request in [1]. > > Thanks for this! > > > During the packaging I found following minor issues: > > - Incorrect FSF addresses in source code > > This is easy to fix. Do you already have a patch to fix all > occurrences? I'd happily apply that. > Patch attempting to fix it is attached. > > - exit call in the library: /usr/lib64/libosmovty.so.3.0.0 exit@GLIBC_2.2.5 > > libraries shouldn't generally call exit. > > libosmovty started as a fork of the VTY (telnet command line interface) > code of GNU zebra. So the code was not written as a library to begin > with, but was part of zebra itself. > > In any case, addressing those issues is not particularly easy, as said > functions should never fail at this point, but they don't have a way to > return an error code, or their callers simply assume they always > succeed. > > So the best we can do without breaking API and ABI (and modifying all > users of the library) is to change the exit(1) calls into an assert. > Would that be better? Nice, thanks. Please note, this is not something that blocks Fedora review, I just wanted to point it out, e.g. to consider it for next API update sometimes in the future thanks & regards Jaroslav From db50baf82628b88d56210945c1a109ea61715b7c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jaroslav=20=C5=A0karvada?= Date: Wed, 11 Nov 2015 16:02:54 +0100 Subject: [PATCH] fix FSF address in sources/headers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jaroslav Škarvada --- include/osmocom/core/linuxrbtree.h | 3 ++- include/osmocom/vty/buffer.h | 4 ++-- include/osmocom/vty/command.h | 4 ++-- include/osmocom/vty/vector.h | 4 ++-- src/rbtree.c | 3 ++- src/select.c | 3 ++- src/vty/buffer.c | 4 ++-- src/vty/command.c | 4 ++-- src/vty/vector.c | 4 ++-- 9 files changed, 18 insertions(+), 15 deletions(-) diff --git a/include/osmocom/core/linuxrbtree.h b/include/osmocom/core/linuxrbtree.h index ef8bc15..d3f9fd1 100644 --- a/include/osmocom/core/linuxrbtree.h +++ b/include/osmocom/core/linuxrbtree.h @@ -14,7 +14,8 @@ You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software - Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, + MA 02110-1301, USA. linux/include/linux/rbtree.h diff --git a/include/osmocom/vty/buffer.h b/include/osmocom/vty/buffer.h index f6c86a1..56c28f0 100644 --- a/include/osmocom/vty/buffer.h +++ b/include/osmocom/vty/buffer.h @@ -16,8 +16,8 @@ * * You should have received a copy of the GNU General Public License * along with GNU Zebra; see the file COPYING. If not, write to the - * Free Software Foundation, Inc., 59 Temple Place - Suite 330, - * Boston, MA 02111-1307, USA. + * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, + * Boston, MA 02110-1301, USA. */ #pragma once diff --git a/include/osmocom/vty/command.h b/include/osmocom/vty/command.h index 2ef4109..2078e1b 100644 --- a/include/osmocom/vty/command.h +++ b/include/osmocom/vty/command.h @@ -16,8 +16,8 @@ * * You should have received a copy of the GNU General Public License * along with GNU Zebra; see the file COPYING. If not, write to the - * Free Software Foundation, Inc., 59 Temple Place - Suite 330, - * Boston, MA 02111-1307, USA. + * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, + * Boston, MA 02110-1301, USA. */ #pragma once diff --git a/include/osmocom/vty/vector.h b/include/osmocom/vty/vector.h index 7caa5ff..c00804d 100644 --- a/include/osmocom/vty/vector.h +++ b/include/osmocom/vty/vector.h @@ -16,8 +16,8 @@ * * You should have received a copy of the GNU General Public License * along with GNU Zebra; see the file COPYING. If not, write to the Free - * Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA - * 02111-1307, USA. + * Software Foundation, Inc., 51 Franklin Street, Fifth Floor, + * Boston, MA 02110-1301, USA. */ #pragma once diff --git a/src/rbtree.c b/src/rbtree.c index 4e7c0f3..f0ebb8c 100644 --- a/src/rbtree.c +++ b/src/rbtree.c @@ -15,7 +15,8 @@ You should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software - Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, + MA 02110-1301, USA linux/lib/rbtree.c */ diff --git a/src/select.c b/src/select.c index b0e8b0c..5421c77 100644 --- a/src/select.c +++ b/src/select.c @@ -16,7 +16,8 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, + * MA 02110-1301, USA. */ #include diff --git a/src/vty/buffer.c b/src/vty/buffer.c index e0abe81..8862da9 100644 --- a/src/vty/buffer.c +++ b/src/vty/buffer.c @@ -16,8 +16,8 @@ * * You should have received a copy of the GNU General Public License * along with GNU Zebra; see the file COPYING. If not, write to the - * Free Software Foundation, Inc., 59 Temple Place - Suite 330, - * Boston, MA 02111-1307, USA. + * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, + * Boston, MA 02110-1301, USA. */ #include diff --git a/src/vty/command.c b/src/vty/command.c index 290b12d..149eca3 100644 --- a/src/vty/command.c +++ b/src/vty/command.c @@ -18,8 +18,8 @@ General Public License for more details. You should have received a copy of the GNU General Public License along with GNU Zebra; see the file COPYING. If not, write to the -Free Software Foundation, Inc., 59 Temple Place - Suite 330, -Boston, MA 02111-1307, USA. */ +Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, +Boston, MA 02110-1301, USA. */ #include #include diff --git a/src/vty/vector.c b/src/vty/vector.c index aaff87d..c5a99af 100644 --- a/src/vty/vector.c +++ b/src/vty/vector.c @@ -15,8 +15,8 @@ * * You should have received a copy of the GNU General Public License * along with GNU Zebra; see the file COPYING. If not, write to the Free - * Software Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA - * 02111-1307, USA. + * Software Foundation, Inc., 51 Franklin Street, Fifth Floor, + * Boston, MA 02110-1301, USA. */ #include -- 2.4.3