diff mbox series

Transfer of responsibility with Gerrit's Code-Review -1

Message ID cca1453bf1b9889bc117a2e0088f1c3f0140dd5c.camel@codeconstruct.com.au
State New
Headers show
Series Transfer of responsibility with Gerrit's Code-Review -1 | expand

Commit Message

Andrew Jeffery Oct. 19, 2023, 11:31 p.m. UTC 
Hello,

Recent discussions identified a couple of community concerns:

1. Patches stall in Gerrit with comments that make it unclear who
should take action
2. Scoring patches `Code-Review -1: I would prefer this is not merged
as is` feels overbearing for some types of review

"I would prefer this is not merged as is" does seem like an opportunity
to stall reviews. It opens the door to leaving feedback that doesn't
explain how to improve the change. It's also possible that the
hesitance in the second point leads to the confusion in the first.

After some discussion with Patrick and Zev, I've made the following
tweak to the Gerrit config:

```
```

It's a small change. However, I think it softens the feeling of a Code-
Review -1. Increasing the use of Code-Review -1 may clarify where
responsibility lies for driving the patch forward.

Andrew
diff mbox series

Patch

diff --git a/project.config b/project.config
index 23cb59ecfca8..e2ee9c7691b0 100644
--- a/project.config
+++ b/project.config
@@ -64,7 +64,7 @@ 
     function = MaxWithBlock
     defaultValue = 0
     value = -2 This shall not be merged
-    value = -1 I would prefer this is not merged as is
+    value = -1 Changes should be made to address my concerns
     value = 0 No score
     value = +1 Looks good to me, but someone else must approve
     value = +2 Looks good to me, approved