diff mbox

[13/16] Enable RGMII pin functions in Firestone DT

Message ID 644340813.194637.1473971868909.JavaMail.zimbra@raptorengineeringinc.com
State Superseded, archived
Headers show

Commit Message

Timothy Pearson Sept. 15, 2016, 8:37 p.m. UTC 
---
 arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts |    3 +++
 1 file changed, 3 insertions(+)

Comments

Joel Stanley Sept. 16, 2016, 1:39 a.m. UTC | #1 
On Fri, Sep 16, 2016 at 6:07 AM, Timothy Pearson
<tpearson@raptorengineering.com> wrote:
>

Missing your s-o-b and commit message.

> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> index 053fafe..a2a2ef2 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> @@ -72,6 +72,9 @@
>  &mac0 {
>         status = "okay";
>
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_rgmii1_default>;
> +
>         no-hw-checksum;
>  };
>
> --
> 1.7.9.5
>
> _______________________________________________
> openbmc mailing list
> openbmc@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc
Andrew Jeffery Sept. 16, 2016, 2:20 a.m. UTC | #2 
Subject should probably say for which MAC. Also, you need to add a
Signed-off-by: line (for all of your patches it seems). With that,

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>

On Thu, 2016-09-15 at 15:37 -0500, Timothy Pearson wrote:
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> index 053fafe..a2a2ef2 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> @@ -72,6 +72,9 @@
>  &mac0 {
>  	status = "okay";
>  
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_rgmii1_default>;
> +
>  	no-hw-checksum;
>  };
>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
index 053fafe..a2a2ef2 100644
--- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
@@ -72,6 +72,9 @@ 
 &mac0 {
 	status = "okay";
 
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rgmii1_default>;
+
 	no-hw-checksum;
 };