| Message ID | 20240322081158.4106326-2-kcfeng0@nuvoton.com |
|---|---|
| State | New |
| Headers | show |
| Series | hwmon: Driver for Nuvoton NCT7363Y | expand |
On 3/22/24 02:26, Rob Herring wrote: > > On Fri, 22 Mar 2024 16:11:57 +0800, baneric926@gmail.com wrote: >> From: Ban Feng <kcfeng0@nuvoton.com> >> >> Add bindings for the Nuvoton NCT7363Y Fan Controller >> >> Reviewed-by: Rob Herring <robh@kernel.org> >> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> >> Signed-off-by: Ban Feng <kcfeng0@nuvoton.com> >> --- >> .../bindings/hwmon/nuvoton,nct7363.yaml | 66 +++++++++++++++++++ >> MAINTAINERS | 6 ++ >> 2 files changed, 72 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml: > Error in referenced schema matching $id: http://devicetree.org/schemas/hwmon/fan-common.yaml > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: hwmon@22: fan-0: False schema does not allow {'pwms': [[1, 0, 50000]], 'tach-ch': ['']} > from schema $id: http://devicetree.org/schemas/hwmon/nuvoton,nct7363.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: hwmon@22: fan-0: Unevaluated properties are not allowed ('pwms', 'tach-ch' were unexpected) > from schema $id: http://devicetree.org/schemas/hwmon/nuvoton,nct7363.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: hwmon@22: fan-1: False schema does not allow {'pwms': [[1, 1, 50000]], 'tach-ch': b'\x01'} > from schema $id: http://devicetree.org/schemas/hwmon/nuvoton,nct7363.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: hwmon@22: fan-1: Unevaluated properties are not allowed ('pwms', 'tach-ch' were unexpected) > from schema $id: http://devicetree.org/schemas/hwmon/nuvoton,nct7363.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: fan-1: tach-ch: b'\x01' is not of type 'object', 'array', 'boolean', 'null' > from schema $id: http://devicetree.org/schemas/dt-core.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240322081158.4106326-2-kcfeng0@nuvoton.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > I am a bit puzzled by this one. The patch has a Reviewed-by: tag from Rob, but then Rob's bot complains about errors. hat am I missing ? Thanks, Guenter
Hi Krzysztof, Thanks for your support. Best regards, Ban On Tue, Mar 26, 2024 at 2:29 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 25/03/2024 18:09, Guenter Roeck wrote: > > On 3/22/24 02:26, Rob Herring wrote: > >> > >> On Fri, 22 Mar 2024 16:11:57 +0800, baneric926@gmail.com wrote: > >>> From: Ban Feng <kcfeng0@nuvoton.com> > >>> > >>> Add bindings for the Nuvoton NCT7363Y Fan Controller > >>> > >>> Reviewed-by: Rob Herring <robh@kernel.org> > >>> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> > >>> Signed-off-by: Ban Feng <kcfeng0@nuvoton.com> > >>> --- > >>> .../bindings/hwmon/nuvoton,nct7363.yaml | 66 +++++++++++++++++++ > >>> MAINTAINERS | 6 ++ > >>> 2 files changed, 72 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml > >>> > >> > >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > >> > >> yamllint warnings/errors: > >> > >> dtschema/dtc warnings/errors: > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml: > >> Error in referenced schema matching $id: http://devicetree.org/schemas/hwmon/fan-common.yaml > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: hwmon@22: fan-0: False schema does not allow {'pwms': [[1, 0, 50000]], 'tach-ch': ['']} > >> from schema $id: http://devicetree.org/schemas/hwmon/nuvoton,nct7363.yaml# > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: hwmon@22: fan-0: Unevaluated properties are not allowed ('pwms', 'tach-ch' were unexpected) > >> from schema $id: http://devicetree.org/schemas/hwmon/nuvoton,nct7363.yaml# > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: hwmon@22: fan-1: False schema does not allow {'pwms': [[1, 1, 50000]], 'tach-ch': b'\x01'} > >> from schema $id: http://devicetree.org/schemas/hwmon/nuvoton,nct7363.yaml# > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: hwmon@22: fan-1: Unevaluated properties are not allowed ('pwms', 'tach-ch' were unexpected) > >> from schema $id: http://devicetree.org/schemas/hwmon/nuvoton,nct7363.yaml# > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.example.dtb: fan-1: tach-ch: b'\x01' is not of type 'object', 'array', 'boolean', 'null' > >> from schema $id: http://devicetree.org/schemas/dt-core.yaml# > >> > >> doc reference errors (make refcheckdocs): > >> > >> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240322081158.4106326-2-kcfeng0@nuvoton.com > >> > >> The base for the series is generally the latest rc1. A different dependency > >> should be noted in *this* patch. > >> > >> If you already ran 'make dt_binding_check' and didn't see the above > >> error(s), then make sure 'yamllint' is installed and dt-schema is up to > >> date: > >> > >> pip3 install dtschema --upgrade > >> > >> Please check and re-submit after running the above command yourself. Note > >> that DT_SCHEMA_FILES can be set to your schema file to speed up checking > >> your schema. However, it must be unset to test all examples with your schema. > >> > > > > I am a bit puzzled by this one. The patch has a Reviewed-by: tag from Rob, > > but then Rob's bot complains about errors. hat am I missing ? > > The warning is a result of missing fan-common.yaml in the tree used as a > base. > > I checked now and I don't see warnings on next or v6.9-rc1, so it is > safe for you to apply it. > > For the record: > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml b/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml new file mode 100644 index 000000000000..c1e5dedc2f6a --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml @@ -0,0 +1,66 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: http://devicetree.org/schemas/hwmon/nuvoton,nct7363.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton NCT7363Y Hardware Monitoring IC + +maintainers: + - Ban Feng <kcfeng0@nuvoton.com> + +description: | + The NCT7363Y is a fan controller which provides up to 16 independent + FAN input monitors, and up to 16 independent PWM outputs with SMBus interface. + + Datasheets: Available from Nuvoton upon request + +properties: + compatible: + enum: + - nuvoton,nct7363 + - nuvoton,nct7362 + + reg: + maxItems: 1 + + "#pwm-cells": + const: 2 + +patternProperties: + "^fan-[0-9]+$": + $ref: fan-common.yaml# + unevaluatedProperties: false + required: + - pwms + - tach-ch + +required: + - compatible + - reg + - "#pwm-cells" + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + hwmon: hwmon@22 { + compatible = "nuvoton,nct7363"; + reg = <0x22>; + #pwm-cells = <2>; + + fan-0 { + pwms = <&hwmon 0 50000>; + tach-ch = /bits/ 8 <0x00>; + }; + fan-1 { + pwms = <&hwmon 1 50000>; + tach-ch = /bits/ 8 <0x01>; + }; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index de6a64b248ae..2705e44ffc0c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15216,6 +15216,12 @@ S: Maintained F: Documentation/devicetree/bindings/hwmon/nuvoton,nct6775.yaml F: drivers/hwmon/nct6775-i2c.c +NCT7363 HARDWARE MONITOR DRIVER +M: Ban Feng <kcfeng0@nuvoton.com> +L: linux-hwmon@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/hwmon/nuvoton,nct7363.yaml + NETDEVSIM M: Jakub Kicinski <kuba@kernel.org> S: Maintained