diff mbox series

[4/4] ARM: dts: aspeed: mtmitchell: Add MCTP

Message ID 20230425065715.21871-5-chanh@os.amperecomputing.com
State New
Headers show
Series Update the device tree for Ampere's Mt.Mitchell BMC | expand

Commit Message

Chanh Nguyen April 25, 2023, 6:57 a.m. UTC 
Enable MCTP driver on I2C3 bus for MCTP transaction

Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
---
 arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Andrew Jeffery April 27, 2023, 1:04 a.m. UTC | #1 
On Tue, 25 Apr 2023, at 16:27, Chanh Nguyen wrote:
> Enable MCTP driver on I2C3 bus for MCTP transaction
>
> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts 
> b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
> index 0b5ea8620063..33e06eafed31 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
> @@ -366,6 +366,13 @@
> 
>  &i2c3 {
>  	status = "okay";
> +	bus-frequency = <1000000>;
> +	multi-master;
> +	mctp-controller;
> +	mctp@10 {
> +		compatible = "mctp-i2c-controller";
> +		reg = <0x10>;

This needs to be `reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;`

Andrew
Chanh Nguyen May 7, 2023, 8:31 a.m. UTC | #2 
On 27/04/2023 08:04, Andrew Jeffery wrote:
> 
> 
> On Tue, 25 Apr 2023, at 16:27, Chanh Nguyen wrote:
>> Enable MCTP driver on I2C3 bus for MCTP transaction
>>
>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>> ---
>>   arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> index 0b5ea8620063..33e06eafed31 100644
>> --- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> +++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
>> @@ -366,6 +366,13 @@
>>
>>   &i2c3 {
>>   	status = "okay";
>> +	bus-frequency = <1000000>;
>> +	multi-master;
>> +	mctp-controller;
>> +	mctp@10 {
>> +		compatible = "mctp-i2c-controller";
>> +		reg = <0x10>;
> 
> This needs to be `reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;`
> 
> Andrew

Thank Andrew, I will update that in PATCH v2.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
index 0b5ea8620063..33e06eafed31 100644
--- a/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-ampere-mtmitchell.dts
@@ -366,6 +366,13 @@ 
 
 &i2c3 {
 	status = "okay";
+	bus-frequency = <1000000>;
+	multi-master;
+	mctp-controller;
+	mctp@10 {
+		compatible = "mctp-i2c-controller";
+		reg = <0x10>;
+	};
 };
 
 &i2c4 {