| Message ID | 20220721101556.118568-3-tmaimon77@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | spi: npcm-pspi: add Arbel NPCM8XX and full duplex support | expand |
On Thu, Jul 21, 2022 at 01:15:56PM +0300, Tomer Maimon wrote: > Required properties: > - - compatible : "nuvoton,npcm750-pspi" for NPCM7XX BMC > + - compatible : "nuvoton,npcm750-pspi" for Poleg NPCM7XX. > + "nuvoton,npcm845-pspi" for Arbel NPCM8XX. You've not updated the driver to accept this compatible and this doesn't say anything about fallbacks.
Hi Mark, Thanks for your comment. On Thu, 21 Jul 2022 at 15:09, Mark Brown <broonie@kernel.org> wrote: > > On Thu, Jul 21, 2022 at 01:15:56PM +0300, Tomer Maimon wrote: > > > Required properties: > > - - compatible : "nuvoton,npcm750-pspi" for NPCM7XX BMC > > + - compatible : "nuvoton,npcm750-pspi" for Poleg NPCM7XX. > > + "nuvoton,npcm845-pspi" for Arbel NPCM8XX. > > You've not updated the driver to accept this compatible and this doesn't > say anything about fallbacks. I will make sure to add the compatible to the driver Thanks, Tomer
diff --git a/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt b/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt index b98203ca656d..a4e72e52af59 100644 --- a/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt +++ b/Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt @@ -3,7 +3,8 @@ Nuvoton NPCM Peripheral Serial Peripheral Interface(PSPI) controller driver Nuvoton NPCM7xx SOC support two PSPI channels. Required properties: - - compatible : "nuvoton,npcm750-pspi" for NPCM7XX BMC + - compatible : "nuvoton,npcm750-pspi" for Poleg NPCM7XX. + "nuvoton,npcm845-pspi" for Arbel NPCM8XX. - #address-cells : should be 1. see spi-bus.txt - #size-cells : should be 0. see spi-bus.txt - specifies physical base address and size of the register.
Add a compatible string for Nuvoton BMC NPCM845 PSPI. Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> --- Documentation/devicetree/bindings/spi/nuvoton,npcm-pspi.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)