diff mbox series

[u-boot,v2019.04-aspeed-openbmc] tools: Disable OpenSSL deprecation warnings

Message ID 20220715033327.1053462-1-joel@jms.id.au
State New
Headers show
Series [u-boot,v2019.04-aspeed-openbmc] tools: Disable OpenSSL deprecation warnings | expand

Commit Message

Joel Stanley July 15, 2022, 3:33 a.m. UTC 
mkimage is linked against the host version of OpenSSL. If the distro
happens to be using OpenSSL 3.0 then several warnings about using
depreciated functions will be emitted.

 warning: ‘RSA_get0_key’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]

These functions still work for now, so suppress the warning and delay
the need to move to the new API.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
The backport to move to the newer OpenSSL APIs are complicated. Instead
of focusing on fixing the old branch, work is being done to move to a
newer u-boot base.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 tools/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Paul Menzel July 15, 2022, 7:25 a.m. UTC | #1 
Dear Joel,


Thank you for the patch.

Am 15.07.22 um 05:33 schrieb Joel Stanley:
> mkimage is linked against the host version of OpenSSL. If the distro
> happens to be using OpenSSL 3.0 then several warnings about using
> depreciated functions will be emitted.

sdepreciated/deprecated/

> 
>   warning: ‘RSA_get0_key’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
> 
> These functions still work for now, so suppress the warning and delay
> the need to move to the new API.
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>

[…]

Reviewed-by: Paul Menzel <pmenzel@molgne.mpg.de>


Kind regards,

Paul
Joel Stanley July 18, 2022, 8:31 a.m. UTC | #2 
On Fri, 15 Jul 2022 at 07:25, Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear Joel,
>
>
> Thank you for the patch.
>
> Am 15.07.22 um 05:33 schrieb Joel Stanley:
> > mkimage is linked against the host version of OpenSSL. If the distro
> > happens to be using OpenSSL 3.0 then several warnings about using
> > depreciated functions will be emitted.
>
> sdepreciated/deprecated/
>
> >
> >   warning: ‘RSA_get0_key’ is deprecated: Since OpenSSL 3.0 [-Wdeprecated-declarations]
> >
> > These functions still work for now, so suppress the warning and delay
> > the need to move to the new API.
> >
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
>
> […]
>
> Reviewed-by: Paul Menzel <pmenzel@molgne.mpg.de>

Thanks for the review. I fixed the grammar and committed it.

Cheers,

Joel
diff mbox series

Patch

diff --git a/tools/Makefile b/tools/Makefile
index 81aa374a32dd..9e7a8e85435d 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -159,10 +159,12 @@  HOSTLOADLIBES_mkimage += \
 ifeq ($(HOSTOS),darwin)
 HOSTCFLAGS_mxsimage.o += -Wno-deprecated-declarations
 HOSTCFLAGS_image-sig.o += -Wno-deprecated-declarations
-HOSTCFLAGS_rsa-sign.o += -Wno-deprecated-declarations
 endif
 endif
 
+# Disable warnings on systems with OpenSSL 3.0
+HOSTCFLAGS_rsa-sign.o += -Wno-deprecated-declarations
+
 HOSTCFLAGS_fit_image.o += -DMKIMAGE_DTC=\"$(CONFIG_MKIMAGE_DTC_PATH)\"
 
 HOSTLOADLIBES_dumpimage := $(HOSTLOADLIBES_mkimage)