[u-boot,v2019.04-aspeed-openbmc,1/3] configs: ast2600: add Qualcomm DC-SCM V1 defconfig

Add Qualcomm DC-SCM V1 defconfig which is equipped with AST2600.

Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
---
 configs/ast2600_qcom_dc_scm_v1_defconfig | 117 +++++++++++++++++++++++
 1 file changed, 117 insertions(+)
 create mode 100644 configs/ast2600_qcom_dc_scm_v1_defconfig

On Thu, 30 Jun 2022 at 20:02, Jae Hyun Yoo <quic_jaehyoo@quicinc.com> wrote:
>
> Add Qualcomm DC-SCM V1 defconfig which is equipped with AST2600.

In your commit message you need to justify why your board needs its
own defconfig.

Preferably we would use a generic openbmc defconfig and you select the
device tree for your board at build time.

>
> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
> ---
>  configs/ast2600_qcom_dc_scm_v1_defconfig | 117 +++++++++++++++++++++++
>  1 file changed, 117 insertions(+)
>  create mode 100644 configs/ast2600_qcom_dc_scm_v1_defconfig
>
> diff --git a/configs/ast2600_qcom_dc_scm_v1_defconfig b/configs/ast2600_qcom_dc_scm_v1_defconfig
> new file mode 100644
> index 000000000000..353882deed26
> --- /dev/null
> +++ b/configs/ast2600_qcom_dc_scm_v1_defconfig
> @@ -0,0 +1,117 @@
> +CONFIG_ARM=y
> +CONFIG_SYS_DCACHE_OFF=y
> +CONFIG_ARCH_ASPEED=y
> +CONFIG_SYS_TEXT_BASE=0x0
> +CONFIG_ASPEED_AST2600=y
> +CONFIG_TARGET_AST2600_QUALCOMM_DC_SCM_V1=y
> +CONFIG_SYS_MALLOC_F_LEN=0x800
> +CONFIG_ENV_SIZE=0x10000
> +CONFIG_ENV_OFFSET=0xE0000
> +CONFIG_ARMV7_BOOT_SEC_DEFAULT=y
> +CONFIG_NR_DRAM_BANKS=1
> +CONFIG_FIT=y
> +CONFIG_USE_BOOTARGS=y
> +CONFIG_BOOTARGS="console=ttyS4,115200n8 root=/dev/ram rw"
> +CONFIG_USE_BOOTCOMMAND=y
> +CONFIG_BOOTCOMMAND="bootm 20100000"
> +CONFIG_SYS_CONSOLE_ENV_OVERWRITE=y
> +CONFIG_BOARD_LATE_INIT=y
> +CONFIG_DISPLAY_BOARDINFO_LATE=y
> +CONFIG_ARCH_EARLY_INIT_R=y
> +CONFIG_BOARD_EARLY_INIT_F=y
> +CONFIG_HUSH_PARSER=y
> +# CONFIG_AUTO_COMPLETE is not set
> +CONFIG_SYS_PROMPT="ast# "
> +CONFIG_CMD_BOOTZ=y
> +# CONFIG_CMD_BOOTEFI is not set
> +# CONFIG_CMD_ELF is not set
> +# CONFIG_CMD_IMI is not set
> +# CONFIG_CMD_XIMG is not set
> +# CONFIG_CMD_NVEDIT_EFI is not set
> +CONFIG_CMD_CRC32=y
> +CONFIG_CRC32_VERIFY=y
> +# CONFIG_LOOPW is not set
> +CONFIG_CMD_MD5SUM=y
> +CONFIG_MD5SUM_VERIFY=y
> +CONFIG_CMD_MEMINFO=y
> +CONFIG_CMD_MEMORY=y
> +CONFIG_CMD_MEMTEST=y
> +CONFIG_SYS_ALT_MEMTEST=y
> +CONFIG_CMD_MX_CYCLIC=y
> +CONFIG_CMD_SHA1SUM=y
> +CONFIG_SHA1SUM_VERIFY=y
> +CONFIG_CMD_STRINGS=y
> +CONFIG_CMD_CLK=y
> +CONFIG_CMD_GPIO=y
> +CONFIG_CMD_I2C=y
> +CONFIG_CMD_MMC=y
> +CONFIG_CMD_PART=y
> +CONFIG_CMD_PCI=y
> +CONFIG_CMD_SF=y
> +CONFIG_CMD_USB=y
> +CONFIG_CMD_DHCP=y
> +CONFIG_CMD_MII=y
> +CONFIG_CMD_PING=y
> +CONFIG_CMD_NCSI=y
> +CONFIG_CMD_EXT2=y
> +CONFIG_CMD_EXT4=y
> +CONFIG_CMD_EXT4_WRITE=y
> +CONFIG_CMD_FAT=y
> +CONFIG_CMD_FS_GENERIC=y
> +CONFIG_CMD_MTDPARTS=y
> +CONFIG_EFI_PARTITION=y
> +CONFIG_ENV_IS_IN_SPI_FLASH=y
> +CONFIG_USE_ENV_SPI_BUS=y
> +CONFIG_ENV_SPI_BUS=0
> +CONFIG_USE_ENV_SPI_CS=y
> +CONFIG_ENV_SPI_CS=0
> +CONFIG_USE_ENV_SPI_MAX_HZ=y
> +CONFIG_ENV_SPI_MAX_HZ=100000000
> +CONFIG_NET_RANDOM_ETHADDR=y
> +CONFIG_REGMAP=y
> +CONFIG_SYSCON=y
> +CONFIG_CLK=y
> +CONFIG_DM_GPIO=y
> +CONFIG_ASPEED_GPIO=y
> +CONFIG_DM_I2C=y
> +CONFIG_SYS_I2C_ASPEED=y
> +CONFIG_MISC=y
> +CONFIG_ASPEED_AHBC=y
> +CONFIG_ASPEED_H2X=y
> +CONFIG_DM_MMC=y
> +CONFIG_MMC_SDHCI=y
> +CONFIG_MMC_SDHCI_ASPEED=y
> +CONFIG_DM_SPI_FLASH=y
> +CONFIG_SPI_FLASH=y
> +CONFIG_SPI_FLASH_GIGADEVICE=y
> +CONFIG_SPI_FLASH_MACRONIX=y
> +CONFIG_SPI_FLASH_SPANSION=y
> +CONFIG_SPI_FLASH_STMICRO=y
> +CONFIG_SPI_FLASH_WINBOND=y
> +CONFIG_PHY_BROADCOM=y
> +CONFIG_PHY_MICREL=y
> +CONFIG_PHY_MICREL_KSZ90X1=y
> +CONFIG_PHY_REALTEK=y
> +CONFIG_PHY_NCSI=y
> +CONFIG_DM_ETH=y
> +CONFIG_PHY_GIGE=y
> +CONFIG_FTGMAC100=y
> +CONFIG_MDIO=y
> +CONFIG_PCI=y
> +CONFIG_DM_PCI=y
> +CONFIG_PCIE_ASPEED=y
> +CONFIG_PHY=y
> +CONFIG_PINCTRL=y
> +CONFIG_RAM=y
> +CONFIG_DM_SERIAL=y
> +CONFIG_SYS_NS16550=y
> +CONFIG_SPI=y
> +CONFIG_DM_SPI=y
> +CONFIG_SYSRESET=y
> +CONFIG_USB=y
> +CONFIG_DM_USB=y
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_STORAGE=y
> +CONFIG_WDT=y
> +CONFIG_HEXDUMP=y
> +# CONFIG_GENERATE_SMBIOS_TABLE is not set
> --
> 2.25.1
>

Hello Joel,

On 7/4/2022 11:47 PM, Joel Stanley wrote:
> On Thu, 30 Jun 2022 at 20:02, Jae Hyun Yoo <quic_jaehyoo@quicinc.com> wrote:
>>
>> Add Qualcomm DC-SCM V1 defconfig which is equipped with AST2600.
> 
> In your commit message you need to justify why your board needs its
> own defconfig.
> 
> Preferably we would use a generic openbmc defconfig and you select the
> device tree for your board at build time.

I expected 'ast2600_openbmc_defconfig' could be used for my non-spl
u-boot but currently the file has been modified for SPL boot too so both
'ast2600_openbmc_defconfig' and 'ast2600_openbmc_spl_defconfig' have SPL
boot configs. Since the 'ast2600_openbmc_defconfig' is being used for
other machines, I can't change the file directly for non-spl defconfig
so it's the reason why I'm trying to upstream this machine specific
defconfig.

Should I use a patch file in 'openbmc/meta-qualcomm/recipe-bsp' to
modify the 'ast2600_openbmc_defconfig' at build time instead?

Thanks,
Jae

>>
>> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
>> ---
>>   configs/ast2600_qcom_dc_scm_v1_defconfig | 117 +++++++++++++++++++++++
>>   1 file changed, 117 insertions(+)
>>   create mode 100644 configs/ast2600_qcom_dc_scm_v1_defconfig
>>
>> diff --git a/configs/ast2600_qcom_dc_scm_v1_defconfig b/configs/ast2600_qcom_dc_scm_v1_defconfig
>> new file mode 100644
>> index 000000000000..353882deed26
>> --- /dev/null
>> +++ b/configs/ast2600_qcom_dc_scm_v1_defconfig
>> @@ -0,0 +1,117 @@
>> +CONFIG_ARM=y
>> +CONFIG_SYS_DCACHE_OFF=y
>> +CONFIG_ARCH_ASPEED=y
>> +CONFIG_SYS_TEXT_BASE=0x0
>> +CONFIG_ASPEED_AST2600=y
>> +CONFIG_TARGET_AST2600_QUALCOMM_DC_SCM_V1=y
>> +CONFIG_SYS_MALLOC_F_LEN=0x800
>> +CONFIG_ENV_SIZE=0x10000
>> +CONFIG_ENV_OFFSET=0xE0000
>> +CONFIG_ARMV7_BOOT_SEC_DEFAULT=y
>> +CONFIG_NR_DRAM_BANKS=1
>> +CONFIG_FIT=y
>> +CONFIG_USE_BOOTARGS=y
>> +CONFIG_BOOTARGS="console=ttyS4,115200n8 root=/dev/ram rw"
>> +CONFIG_USE_BOOTCOMMAND=y
>> +CONFIG_BOOTCOMMAND="bootm 20100000"
>> +CONFIG_SYS_CONSOLE_ENV_OVERWRITE=y
>> +CONFIG_BOARD_LATE_INIT=y
>> +CONFIG_DISPLAY_BOARDINFO_LATE=y
>> +CONFIG_ARCH_EARLY_INIT_R=y
>> +CONFIG_BOARD_EARLY_INIT_F=y
>> +CONFIG_HUSH_PARSER=y
>> +# CONFIG_AUTO_COMPLETE is not set
>> +CONFIG_SYS_PROMPT="ast# "
>> +CONFIG_CMD_BOOTZ=y
>> +# CONFIG_CMD_BOOTEFI is not set
>> +# CONFIG_CMD_ELF is not set
>> +# CONFIG_CMD_IMI is not set
>> +# CONFIG_CMD_XIMG is not set
>> +# CONFIG_CMD_NVEDIT_EFI is not set
>> +CONFIG_CMD_CRC32=y
>> +CONFIG_CRC32_VERIFY=y
>> +# CONFIG_LOOPW is not set
>> +CONFIG_CMD_MD5SUM=y
>> +CONFIG_MD5SUM_VERIFY=y
>> +CONFIG_CMD_MEMINFO=y
>> +CONFIG_CMD_MEMORY=y
>> +CONFIG_CMD_MEMTEST=y
>> +CONFIG_SYS_ALT_MEMTEST=y
>> +CONFIG_CMD_MX_CYCLIC=y
>> +CONFIG_CMD_SHA1SUM=y
>> +CONFIG_SHA1SUM_VERIFY=y
>> +CONFIG_CMD_STRINGS=y
>> +CONFIG_CMD_CLK=y
>> +CONFIG_CMD_GPIO=y
>> +CONFIG_CMD_I2C=y
>> +CONFIG_CMD_MMC=y
>> +CONFIG_CMD_PART=y
>> +CONFIG_CMD_PCI=y
>> +CONFIG_CMD_SF=y
>> +CONFIG_CMD_USB=y
>> +CONFIG_CMD_DHCP=y
>> +CONFIG_CMD_MII=y
>> +CONFIG_CMD_PING=y
>> +CONFIG_CMD_NCSI=y
>> +CONFIG_CMD_EXT2=y
>> +CONFIG_CMD_EXT4=y
>> +CONFIG_CMD_EXT4_WRITE=y
>> +CONFIG_CMD_FAT=y
>> +CONFIG_CMD_FS_GENERIC=y
>> +CONFIG_CMD_MTDPARTS=y
>> +CONFIG_EFI_PARTITION=y
>> +CONFIG_ENV_IS_IN_SPI_FLASH=y
>> +CONFIG_USE_ENV_SPI_BUS=y
>> +CONFIG_ENV_SPI_BUS=0
>> +CONFIG_USE_ENV_SPI_CS=y
>> +CONFIG_ENV_SPI_CS=0
>> +CONFIG_USE_ENV_SPI_MAX_HZ=y
>> +CONFIG_ENV_SPI_MAX_HZ=100000000
>> +CONFIG_NET_RANDOM_ETHADDR=y
>> +CONFIG_REGMAP=y
>> +CONFIG_SYSCON=y
>> +CONFIG_CLK=y
>> +CONFIG_DM_GPIO=y
>> +CONFIG_ASPEED_GPIO=y
>> +CONFIG_DM_I2C=y
>> +CONFIG_SYS_I2C_ASPEED=y
>> +CONFIG_MISC=y
>> +CONFIG_ASPEED_AHBC=y
>> +CONFIG_ASPEED_H2X=y
>> +CONFIG_DM_MMC=y
>> +CONFIG_MMC_SDHCI=y
>> +CONFIG_MMC_SDHCI_ASPEED=y
>> +CONFIG_DM_SPI_FLASH=y
>> +CONFIG_SPI_FLASH=y
>> +CONFIG_SPI_FLASH_GIGADEVICE=y
>> +CONFIG_SPI_FLASH_MACRONIX=y
>> +CONFIG_SPI_FLASH_SPANSION=y
>> +CONFIG_SPI_FLASH_STMICRO=y
>> +CONFIG_SPI_FLASH_WINBOND=y
>> +CONFIG_PHY_BROADCOM=y
>> +CONFIG_PHY_MICREL=y
>> +CONFIG_PHY_MICREL_KSZ90X1=y
>> +CONFIG_PHY_REALTEK=y
>> +CONFIG_PHY_NCSI=y
>> +CONFIG_DM_ETH=y
>> +CONFIG_PHY_GIGE=y
>> +CONFIG_FTGMAC100=y
>> +CONFIG_MDIO=y
>> +CONFIG_PCI=y
>> +CONFIG_DM_PCI=y
>> +CONFIG_PCIE_ASPEED=y
>> +CONFIG_PHY=y
>> +CONFIG_PINCTRL=y
>> +CONFIG_RAM=y
>> +CONFIG_DM_SERIAL=y
>> +CONFIG_SYS_NS16550=y
>> +CONFIG_SPI=y
>> +CONFIG_DM_SPI=y
>> +CONFIG_SYSRESET=y
>> +CONFIG_USB=y
>> +CONFIG_DM_USB=y
>> +CONFIG_USB_EHCI_HCD=y
>> +CONFIG_USB_STORAGE=y
>> +CONFIG_WDT=y
>> +CONFIG_HEXDUMP=y
>> +# CONFIG_GENERATE_SMBIOS_TABLE is not set
>> --
>> 2.25.1
>>

On Tue, 5 Jul 2022 at 14:18, Jae Hyun Yoo <quic_jaehyoo@quicinc.com> wrote:
>
> Hello Joel,
>
> On 7/4/2022 11:47 PM, Joel Stanley wrote:
> > On Thu, 30 Jun 2022 at 20:02, Jae Hyun Yoo <quic_jaehyoo@quicinc.com> wrote:
> >>
> >> Add Qualcomm DC-SCM V1 defconfig which is equipped with AST2600.
> >
> > In your commit message you need to justify why your board needs its
> > own defconfig.
> >
> > Preferably we would use a generic openbmc defconfig and you select the
> > device tree for your board at build time.
>
> I expected 'ast2600_openbmc_defconfig' could be used for my non-spl
> u-boot but currently the file has been modified for SPL boot too so both
> 'ast2600_openbmc_defconfig' and 'ast2600_openbmc_spl_defconfig' have SPL
> boot configs. Since the 'ast2600_openbmc_defconfig' is being used for
> other machines, I can't change the file directly for non-spl defconfig
> so it's the reason why I'm trying to upstream this machine specific
> defconfig.

Okay. That's suspicious, if there's a requirement to have non-SPL then
we should revert the change that added SPL to the non-SPL config.

Alternatively, could you use the SPL configuration for your board?
This would simplify testing, as we would only need to verify that the
SPL build works for the 2600 when making u-boot changes.

>
> Should I use a patch file in 'openbmc/meta-qualcomm/recipe-bsp' to
> modify the 'ast2600_openbmc_defconfig' at build time instead?

That's an option, but this would limit testing coverage, as we would
only build that configuration when doing an OpenBMC image build.

>
> Thanks,
> Jae
>
> >>
> >> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
> >> ---
> >>   configs/ast2600_qcom_dc_scm_v1_defconfig | 117 +++++++++++++++++++++++
> >>   1 file changed, 117 insertions(+)
> >>   create mode 100644 configs/ast2600_qcom_dc_scm_v1_defconfig
> >>
> >> diff --git a/configs/ast2600_qcom_dc_scm_v1_defconfig b/configs/ast2600_qcom_dc_scm_v1_defconfig
> >> new file mode 100644
> >> index 000000000000..353882deed26
> >> --- /dev/null
> >> +++ b/configs/ast2600_qcom_dc_scm_v1_defconfig
> >> @@ -0,0 +1,117 @@
> >> +CONFIG_ARM=y
> >> +CONFIG_SYS_DCACHE_OFF=y
> >> +CONFIG_ARCH_ASPEED=y
> >> +CONFIG_SYS_TEXT_BASE=0x0
> >> +CONFIG_ASPEED_AST2600=y
> >> +CONFIG_TARGET_AST2600_QUALCOMM_DC_SCM_V1=y
> >> +CONFIG_SYS_MALLOC_F_LEN=0x800
> >> +CONFIG_ENV_SIZE=0x10000
> >> +CONFIG_ENV_OFFSET=0xE0000
> >> +CONFIG_ARMV7_BOOT_SEC_DEFAULT=y
> >> +CONFIG_NR_DRAM_BANKS=1
> >> +CONFIG_FIT=y
> >> +CONFIG_USE_BOOTARGS=y
> >> +CONFIG_BOOTARGS="console=ttyS4,115200n8 root=/dev/ram rw"
> >> +CONFIG_USE_BOOTCOMMAND=y
> >> +CONFIG_BOOTCOMMAND="bootm 20100000"
> >> +CONFIG_SYS_CONSOLE_ENV_OVERWRITE=y
> >> +CONFIG_BOARD_LATE_INIT=y
> >> +CONFIG_DISPLAY_BOARDINFO_LATE=y
> >> +CONFIG_ARCH_EARLY_INIT_R=y
> >> +CONFIG_BOARD_EARLY_INIT_F=y
> >> +CONFIG_HUSH_PARSER=y
> >> +# CONFIG_AUTO_COMPLETE is not set
> >> +CONFIG_SYS_PROMPT="ast# "
> >> +CONFIG_CMD_BOOTZ=y
> >> +# CONFIG_CMD_BOOTEFI is not set
> >> +# CONFIG_CMD_ELF is not set
> >> +# CONFIG_CMD_IMI is not set
> >> +# CONFIG_CMD_XIMG is not set
> >> +# CONFIG_CMD_NVEDIT_EFI is not set
> >> +CONFIG_CMD_CRC32=y
> >> +CONFIG_CRC32_VERIFY=y
> >> +# CONFIG_LOOPW is not set
> >> +CONFIG_CMD_MD5SUM=y
> >> +CONFIG_MD5SUM_VERIFY=y
> >> +CONFIG_CMD_MEMINFO=y
> >> +CONFIG_CMD_MEMORY=y
> >> +CONFIG_CMD_MEMTEST=y
> >> +CONFIG_SYS_ALT_MEMTEST=y
> >> +CONFIG_CMD_MX_CYCLIC=y
> >> +CONFIG_CMD_SHA1SUM=y
> >> +CONFIG_SHA1SUM_VERIFY=y
> >> +CONFIG_CMD_STRINGS=y
> >> +CONFIG_CMD_CLK=y
> >> +CONFIG_CMD_GPIO=y
> >> +CONFIG_CMD_I2C=y
> >> +CONFIG_CMD_MMC=y
> >> +CONFIG_CMD_PART=y
> >> +CONFIG_CMD_PCI=y
> >> +CONFIG_CMD_SF=y
> >> +CONFIG_CMD_USB=y
> >> +CONFIG_CMD_DHCP=y
> >> +CONFIG_CMD_MII=y
> >> +CONFIG_CMD_PING=y
> >> +CONFIG_CMD_NCSI=y
> >> +CONFIG_CMD_EXT2=y
> >> +CONFIG_CMD_EXT4=y
> >> +CONFIG_CMD_EXT4_WRITE=y
> >> +CONFIG_CMD_FAT=y
> >> +CONFIG_CMD_FS_GENERIC=y
> >> +CONFIG_CMD_MTDPARTS=y
> >> +CONFIG_EFI_PARTITION=y
> >> +CONFIG_ENV_IS_IN_SPI_FLASH=y
> >> +CONFIG_USE_ENV_SPI_BUS=y
> >> +CONFIG_ENV_SPI_BUS=0
> >> +CONFIG_USE_ENV_SPI_CS=y
> >> +CONFIG_ENV_SPI_CS=0
> >> +CONFIG_USE_ENV_SPI_MAX_HZ=y
> >> +CONFIG_ENV_SPI_MAX_HZ=100000000
> >> +CONFIG_NET_RANDOM_ETHADDR=y
> >> +CONFIG_REGMAP=y
> >> +CONFIG_SYSCON=y
> >> +CONFIG_CLK=y
> >> +CONFIG_DM_GPIO=y
> >> +CONFIG_ASPEED_GPIO=y
> >> +CONFIG_DM_I2C=y
> >> +CONFIG_SYS_I2C_ASPEED=y
> >> +CONFIG_MISC=y
> >> +CONFIG_ASPEED_AHBC=y
> >> +CONFIG_ASPEED_H2X=y
> >> +CONFIG_DM_MMC=y
> >> +CONFIG_MMC_SDHCI=y
> >> +CONFIG_MMC_SDHCI_ASPEED=y
> >> +CONFIG_DM_SPI_FLASH=y
> >> +CONFIG_SPI_FLASH=y
> >> +CONFIG_SPI_FLASH_GIGADEVICE=y
> >> +CONFIG_SPI_FLASH_MACRONIX=y
> >> +CONFIG_SPI_FLASH_SPANSION=y
> >> +CONFIG_SPI_FLASH_STMICRO=y
> >> +CONFIG_SPI_FLASH_WINBOND=y
> >> +CONFIG_PHY_BROADCOM=y
> >> +CONFIG_PHY_MICREL=y
> >> +CONFIG_PHY_MICREL_KSZ90X1=y
> >> +CONFIG_PHY_REALTEK=y
> >> +CONFIG_PHY_NCSI=y
> >> +CONFIG_DM_ETH=y
> >> +CONFIG_PHY_GIGE=y
> >> +CONFIG_FTGMAC100=y
> >> +CONFIG_MDIO=y
> >> +CONFIG_PCI=y
> >> +CONFIG_DM_PCI=y
> >> +CONFIG_PCIE_ASPEED=y
> >> +CONFIG_PHY=y
> >> +CONFIG_PINCTRL=y
> >> +CONFIG_RAM=y
> >> +CONFIG_DM_SERIAL=y
> >> +CONFIG_SYS_NS16550=y
> >> +CONFIG_SPI=y
> >> +CONFIG_DM_SPI=y
> >> +CONFIG_SYSRESET=y
> >> +CONFIG_USB=y
> >> +CONFIG_DM_USB=y
> >> +CONFIG_USB_EHCI_HCD=y
> >> +CONFIG_USB_STORAGE=y
> >> +CONFIG_WDT=y
> >> +CONFIG_HEXDUMP=y
> >> +# CONFIG_GENERATE_SMBIOS_TABLE is not set
> >> --
> >> 2.25.1
> >>

On 7/5/2022 6:02 PM, Joel Stanley wrote:
> On Tue, 5 Jul 2022 at 14:18, Jae Hyun Yoo <quic_jaehyoo@quicinc.com> wrote:
>>
>> Hello Joel,
>>
>> On 7/4/2022 11:47 PM, Joel Stanley wrote:
>>> On Thu, 30 Jun 2022 at 20:02, Jae Hyun Yoo <quic_jaehyoo@quicinc.com> wrote:
>>>>
>>>> Add Qualcomm DC-SCM V1 defconfig which is equipped with AST2600.
>>>
>>> In your commit message you need to justify why your board needs its
>>> own defconfig.
>>>
>>> Preferably we would use a generic openbmc defconfig and you select the
>>> device tree for your board at build time.
>>
>> I expected 'ast2600_openbmc_defconfig' could be used for my non-spl
>> u-boot but currently the file has been modified for SPL boot too so both
>> 'ast2600_openbmc_defconfig' and 'ast2600_openbmc_spl_defconfig' have SPL
>> boot configs. Since the 'ast2600_openbmc_defconfig' is being used for
>> other machines, I can't change the file directly for non-spl defconfig
>> so it's the reason why I'm trying to upstream this machine specific
>> defconfig.
> 
> Okay. That's suspicious, if there's a requirement to have non-SPL then
> we should revert the change that added SPL to the non-SPL config.
> 
> Alternatively, could you use the SPL configuration for your board?
> This would simplify testing, as we would only need to verify that the
> SPL build works for the 2600 when making u-boot changes.

Okay, I'll change my u-boot to make it run on the SPL configs.

>>
>> Should I use a patch file in 'openbmc/meta-qualcomm/recipe-bsp' to
>> modify the 'ast2600_openbmc_defconfig' at build time instead?
> 
> That's an option, but this would limit testing coverage, as we would
> only build that configuration when doing an OpenBMC image build.

To apply board specific configuration without regarding to the OpenBMC
image build, we need to add a board specific defconfig so that u-boot
standalone build itself can have the configuration, but looks like
there is no case of any Aspeed BMC board defconfig other than Aspeed
EVBs and OpenBMC reference defconfigs in the u-boot tree. I'll add
minimized configuration overrides in the 'recipes-bsp' layer for this
machine build for now.

Thanks,
Jae

>>
>> Thanks,
>> Jae
>>
>>>>
>>>> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
>>>> ---
>>>>    configs/ast2600_qcom_dc_scm_v1_defconfig | 117 +++++++++++++++++++++++
>>>>    1 file changed, 117 insertions(+)
>>>>    create mode 100644 configs/ast2600_qcom_dc_scm_v1_defconfig
>>>>
>>>> diff --git a/configs/ast2600_qcom_dc_scm_v1_defconfig b/configs/ast2600_qcom_dc_scm_v1_defconfig
>>>> new file mode 100644
>>>> index 000000000000..353882deed26
>>>> --- /dev/null
>>>> +++ b/configs/ast2600_qcom_dc_scm_v1_defconfig
>>>> @@ -0,0 +1,117 @@
>>>> +CONFIG_ARM=y
>>>> +CONFIG_SYS_DCACHE_OFF=y
>>>> +CONFIG_ARCH_ASPEED=y
>>>> +CONFIG_SYS_TEXT_BASE=0x0
>>>> +CONFIG_ASPEED_AST2600=y
>>>> +CONFIG_TARGET_AST2600_QUALCOMM_DC_SCM_V1=y
>>>> +CONFIG_SYS_MALLOC_F_LEN=0x800
>>>> +CONFIG_ENV_SIZE=0x10000
>>>> +CONFIG_ENV_OFFSET=0xE0000
>>>> +CONFIG_ARMV7_BOOT_SEC_DEFAULT=y
>>>> +CONFIG_NR_DRAM_BANKS=1
>>>> +CONFIG_FIT=y
>>>> +CONFIG_USE_BOOTARGS=y
>>>> +CONFIG_BOOTARGS="console=ttyS4,115200n8 root=/dev/ram rw"
>>>> +CONFIG_USE_BOOTCOMMAND=y
>>>> +CONFIG_BOOTCOMMAND="bootm 20100000"
>>>> +CONFIG_SYS_CONSOLE_ENV_OVERWRITE=y
>>>> +CONFIG_BOARD_LATE_INIT=y
>>>> +CONFIG_DISPLAY_BOARDINFO_LATE=y
>>>> +CONFIG_ARCH_EARLY_INIT_R=y
>>>> +CONFIG_BOARD_EARLY_INIT_F=y
>>>> +CONFIG_HUSH_PARSER=y
>>>> +# CONFIG_AUTO_COMPLETE is not set
>>>> +CONFIG_SYS_PROMPT="ast# "
>>>> +CONFIG_CMD_BOOTZ=y
>>>> +# CONFIG_CMD_BOOTEFI is not set
>>>> +# CONFIG_CMD_ELF is not set
>>>> +# CONFIG_CMD_IMI is not set
>>>> +# CONFIG_CMD_XIMG is not set
>>>> +# CONFIG_CMD_NVEDIT_EFI is not set
>>>> +CONFIG_CMD_CRC32=y
>>>> +CONFIG_CRC32_VERIFY=y
>>>> +# CONFIG_LOOPW is not set
>>>> +CONFIG_CMD_MD5SUM=y
>>>> +CONFIG_MD5SUM_VERIFY=y
>>>> +CONFIG_CMD_MEMINFO=y
>>>> +CONFIG_CMD_MEMORY=y
>>>> +CONFIG_CMD_MEMTEST=y
>>>> +CONFIG_SYS_ALT_MEMTEST=y
>>>> +CONFIG_CMD_MX_CYCLIC=y
>>>> +CONFIG_CMD_SHA1SUM=y
>>>> +CONFIG_SHA1SUM_VERIFY=y
>>>> +CONFIG_CMD_STRINGS=y
>>>> +CONFIG_CMD_CLK=y
>>>> +CONFIG_CMD_GPIO=y
>>>> +CONFIG_CMD_I2C=y
>>>> +CONFIG_CMD_MMC=y
>>>> +CONFIG_CMD_PART=y
>>>> +CONFIG_CMD_PCI=y
>>>> +CONFIG_CMD_SF=y
>>>> +CONFIG_CMD_USB=y
>>>> +CONFIG_CMD_DHCP=y
>>>> +CONFIG_CMD_MII=y
>>>> +CONFIG_CMD_PING=y
>>>> +CONFIG_CMD_NCSI=y
>>>> +CONFIG_CMD_EXT2=y
>>>> +CONFIG_CMD_EXT4=y
>>>> +CONFIG_CMD_EXT4_WRITE=y
>>>> +CONFIG_CMD_FAT=y
>>>> +CONFIG_CMD_FS_GENERIC=y
>>>> +CONFIG_CMD_MTDPARTS=y
>>>> +CONFIG_EFI_PARTITION=y
>>>> +CONFIG_ENV_IS_IN_SPI_FLASH=y
>>>> +CONFIG_USE_ENV_SPI_BUS=y
>>>> +CONFIG_ENV_SPI_BUS=0
>>>> +CONFIG_USE_ENV_SPI_CS=y
>>>> +CONFIG_ENV_SPI_CS=0
>>>> +CONFIG_USE_ENV_SPI_MAX_HZ=y
>>>> +CONFIG_ENV_SPI_MAX_HZ=100000000
>>>> +CONFIG_NET_RANDOM_ETHADDR=y
>>>> +CONFIG_REGMAP=y
>>>> +CONFIG_SYSCON=y
>>>> +CONFIG_CLK=y
>>>> +CONFIG_DM_GPIO=y
>>>> +CONFIG_ASPEED_GPIO=y
>>>> +CONFIG_DM_I2C=y
>>>> +CONFIG_SYS_I2C_ASPEED=y
>>>> +CONFIG_MISC=y
>>>> +CONFIG_ASPEED_AHBC=y
>>>> +CONFIG_ASPEED_H2X=y
>>>> +CONFIG_DM_MMC=y
>>>> +CONFIG_MMC_SDHCI=y
>>>> +CONFIG_MMC_SDHCI_ASPEED=y
>>>> +CONFIG_DM_SPI_FLASH=y
>>>> +CONFIG_SPI_FLASH=y
>>>> +CONFIG_SPI_FLASH_GIGADEVICE=y
>>>> +CONFIG_SPI_FLASH_MACRONIX=y
>>>> +CONFIG_SPI_FLASH_SPANSION=y
>>>> +CONFIG_SPI_FLASH_STMICRO=y
>>>> +CONFIG_SPI_FLASH_WINBOND=y
>>>> +CONFIG_PHY_BROADCOM=y
>>>> +CONFIG_PHY_MICREL=y
>>>> +CONFIG_PHY_MICREL_KSZ90X1=y
>>>> +CONFIG_PHY_REALTEK=y
>>>> +CONFIG_PHY_NCSI=y
>>>> +CONFIG_DM_ETH=y
>>>> +CONFIG_PHY_GIGE=y
>>>> +CONFIG_FTGMAC100=y
>>>> +CONFIG_MDIO=y
>>>> +CONFIG_PCI=y
>>>> +CONFIG_DM_PCI=y
>>>> +CONFIG_PCIE_ASPEED=y
>>>> +CONFIG_PHY=y
>>>> +CONFIG_PINCTRL=y
>>>> +CONFIG_RAM=y
>>>> +CONFIG_DM_SERIAL=y
>>>> +CONFIG_SYS_NS16550=y
>>>> +CONFIG_SPI=y
>>>> +CONFIG_DM_SPI=y
>>>> +CONFIG_SYSRESET=y
>>>> +CONFIG_USB=y
>>>> +CONFIG_DM_USB=y
>>>> +CONFIG_USB_EHCI_HCD=y
>>>> +CONFIG_USB_STORAGE=y
>>>> +CONFIG_WDT=y
>>>> +CONFIG_HEXDUMP=y
>>>> +# CONFIG_GENERATE_SMBIOS_TABLE is not set
>>>> --
>>>> 2.25.1
>>>>

On Wed, 6 Jul 2022 at 14:52, Jae Hyun Yoo <quic_jaehyoo@quicinc.com> wrote:
>
> On 7/5/2022 6:02 PM, Joel Stanley wrote:

> > That's an option, but this would limit testing coverage, as we would
> > only build that configuration when doing an OpenBMC image build.
>
> To apply board specific configuration without regarding to the OpenBMC
> image build, we need to add a board specific defconfig so that u-boot
> standalone build itself can have the configuration, but looks like
> there is no case of any Aspeed BMC board defconfig other than Aspeed
> EVBs and OpenBMC reference defconfigs in the u-boot tree. I'll add
> minimized configuration overrides in the 'recipes-bsp' layer for this
> machine build for now.

That's a good plan. We could consider adding some bitbake machinery
for this, where the machine type can be specified and bitbake will set
that config option for you.