| Message ID | 20220527141246.21704-1-eajames@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [u-boot,v2019.04-aspeed-openbmc] arm: dts: ast2600: Add I2C pinctrl | expand |
On Fri, 27 May 2022 at 14:12, Eddie James <eajames@linux.ibm.com> wrote: > > Set the pinctrl groups for each I2C bus. These are essential to > I2C operating correctly. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> Thanks, I've applied this. It should also be sent upstream when you get a chance. Cheers, Joel > --- > arch/arm/dts/ast2600.dtsi | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm/dts/ast2600.dtsi b/arch/arm/dts/ast2600.dtsi > index 5c14a4a453..a383979ae7 100644 > --- a/arch/arm/dts/ast2600.dtsi > +++ b/arch/arm/dts/ast2600.dtsi > @@ -803,6 +803,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c1_default>; > status = "disabled"; > }; > > @@ -816,6 +818,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c2_default>; > status = "disabled"; > }; > > @@ -829,6 +833,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c3_default>; > }; > > i2c3: i2c@200 { > @@ -841,6 +847,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c4_default>; > }; > > i2c4: i2c@280 { > @@ -853,6 +861,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c5_default>; > }; > > i2c5: i2c@300 { > @@ -865,6 +875,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c6_default>; > }; > > i2c6: i2c@380 { > @@ -877,6 +889,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c7_default>; > }; > > i2c7: i2c@400 { > @@ -889,6 +903,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c8_default>; > }; > > i2c8: i2c@480 { > @@ -901,6 +917,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c9_default>; > }; > > i2c9: i2c@500 { > @@ -913,6 +931,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c10_default>; > status = "disabled"; > }; > > @@ -926,6 +946,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c11_default>; > status = "disabled"; > }; > > @@ -939,6 +961,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c12_default>; > status = "disabled"; > }; > > @@ -952,6 +976,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c13_default>; > status = "disabled"; > }; > > @@ -965,6 +991,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c14_default>; > status = "disabled"; > }; > > @@ -978,6 +1006,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c15_default>; > status = "disabled"; > }; > > @@ -991,6 +1021,8 @@ > bus-frequency = <100000>; > interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&scu ASPEED_CLK_APB2>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c16_default>; > status = "disabled"; > }; > > @@ -1218,6 +1250,7 @@ > function = "I2C1"; > groups = "I2C1"; > }; > + > pinctrl_i2c2_default: i2c2_default { > function = "I2C2"; > groups = "I2C2"; > -- > 2.27.0 >
diff --git a/arch/arm/dts/ast2600.dtsi b/arch/arm/dts/ast2600.dtsi index 5c14a4a453..a383979ae7 100644 --- a/arch/arm/dts/ast2600.dtsi +++ b/arch/arm/dts/ast2600.dtsi @@ -803,6 +803,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c1_default>; status = "disabled"; }; @@ -816,6 +818,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 111 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c2_default>; status = "disabled"; }; @@ -829,6 +833,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c3_default>; }; i2c3: i2c@200 { @@ -841,6 +847,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c4_default>; }; i2c4: i2c@280 { @@ -853,6 +861,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c5_default>; }; i2c5: i2c@300 { @@ -865,6 +875,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c6_default>; }; i2c6: i2c@380 { @@ -877,6 +889,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c7_default>; }; i2c7: i2c@400 { @@ -889,6 +903,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c8_default>; }; i2c8: i2c@480 { @@ -901,6 +917,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c9_default>; }; i2c9: i2c@500 { @@ -913,6 +931,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c10_default>; status = "disabled"; }; @@ -926,6 +946,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c11_default>; status = "disabled"; }; @@ -939,6 +961,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c12_default>; status = "disabled"; }; @@ -952,6 +976,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c13_default>; status = "disabled"; }; @@ -965,6 +991,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c14_default>; status = "disabled"; }; @@ -978,6 +1006,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c15_default>; status = "disabled"; }; @@ -991,6 +1021,8 @@ bus-frequency = <100000>; interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>; clocks = <&scu ASPEED_CLK_APB2>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c16_default>; status = "disabled"; }; @@ -1218,6 +1250,7 @@ function = "I2C1"; groups = "I2C1"; }; + pinctrl_i2c2_default: i2c2_default { function = "I2C2"; groups = "I2C2";
Set the pinctrl groups for each I2C bus. These are essential to I2C operating correctly. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- arch/arm/dts/ast2600.dtsi | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)