| Message ID | 20220505202829.31466-2-eajames@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | ast2600: Add I2C TPMv2 driver | expand |
On Thu, 5 May 2022 at 20:28, Eddie James <eajames@linux.ibm.com> wrote: > > SCL direct drive mode prevents communication with devices that > do clock stretching, so disable. The Linux driver doesn't use > this mode, and the engine can handle clock stretching. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> > --- > drivers/i2c/ast_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/ast_i2c.c b/drivers/i2c/ast_i2c.c > index bbc32d6cdb..13420ade84 100644 > --- a/drivers/i2c/ast_i2c.c > +++ b/drivers/i2c/ast_i2c.c > @@ -73,7 +73,7 @@ static void ast_i2c_init_bus(struct udevice *dev) > /* Enable Master Mode. Assuming single-master */ > writel(I2CD_MASTER_EN > | I2CD_M_SDA_LOCK_EN > - | I2CD_MULTI_MASTER_DIS | I2CD_M_SCL_DRIVE_EN, > + | I2CD_MULTI_MASTER_DIS, This driver is upstream, so it can be submitted there too. > &priv->regs->fcr); > /* Enable Interrupts */ > writel(I2CD_INTR_TX_ACK > -- > 2.27.0 >
diff --git a/drivers/i2c/ast_i2c.c b/drivers/i2c/ast_i2c.c index bbc32d6cdb..13420ade84 100644 --- a/drivers/i2c/ast_i2c.c +++ b/drivers/i2c/ast_i2c.c @@ -73,7 +73,7 @@ static void ast_i2c_init_bus(struct udevice *dev) /* Enable Master Mode. Assuming single-master */ writel(I2CD_MASTER_EN | I2CD_M_SDA_LOCK_EN - | I2CD_MULTI_MASTER_DIS | I2CD_M_SCL_DRIVE_EN, + | I2CD_MULTI_MASTER_DIS, &priv->regs->fcr); /* Enable Interrupts */ writel(I2CD_INTR_TX_ACK
SCL direct drive mode prevents communication with devices that do clock stretching, so disable. The Linux driver doesn't use this mode, and the engine can handle clock stretching. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- drivers/i2c/ast_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)