| Message ID | 20220128221054.2002911-1-j.neuschaefer@gmx.net |
|---|---|
| State | New |
| Headers | show |
| Series | ARM: dts: wpcm450: Enable watchdog by default | expand |
On Fri, 28 Jan 2022 at 22:11, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > > The watchdog timer is always usable, regardless of board design, so > there is no point in marking the watchdog device as disabled-by-default > in nuvoton-wpcm450.dtsi. > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> I assume this makes it always available for rebooting the system too? Reviewed-by: Joel Stanley <joel@jms.id.au> > --- > arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts | 4 ---- > arch/arm/boot/dts/nuvoton-wpcm450.dtsi | 1 - > 2 files changed, 5 deletions(-) > > diff --git a/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts b/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts > index 3ee61251a16d0..1ae7ae4804275 100644 > --- a/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts > +++ b/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts > @@ -77,7 +77,3 @@ &serial1 { > /* "Serial over LAN" port. Connected to ttyS2 of the host system. */ > status = "okay"; > }; > - > -&watchdog0 { > - status = "okay"; > -}; > diff --git a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi > index 93595850a4c3c..b9b669cd632f1 100644 > --- a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi > +++ b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi > @@ -81,7 +81,6 @@ watchdog0: watchdog@b800101c { > interrupts = <1 IRQ_TYPE_LEVEL_HIGH>; > reg = <0xb800101c 0x4>; > clocks = <&clk24m>; > - status = "disabled"; > }; > > aic: interrupt-controller@b8002000 { > -- > 2.34.1 >
On Mon, Jan 31, 2022 at 06:37:51AM +0000, Joel Stanley wrote: > On Fri, 28 Jan 2022 at 22:11, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > > > > The watchdog timer is always usable, regardless of board design, so > > there is no point in marking the watchdog device as disabled-by-default > > in nuvoton-wpcm450.dtsi. > > > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > > I assume this makes it always available for rebooting the system too? Yes, that should be the case. > Reviewed-by: Joel Stanley <joel@jms.id.au> Thanks, Jonathan
diff --git a/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts b/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts index 3ee61251a16d0..1ae7ae4804275 100644 --- a/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts +++ b/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts @@ -77,7 +77,3 @@ &serial1 { /* "Serial over LAN" port. Connected to ttyS2 of the host system. */ status = "okay"; }; - -&watchdog0 { - status = "okay"; -}; diff --git a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi index 93595850a4c3c..b9b669cd632f1 100644 --- a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi +++ b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi @@ -81,7 +81,6 @@ watchdog0: watchdog@b800101c { interrupts = <1 IRQ_TYPE_LEVEL_HIGH>; reg = <0xb800101c 0x4>; clocks = <&clk24m>; - status = "disabled"; }; aic: interrupt-controller@b8002000 {
The watchdog timer is always usable, regardless of board design, so there is no point in marking the watchdog device as disabled-by-default in nuvoton-wpcm450.dtsi. Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> --- arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts | 4 ---- arch/arm/boot/dts/nuvoton-wpcm450.dtsi | 1 - 2 files changed, 5 deletions(-) -- 2.34.1