| Message ID | 20210308225419.46530-2-eajames@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | Rainier and Everest system updates | expand |
On Mon, 8 Mar 2021 at 22:54, Eddie James <eajames@linux.ibm.com> wrote: > > From: Vishwanatha Subbanna <vishwa@linux.ibm.com> > > These LEDs are on the op-panel and are connected via a pca9551 i2c > LED expander. > > OpenBMC-Staging-Count: 1 > Signed-off-by: Vishwanatha Subbanna <vishwa@linux.ibm.com> > Reviewed-by: Eddie James <eajames@linux.ibm.com> > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 82 ++++++++++++++++++++ > 1 file changed, 82 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > index 0e1e76421d9d..fdeac6d0d8d3 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts > @@ -131,6 +131,38 @@ i2c2mux3: i2c@3 { > reg = <3>; > }; > }; > + > + leds { > + compatible = "gpio-leds"; > + > + /* System ID LED that is at front on Op Panel */ > + front-sys-id0 { > + retain-state-shutdown; > + default-state = "keep"; > + gpios = <&pca_oppanel 0 GPIO_ACTIVE_LOW>; > + }; > + > + /* System Attention Indicator ID LED that is at front on Op Panel */ > + front-check-log0 { > + retain-state-shutdown; > + default-state = "keep"; > + gpios = <&pca_oppanel 1 GPIO_ACTIVE_LOW>; > + }; > + > + /* Enclosure Fault LED that is at front on Op Panel */ > + front-enc-fault1 { > + retain-state-shutdown; > + default-state = "keep"; > + gpios = <&pca_oppanel 2 GPIO_ACTIVE_LOW>; > + }; > + > + /* System PowerOn LED that is at front on Op Panel */ > + front-sys-pwron0 { > + retain-state-shutdown; > + default-state = "keep"; > + gpios = <&pca_oppanel 3 GPIO_ACTIVE_LOW>; > + }; > + }; > }; > > &ehci1 { > @@ -848,6 +880,56 @@ ibm-panel@62 { > reg = <(0x62 | I2C_OWN_SLAVE_ADDRESS)>; > }; > > + pca_oppanel: pca9551@60 { > + compatible = "nxp,pca9551"; > + reg = <0x60>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + gpio-controller; > + #gpio-cells = <2>; > + > + gpio@0 { > + reg = <0>; > + type = <PCA955X_TYPE_GPIO>; > + }; > + > + gpio@1 { > + reg = <1>; > + type = <PCA955X_TYPE_GPIO>; > + }; > + > + gpio@2 { > + reg = <2>; > + type = <PCA955X_TYPE_GPIO>; > + }; > + > + gpio@3 { > + reg = <3>; > + type = <PCA955X_TYPE_GPIO>; > + }; > + > + gpio@4 { > + reg = <4>; > + type = <PCA955X_TYPE_GPIO>; > + }; Why do we enable all 8 lines as GPIOs if we're only using the first four? > + > + gpio@5 { > + reg = <5>; > + type = <PCA955X_TYPE_GPIO>; > + }; > + > + gpio@6 { > + reg = <6>; > + type = <PCA955X_TYPE_GPIO>; > + }; > + > + gpio@7 { > + reg = <7>; > + type = <PCA955X_TYPE_GPIO>; > + }; > + }; > + > dps: dps310@76 { > compatible = "infineon,dps310"; > reg = <0x76>; > -- > 2.27.0 >
diff --git a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts index 0e1e76421d9d..fdeac6d0d8d3 100644 --- a/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts +++ b/arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts @@ -131,6 +131,38 @@ i2c2mux3: i2c@3 { reg = <3>; }; }; + + leds { + compatible = "gpio-leds"; + + /* System ID LED that is at front on Op Panel */ + front-sys-id0 { + retain-state-shutdown; + default-state = "keep"; + gpios = <&pca_oppanel 0 GPIO_ACTIVE_LOW>; + }; + + /* System Attention Indicator ID LED that is at front on Op Panel */ + front-check-log0 { + retain-state-shutdown; + default-state = "keep"; + gpios = <&pca_oppanel 1 GPIO_ACTIVE_LOW>; + }; + + /* Enclosure Fault LED that is at front on Op Panel */ + front-enc-fault1 { + retain-state-shutdown; + default-state = "keep"; + gpios = <&pca_oppanel 2 GPIO_ACTIVE_LOW>; + }; + + /* System PowerOn LED that is at front on Op Panel */ + front-sys-pwron0 { + retain-state-shutdown; + default-state = "keep"; + gpios = <&pca_oppanel 3 GPIO_ACTIVE_LOW>; + }; + }; }; &ehci1 { @@ -848,6 +880,56 @@ ibm-panel@62 { reg = <(0x62 | I2C_OWN_SLAVE_ADDRESS)>; }; + pca_oppanel: pca9551@60 { + compatible = "nxp,pca9551"; + reg = <0x60>; + #address-cells = <1>; + #size-cells = <0>; + + gpio-controller; + #gpio-cells = <2>; + + gpio@0 { + reg = <0>; + type = <PCA955X_TYPE_GPIO>; + }; + + gpio@1 { + reg = <1>; + type = <PCA955X_TYPE_GPIO>; + }; + + gpio@2 { + reg = <2>; + type = <PCA955X_TYPE_GPIO>; + }; + + gpio@3 { + reg = <3>; + type = <PCA955X_TYPE_GPIO>; + }; + + gpio@4 { + reg = <4>; + type = <PCA955X_TYPE_GPIO>; + }; + + gpio@5 { + reg = <5>; + type = <PCA955X_TYPE_GPIO>; + }; + + gpio@6 { + reg = <6>; + type = <PCA955X_TYPE_GPIO>; + }; + + gpio@7 { + reg = <7>; + type = <PCA955X_TYPE_GPIO>; + }; + }; + dps: dps310@76 { compatible = "infineon,dps310"; reg = <0x76>;