diff mbox series

[u-boot,v2019.04-aspeed-openbmc,v2,4/6] config: ast2600: Disable unused features

Message ID 20210127070054.81719-5-joel@jms.id.au
State New
Headers show
Series FIT verification | expand

Commit Message

Joel Stanley Jan. 27, 2021, 7 a.m. UTC 
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 configs/ast2600_openbmc_spl_emmc_defconfig | 3 +++
 1 file changed, 3 insertions(+)

Comments

Klaus Heinrich Kiwi Jan. 27, 2021, 7:29 p.m. UTC | #1 
Hi Joel,

> +# CONFIG_SPL_DOS_PARTITION is not set
Sounds good.


> +# CONFIG_MMC_VERBOSE is not set
>   CONFIG_SPL_MMC_TINY=y
>   CONFIG_MMC_SDHCI=y
>   CONFIG_MMC_SDHCI_ASPEED=y
> @@ -128,6 +130,7 @@ CONFIG_DM_SPI=y
>   CONFIG_SYSRESET=y
>   CONFIG_WDT=y
>   CONFIG_USE_TINY_PRINTF=y
> +# CONFIG_REGEX is not set
Are those influencing the SPL size or just U-boot proper?

At any rate, I don't have objections.

Reviewed-by: Klaus Heinrich Kiwi <klaus@linux.vnet.ibm.com>
Andrew Jeffery Jan. 27, 2021, 11:47 p.m. UTC | #2 
On Thu, 28 Jan 2021, at 05:59, Klaus Heinrich Kiwi wrote:
> Hi Joel,
> 
> > +# CONFIG_SPL_DOS_PARTITION is not set
> Sounds good.
> 
> 
> > +# CONFIG_MMC_VERBOSE is not set
> >   CONFIG_SPL_MMC_TINY=y
> >   CONFIG_MMC_SDHCI=y
> >   CONFIG_MMC_SDHCI_ASPEED=y
> > @@ -128,6 +130,7 @@ CONFIG_DM_SPI=y
> >   CONFIG_SYSRESET=y
> >   CONFIG_WDT=y
> >   CONFIG_USE_TINY_PRINTF=y
> > +# CONFIG_REGEX is not set
> Are those influencing the SPL size or just U-boot proper?

The SPL needs MMC support to load u-boot, so I assume CONFIG_MMC_VERBOSE=n is 
worthwhile.

Acked-by: Andrew Jeffery <andrew@aj.id.au>
diff mbox series

Patch

diff --git a/configs/ast2600_openbmc_spl_emmc_defconfig b/configs/ast2600_openbmc_spl_emmc_defconfig
index 20f2e7019cb3..3f2de64e077d 100644
--- a/configs/ast2600_openbmc_spl_emmc_defconfig
+++ b/configs/ast2600_openbmc_spl_emmc_defconfig
@@ -83,6 +83,7 @@  CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_CMD_MTDPARTS=y
+# CONFIG_SPL_DOS_PARTITION is not set
 # CONFIG_SPL_EFI_PARTITION is not set
 CONFIG_SPL_OF_CONTROL=y
 CONFIG_ENV_IS_IN_MMC=y
@@ -100,6 +101,7 @@  CONFIG_SYS_I2C_ASPEED=y
 CONFIG_MISC=y
 CONFIG_ASPEED_AHBC=y
 CONFIG_DM_MMC=y
+# CONFIG_MMC_VERBOSE is not set
 CONFIG_SPL_MMC_TINY=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_ASPEED=y
@@ -128,6 +130,7 @@  CONFIG_DM_SPI=y
 CONFIG_SYSRESET=y
 CONFIG_WDT=y
 CONFIG_USE_TINY_PRINTF=y
+# CONFIG_REGEX is not set
 CONFIG_TPM=y
 CONFIG_SPL_TPM=y
 # CONFIG_EFI_LOADER is not set